From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20BC0C433DF for ; Sat, 30 May 2020 00:30:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C040520774 for ; Sat, 30 May 2020 00:30:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="MAZf0Q2t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C040520774 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 207516E98C; Sat, 30 May 2020 00:30:00 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 480686E98C for ; Sat, 30 May 2020 00:29:58 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1408E2A5; Sat, 30 May 2020 02:29:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1590798596; bh=xg05yyY1B3shla40YDICr/xk7yfPLPIrQgntw0KLitg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MAZf0Q2tAlc8D/G4bylxsDYQsqCerWw0RsWH2ctwalqv45+V9oKsngKpf4tfrly0m vEdlqqLa3PAq8rUUIXxU07LEjIVOpmpY2SjdsJLYmFHLXMods174Hc8vPSN8u1cTQf yQwdsbaGX9cKRMBj+VOKDhwpyhaVRlRzvmEJQUK8= Date: Sat, 30 May 2020 03:29:40 +0300 From: Laurent Pinchart To: Stefan Agner Subject: Re: [PATCH 00/21] drm: mxsfb: Add i.MX7 support Message-ID: <20200530002940.GA5961@pendragon.ideasonboard.com> References: <20200309195216.31042-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , kernel@pengutronix.de, dri-devel@lists.freedesktop.org, linux-imx@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Stefan, On Tue, May 26, 2020 at 05:13:42PM +0200, Stefan Agner wrote: > On 2020-03-09 20:51, Laurent Pinchart wrote: > > Hello, > > > > This patch series adds i.MX7 support to the mxsfb driver. The eLCDIF > > instance found in the i.MX7 is backward-compatible with the already > > supported LCDC v4, but has extended features amongst which the most > > notable one is a second plane. > > > > The first 9 patches (01/21 to 09/21) contain miscellaneous cleanups and > > refactoring to prepare for what is to come. Patch 10/21 starts the real > > work with removal of the DRM simple display pipeline helper, as it > > doesn't support multiple planes. The next patch (11/21) is an additional > > cleanup. > > > > Patches 12/21 to 14/21 fix vblank handling that I found to be broken > > when testing on my device. Patch 15/21 then performs an additional small > > cleanup, and patch 16/21 starts official support for i.MX7 by mentioning > > it in Kconfig. > > > > Patch 17/21 adds a new device model for the i.MX6SX and i.MX7 eLCDIF. > > After three additional cleanups in patches 18/21 to 20/21, patch 21/21 > > finally adds support for the second plane. > > > > The code is based on drm-misc-next and has been tested on an i.MX7D > > platform with a DPI panel. > > Did you plan to update this series? I guess some of the changes I could > already merge now. I'm resuming work on it now, will incorporate your review comments and send a v2. Feel free to apply some of the changes already if you want to. > > Laurent Pinchart (21): > > drm: mxsfb: Remove fbdev leftovers > > drm: mxsfb: Use drm_panel_bridge > > drm: mxsfb: Use BIT() macro to define register bitfields > > drm: mxsfb: Remove unused macros from mxsfb_regs.h > > drm: mxsfb: Clarify format and bus width configuration > > drm: mxsfb: Pass mxsfb_drm_private pointer to mxsfb_reset_block() > > drm: mxsfb: Use LCDC_CTRL register name explicitly > > drm: mxsfb: Remove register definitions from mxsfb_crtc.c > > drm: mxsfb: Remove unneeded includes > > drm: mxsfb: Stop using DRM simple display pipeline helper > > drm: mxsfb: Rename mxsfb_crtc.c to mxsfb_kms.c > > drm: mxsfb: Move vblank event arm to CRTC .atomic_flush() > > drm: mxsfb: Don't touch AXI clock in IRQ context > > drm: mxsfb: Enable vblank handling > > drm: mxsfb: Remove mxsfb_devdata unused fields > > drm: mxsfb: Add i.MX7 to the list of supported SoCs in Kconfig > > drm: mxsfb: Update internal IP version number for i.MX6SX > > drm: mxsfb: Drop non-OF support > > drm: mxsfb: Turn mxsfb_set_pixel_fmt() into a void function > > drm: mxsfb: Merge mxsfb_set_pixel_fmt() and mxsfb_set_bus_fmt() > > drm: mxsfb: Support the alpha plane > > > > drivers/gpu/drm/mxsfb/Kconfig | 4 +- > > drivers/gpu/drm/mxsfb/Makefile | 2 +- > > drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 343 ----------------- > > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 246 ++++--------- > > drivers/gpu/drm/mxsfb/mxsfb_drv.h | 42 ++- > > drivers/gpu/drm/mxsfb/mxsfb_kms.c | 565 +++++++++++++++++++++++++++++ > > drivers/gpu/drm/mxsfb/mxsfb_out.c | 99 ----- > > drivers/gpu/drm/mxsfb/mxsfb_regs.h | 107 +++--- > > 8 files changed, 730 insertions(+), 678 deletions(-) > > delete mode 100644 drivers/gpu/drm/mxsfb/mxsfb_crtc.c > > create mode 100644 drivers/gpu/drm/mxsfb/mxsfb_kms.c > > delete mode 100644 drivers/gpu/drm/mxsfb/mxsfb_out.c -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel