From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B2B2C433E0 for ; Sat, 30 May 2020 00:33:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 089BE20774 for ; Sat, 30 May 2020 00:33:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="XmhyE4Se" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 089BE20774 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C9586E98E; Sat, 30 May 2020 00:33:43 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 236BD6E98E for ; Sat, 30 May 2020 00:33:42 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A2D02A5; Sat, 30 May 2020 02:33:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1590798820; bh=wzw8V5ZWsuApgSk9geW9Dr6AolgvJX74ZawxAbR0A+k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XmhyE4Se+LVeskixRyeklzNy0B4pjddnlU9EoTyNJYKhuuskfj083sSRX0C2lr4mQ IJlO1kabsBMXOBQvRAWWhcRRk4H53UTRb3SOKOMbVzAGvafO0b71I1ivy4HU/2zXA2 oVddOVtTe8i6m7T9bEgj9eCJhGyhA8nev+3PzMWo= Date: Sat, 30 May 2020 03:33:26 +0300 From: Laurent Pinchart To: Stefan Agner Subject: Re: [PATCH 09/21] drm: mxsfb: Remove unneeded includes Message-ID: <20200530003326.GB5961@pendragon.ideasonboard.com> References: <20200309195216.31042-1-laurent.pinchart@ideasonboard.com> <20200309195216.31042-10-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , kernel@pengutronix.de, dri-devel@lists.freedesktop.org, linux-imx@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Stefan, On Mon, Mar 23, 2020 at 10:53:50PM +0100, Stefan Agner wrote: > On 2020-03-09 20:52, Laurent Pinchart wrote: > > A fair number of includes are not needed. Drop them, and add a couple of > > required includes that were included indirectly. > > > > Signed-off-by: Laurent Pinchart > > Out of curiosity, do you have some kind of tool helping with this? No, that was manual. > Reviewed-by: Stefan Agner > > > --- > > drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 12 +++--------- > > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 5 ----- > > 2 files changed, 3 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c > > b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c > > index aef72adabf41..c4f1575b4210 100644 > > --- a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c > > +++ b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c > > @@ -10,19 +10,13 @@ > > > > #include > > #include > > -#include > > -#include > > +#include > > > > -#include