From: Sam Ravnborg <sam@ravnborg.org>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Liu Ying <victor.liu@nxp.com>,
devicetree <devicetree@vger.kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/panel: simple: Add support for KOE TX26D202VM0BWA panel
Date: Tue, 2 Jun 2020 22:56:53 +0200 [thread overview]
Message-ID: <20200602205653.GC56418@ravnborg.org> (raw)
In-Reply-To: <CACvgo50UOby-xV_OYmM55VUXUbwLxK-q6bs2FoS_FuwB9ChYJg@mail.gmail.com>
Hi Emil.
On Tue, Jun 02, 2020 at 01:46:19PM +0100, Emil Velikov wrote:
> On Tue, 2 Jun 2020 at 08:17, Liu Ying <victor.liu@nxp.com> wrote:
> >
> > This patch adds support for Kaohsiung Opto-Electronics Inc.
> > 10.1" TX26D202VM0BWA WUXGA(1920x1200) TFT LCD panel with LVDS interface.
> > The panel has dual LVDS channels.
> >
> > My panel is manufactured by US Micro Products(USMP). There is a tag at
> > the back of the panel, which indicates the panel type is 'TX26D202VM0BWA'
> > and it's made by KOE in Taiwan.
> >
> > The panel spec from USMP can be found at:
> > https://www.usmicroproducts.com/sites/default/files/datasheets/USMP-T101-192120NDU-A0.pdf
> >
> > The below panel spec from KOE is basically the same to the one from USMP.
> > However, the panel type 'TX26D202VM0BAA' is a little bit different.
> > It looks that the two types of panel are compatible with each other.
> > http://www.koe.j-display.com/upload/product/TX26D202VM0BAA.pdf
> >
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> > drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++++++++
> > 1 file changed, 34 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index b6ecd15..7c222ec 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -2200,6 +2200,37 @@ static const struct panel_desc koe_tx14d24vm1bpa = {
> > },
> > };
> >
> > +static const struct display_timing koe_tx26d202vm0bwa_timing = {
> > + .pixelclock = { 151820000, 156720000, 159780000 },
> > + .hactive = { 1920, 1920, 1920 },
> > + .hfront_porch = { 105, 130, 142 },
> > + .hback_porch = { 45, 70, 82 },
> > + .hsync_len = { 30, 30, 30 },
> > + .vactive = { 1200, 1200, 1200},
> > + .vfront_porch = { 3, 5, 10 },
> > + .vback_porch = { 2, 5, 10 },
> > + .vsync_len = { 5, 5, 5 },
> > +};
> > +
> > +static const struct panel_desc koe_tx26d202vm0bwa = {
> > + .timings = &koe_tx26d202vm0bwa_timing,
> > + .num_timings = 1,
> > + .bpc = 8,
> > + .size = {
> > + .width = 217,
> > + .height = 136,
> > + },
> > + .delay = {
> > + .prepare = 1000,
> > + .enable = 1000,
> > + .unprepare = 1000,
> > + .disable = 1000,
> Ouch 1s for each delay is huge. Nevertheless it matches the specs so,
> the series is:
> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
>
> Sam, Thierry I assume you'll merge the series. Let me know if I should
> pick it up.
I am quite busy with non-linux stuff these days so fine if you can pick
them up. I like that simple panel patches are processed fast.
I expect to have some hours for linux work friday or saturday, but no
promises...
Sam
>
> -Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-02 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 6:11 [PATCH 2/2] drm/panel: simple: Add support for KOE TX26D202VM0BWA panel Liu Ying
2020-06-02 12:46 ` Emil Velikov
2020-06-02 20:56 ` Sam Ravnborg [this message]
2020-06-03 17:15 ` Emil Velikov
2020-06-03 19:54 ` Sam Ravnborg
2020-06-05 15:48 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602205653.GC56418@ravnborg.org \
--to=sam@ravnborg.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=linux-imx@nxp.com \
--cc=thierry.reding@gmail.com \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).