dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: abrodkin@synopsys.com, airlied@linux.ie, daniel@ffwll.ch,
	james.qian.wang@arm.com, liviu.dudau@arm.com,
	mihail.atanassov@arm.com, brian.starkey@arm.com, joel@jms.id.au,
	andrew@aj.id.au, sam@ravnborg.org, bbrezillon@kernel.org,
	nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
	ludovic.desroches@microchip.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	stefan@agner.ch, alison.wang@nxp.com, xinliang.liu@linaro.org,
	zourongrong@gmail.com, john.stultz@linaro.org,
	kong.kongxinwei@hisilicon.com, puck.chen@hisilicon.com,
	p.zabel@pengutronix.de, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com, paul@crapouillou.net,
	linus.walleij@linaro.org, narmstrong@baylibre.com,
	khilman@baylibre.com, marex@denx.de,
	laurent.pinchart@ideasonboard.com,
	kieran.bingham+renesas@ideasonboard.com,
	benjamin.gaignard@linaro.org, vincent.abriou@st.com,
	yannick.fertre@st.com, philippe.cornu@st.com,
	mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
	wens@csie.org, jsarha@ti.com, tomi.valkeinen@ti.com,
	noralf@tronnes.org
Cc: linux-arm-kernel@lists.infradead.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org,
	Emil Velikov <emil.velikov@collabora.com>
Subject: [PATCH v2 10/23] drm/ingenic: Use GEM CMA object functions
Date: Wed,  3 Jun 2020 10:31:19 +0200	[thread overview]
Message-ID: <20200603083132.4610-11-tzimmermann@suse.de> (raw)
In-Reply-To: <20200603083132.4610-1-tzimmermann@suse.de>

The ingenic driver uses the default implementation for CMA functions. The
DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver.

Using DRM_GEM_CMA_DRIVER_OPS introduces several changes: the driver now
sets .gem_create_object to drm_cma_gem_create_object_default_funcs(),
which sets CMA GEM object functions. GEM object functions implement the
rsp operations where possible. Corresponding interfaces in struct drm_driver
are cleared. Prime import now uses drm_gem_cma_prime_import_sg_table_vmap(),
which maps the imported buffer upon import. Mmap operations are performed
by drm_gem_prime_mmap(), which goes through GEM file operations. These
changes have been part of the aspeed driver for some time.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Tested-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Acked-by: Emil Velikov <emil.velikov@collabora.com>
---
 drivers/gpu/drm/ingenic/ingenic-drm.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c
index 55b49a31729bf..16f0740df507c 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
@@ -519,18 +519,7 @@ static struct drm_driver ingenic_drm_driver_data = {
 	.patchlevel		= 0,
 
 	.fops			= &ingenic_drm_fops,
-
-	.dumb_create		= drm_gem_cma_dumb_create,
-	.gem_free_object_unlocked = drm_gem_cma_free_object,
-	.gem_vm_ops		= &drm_gem_cma_vm_ops,
-
-	.prime_handle_to_fd	= drm_gem_prime_handle_to_fd,
-	.prime_fd_to_handle	= drm_gem_prime_fd_to_handle,
-	.gem_prime_get_sg_table	= drm_gem_cma_prime_get_sg_table,
-	.gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
-	.gem_prime_vmap		= drm_gem_cma_prime_vmap,
-	.gem_prime_vunmap	= drm_gem_cma_prime_vunmap,
-	.gem_prime_mmap		= drm_gem_cma_prime_mmap,
+	DRM_GEM_CMA_DRIVER_OPS,
 
 	.irq_handler		= ingenic_drm_irq_handler,
 };
-- 
2.26.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-06-03  8:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03  8:31 [PATCH v2 00/23] drm: Convert most CMA-based drivers to GEM object functions Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 01/23] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 02/23] drm/arc: Use GEM CMA object functions Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 03/23] drm/arm: " Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 04/23] drm/aspeed: Set driver CMA functions with DRM_GEM_CMA_DRIVER_OPS Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 05/23] drm/atmel-hlcdc: Use GEM CMA object functions Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 06/23] drm/fsl-dcu: " Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 07/23] drm/hisilicon/kirin: Set .dumb_create to drm_gem_cma_dumb_create() Thomas Zimmermann
2020-06-04  5:49   ` John Stultz
2020-06-03  8:31 ` [PATCH v2 08/23] drm/hisilicon/kirin: Use GEM CMA object functions Thomas Zimmermann
2020-06-04  5:49   ` John Stultz
2020-06-03  8:31 ` [PATCH v2 09/23] drm/imx: " Thomas Zimmermann
2020-06-03  8:31 ` Thomas Zimmermann [this message]
2020-06-03  8:31 ` [PATCH v2 11/23] drm/komeda: " Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 12/23] drm/malidp: " Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 13/23] drm/mcde: " Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 14/23] drm/meson: " Thomas Zimmermann
2020-06-04  7:59   ` Neil Armstrong
2020-06-03  8:31 ` [PATCH v2 15/23] drm/mxsfb: " Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 16/23] drm/rcar-du: " Thomas Zimmermann
2020-06-04  3:00   ` Laurent Pinchart
2020-06-03  8:31 ` [PATCH v2 17/23] drm/shmobile: " Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 18/23] drm/stm: " Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 19/23] drm/sti: " Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 20/23] drm/tilcdc: " Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 21/23] drm/tv200: " Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 22/23] drm/zte: " Thomas Zimmermann
2020-06-03  8:31 ` [PATCH v2 23/23] drm: Remove struct drm_driver.gem_print_info Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200603083132.4610-11-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=abrodkin@synopsys.com \
    --cc=airlied@linux.ie \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexandre.torgue@st.com \
    --cc=alison.wang@nxp.com \
    --cc=andrew@aj.id.au \
    --cc=bbrezillon@kernel.org \
    --cc=benjamin.gaignard@linaro.org \
    --cc=brian.starkey@arm.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.velikov@collabora.com \
    --cc=festevam@gmail.com \
    --cc=james.qian.wang@arm.com \
    --cc=joel@jms.id.au \
    --cc=john.stultz@linaro.org \
    --cc=jsarha@ti.com \
    --cc=kernel@pengutronix.de \
    --cc=khilman@baylibre.com \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-imx@nxp.com \
    --cc=liviu.dudau@arm.com \
    --cc=ludovic.desroches@microchip.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marex@denx.de \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mihail.atanassov@arm.com \
    --cc=mripard@kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=noralf@tronnes.org \
    --cc=p.zabel@pengutronix.de \
    --cc=paul@crapouillou.net \
    --cc=philippe.cornu@st.com \
    --cc=puck.chen@hisilicon.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sam@ravnborg.org \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    --cc=tomi.valkeinen@ti.com \
    --cc=vincent.abriou@st.com \
    --cc=wens@csie.org \
    --cc=xinliang.liu@linaro.org \
    --cc=yannick.fertre@st.com \
    --cc=zourongrong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).