dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/panel: simple: Set connector type for DSI panels
@ 2020-06-02 17:12 Laurent Pinchart
  2020-06-03  8:20 ` Daniel Vetter
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Laurent Pinchart @ 2020-06-02 17:12 UTC (permalink / raw)
  To: dri-devel; +Cc: Thierry Reding, Sam Ravnborg

None of the DSI panels set the connector_type in their panel_desc
descriptor. As they are all guaranteed to be DSI panels, that's an easy
fix, set the connector type to DRM_MODE_CONNECTOR_DSI.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index b6ecd1552132..b86b52bfece7 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -4082,6 +4082,7 @@ static const struct panel_desc_dsi auo_b080uan01 = {
 			.width = 108,
 			.height = 272,
 		},
+		.connector_type = DRM_MODE_CONNECTOR_DSI,
 	},
 	.flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_CLOCK_NON_CONTINUOUS,
 	.format = MIPI_DSI_FMT_RGB888,
@@ -4110,6 +4111,7 @@ static const struct panel_desc_dsi boe_tv080wum_nl0 = {
 			.width = 107,
 			.height = 172,
 		},
+		.connector_type = DRM_MODE_CONNECTOR_DSI,
 	},
 	.flags = MIPI_DSI_MODE_VIDEO |
 		 MIPI_DSI_MODE_VIDEO_BURST |
@@ -4140,6 +4142,7 @@ static const struct panel_desc_dsi lg_ld070wx3_sl01 = {
 			.width = 94,
 			.height = 151,
 		},
+		.connector_type = DRM_MODE_CONNECTOR_DSI,
 	},
 	.flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_CLOCK_NON_CONTINUOUS,
 	.format = MIPI_DSI_FMT_RGB888,
@@ -4168,6 +4171,7 @@ static const struct panel_desc_dsi lg_lh500wx1_sd03 = {
 			.width = 62,
 			.height = 110,
 		},
+		.connector_type = DRM_MODE_CONNECTOR_DSI,
 	},
 	.flags = MIPI_DSI_MODE_VIDEO,
 	.format = MIPI_DSI_FMT_RGB888,
@@ -4196,6 +4200,7 @@ static const struct panel_desc_dsi panasonic_vvx10f004b00 = {
 			.width = 217,
 			.height = 136,
 		},
+		.connector_type = DRM_MODE_CONNECTOR_DSI,
 	},
 	.flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
 		 MIPI_DSI_CLOCK_NON_CONTINUOUS,
@@ -4225,6 +4230,7 @@ static const struct panel_desc_dsi lg_acx467akm_7 = {
 			.width = 62,
 			.height = 110,
 		},
+		.connector_type = DRM_MODE_CONNECTOR_DSI,
 	},
 	.flags = 0,
 	.format = MIPI_DSI_FMT_RGB888,
@@ -4254,6 +4260,7 @@ static const struct panel_desc_dsi osd101t2045_53ts = {
 			.width = 217,
 			.height = 136,
 		},
+		.connector_type = DRM_MODE_CONNECTOR_DSI,
 	},
 	.flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
 		 MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/panel: simple: Set connector type for DSI panels
  2020-06-02 17:12 [PATCH] drm/panel: simple: Set connector type for DSI panels Laurent Pinchart
@ 2020-06-03  8:20 ` Daniel Vetter
  2020-06-03 14:43 ` Thierry Reding
  2020-06-04 20:11 ` Sam Ravnborg
  2 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2020-06-03  8:20 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: Thierry Reding, Sam Ravnborg, dri-devel

On Tue, Jun 02, 2020 at 08:12:40PM +0300, Laurent Pinchart wrote:
> None of the DSI panels set the connector_type in their panel_desc
> descriptor. As they are all guaranteed to be DSI panels, that's an easy
> fix, set the connector type to DRM_MODE_CONNECTOR_DSI.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index b6ecd1552132..b86b52bfece7 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -4082,6 +4082,7 @@ static const struct panel_desc_dsi auo_b080uan01 = {
>  			.width = 108,
>  			.height = 272,
>  		},
> +		.connector_type = DRM_MODE_CONNECTOR_DSI,
>  	},
>  	.flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_CLOCK_NON_CONTINUOUS,
>  	.format = MIPI_DSI_FMT_RGB888,
> @@ -4110,6 +4111,7 @@ static const struct panel_desc_dsi boe_tv080wum_nl0 = {
>  			.width = 107,
>  			.height = 172,
>  		},
> +		.connector_type = DRM_MODE_CONNECTOR_DSI,
>  	},
>  	.flags = MIPI_DSI_MODE_VIDEO |
>  		 MIPI_DSI_MODE_VIDEO_BURST |
> @@ -4140,6 +4142,7 @@ static const struct panel_desc_dsi lg_ld070wx3_sl01 = {
>  			.width = 94,
>  			.height = 151,
>  		},
> +		.connector_type = DRM_MODE_CONNECTOR_DSI,
>  	},
>  	.flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_CLOCK_NON_CONTINUOUS,
>  	.format = MIPI_DSI_FMT_RGB888,
> @@ -4168,6 +4171,7 @@ static const struct panel_desc_dsi lg_lh500wx1_sd03 = {
>  			.width = 62,
>  			.height = 110,
>  		},
> +		.connector_type = DRM_MODE_CONNECTOR_DSI,
>  	},
>  	.flags = MIPI_DSI_MODE_VIDEO,
>  	.format = MIPI_DSI_FMT_RGB888,
> @@ -4196,6 +4200,7 @@ static const struct panel_desc_dsi panasonic_vvx10f004b00 = {
>  			.width = 217,
>  			.height = 136,
>  		},
> +		.connector_type = DRM_MODE_CONNECTOR_DSI,
>  	},
>  	.flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
>  		 MIPI_DSI_CLOCK_NON_CONTINUOUS,
> @@ -4225,6 +4230,7 @@ static const struct panel_desc_dsi lg_acx467akm_7 = {
>  			.width = 62,
>  			.height = 110,
>  		},
> +		.connector_type = DRM_MODE_CONNECTOR_DSI,
>  	},
>  	.flags = 0,
>  	.format = MIPI_DSI_FMT_RGB888,
> @@ -4254,6 +4260,7 @@ static const struct panel_desc_dsi osd101t2045_53ts = {
>  			.width = 217,
>  			.height = 136,
>  		},
> +		.connector_type = DRM_MODE_CONNECTOR_DSI,
>  	},
>  	.flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
>  		 MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/panel: simple: Set connector type for DSI panels
  2020-06-02 17:12 [PATCH] drm/panel: simple: Set connector type for DSI panels Laurent Pinchart
  2020-06-03  8:20 ` Daniel Vetter
@ 2020-06-03 14:43 ` Thierry Reding
  2020-06-04 20:11 ` Sam Ravnborg
  2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2020-06-03 14:43 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: Sam Ravnborg, dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 497 bytes --]

On Tue, Jun 02, 2020 at 08:12:40PM +0300, Laurent Pinchart wrote:
> None of the DSI panels set the connector_type in their panel_desc
> descriptor. As they are all guaranteed to be DSI panels, that's an easy
> fix, set the connector type to DRM_MODE_CONNECTOR_DSI.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 7 +++++++
>  1 file changed, 7 insertions(+)

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/panel: simple: Set connector type for DSI panels
  2020-06-02 17:12 [PATCH] drm/panel: simple: Set connector type for DSI panels Laurent Pinchart
  2020-06-03  8:20 ` Daniel Vetter
  2020-06-03 14:43 ` Thierry Reding
@ 2020-06-04 20:11 ` Sam Ravnborg
  2 siblings, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2020-06-04 20:11 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: Thierry Reding, dri-devel

On Tue, Jun 02, 2020 at 08:12:40PM +0300, Laurent Pinchart wrote:
> None of the DSI panels set the connector_type in their panel_desc
> descriptor. As they are all guaranteed to be DSI panels, that's an easy
> fix, set the connector type to DRM_MODE_CONNECTOR_DSI.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Thanks, applied.

	Sam

> ---
>  drivers/gpu/drm/panel/panel-simple.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index b6ecd1552132..b86b52bfece7 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -4082,6 +4082,7 @@ static const struct panel_desc_dsi auo_b080uan01 = {
>  			.width = 108,
>  			.height = 272,
>  		},
> +		.connector_type = DRM_MODE_CONNECTOR_DSI,
>  	},
>  	.flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_CLOCK_NON_CONTINUOUS,
>  	.format = MIPI_DSI_FMT_RGB888,
> @@ -4110,6 +4111,7 @@ static const struct panel_desc_dsi boe_tv080wum_nl0 = {
>  			.width = 107,
>  			.height = 172,
>  		},
> +		.connector_type = DRM_MODE_CONNECTOR_DSI,
>  	},
>  	.flags = MIPI_DSI_MODE_VIDEO |
>  		 MIPI_DSI_MODE_VIDEO_BURST |
> @@ -4140,6 +4142,7 @@ static const struct panel_desc_dsi lg_ld070wx3_sl01 = {
>  			.width = 94,
>  			.height = 151,
>  		},
> +		.connector_type = DRM_MODE_CONNECTOR_DSI,
>  	},
>  	.flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_CLOCK_NON_CONTINUOUS,
>  	.format = MIPI_DSI_FMT_RGB888,
> @@ -4168,6 +4171,7 @@ static const struct panel_desc_dsi lg_lh500wx1_sd03 = {
>  			.width = 62,
>  			.height = 110,
>  		},
> +		.connector_type = DRM_MODE_CONNECTOR_DSI,
>  	},
>  	.flags = MIPI_DSI_MODE_VIDEO,
>  	.format = MIPI_DSI_FMT_RGB888,
> @@ -4196,6 +4200,7 @@ static const struct panel_desc_dsi panasonic_vvx10f004b00 = {
>  			.width = 217,
>  			.height = 136,
>  		},
> +		.connector_type = DRM_MODE_CONNECTOR_DSI,
>  	},
>  	.flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
>  		 MIPI_DSI_CLOCK_NON_CONTINUOUS,
> @@ -4225,6 +4230,7 @@ static const struct panel_desc_dsi lg_acx467akm_7 = {
>  			.width = 62,
>  			.height = 110,
>  		},
> +		.connector_type = DRM_MODE_CONNECTOR_DSI,
>  	},
>  	.flags = 0,
>  	.format = MIPI_DSI_FMT_RGB888,
> @@ -4254,6 +4260,7 @@ static const struct panel_desc_dsi osd101t2045_53ts = {
>  			.width = 217,
>  			.height = 136,
>  		},
> +		.connector_type = DRM_MODE_CONNECTOR_DSI,
>  	},
>  	.flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
>  		 MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-06-04 20:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 17:12 [PATCH] drm/panel: simple: Set connector type for DSI panels Laurent Pinchart
2020-06-03  8:20 ` Daniel Vetter
2020-06-03 14:43 ` Thierry Reding
2020-06-04 20:11 ` Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).