From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D5DBC433E0 for ; Wed, 10 Jun 2020 15:00:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D7792072F for ; Wed, 10 Jun 2020 15:00:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D7792072F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8892E89F6F; Wed, 10 Jun 2020 15:00:02 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC4DB89F6F for ; Wed, 10 Jun 2020 15:00:00 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id B8B1780615; Wed, 10 Jun 2020 16:59:55 +0200 (CEST) Date: Wed, 10 Jun 2020 16:59:54 +0200 From: Sam Ravnborg To: Matthias Schiffer Subject: Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Message-ID: <20200610145954.GA135509@ravnborg.org> References: <20200610120131.3069-1-matthias.schiffer@ew.tq-group.com> <20200610120131.3069-4-matthias.schiffer@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200610120131.3069-4-matthias.schiffer@ew.tq-group.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=G88y7es5 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=8f9FM25-AAAA:8 a=_tJ-VA_NSDcjsCNOPhgA:9 a=INdImr_puP3_IQRK:21 a=8TxJKwd5zFIMyFNg:21 a=CjuIK1q_8ugA:10 a=uSNRK0Bqq4PXrUp6LDpb:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Thierry Reding Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Matthias. Thanks, a few details you need to fix. See below. Sam On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote: > From: Michael Krummsdorf > > Add support for the CDTech Electronics displays S070PWS19HP-FC21 > (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel-simple. > > Signed-off-by: Michael Krummsdorf > Signed-off-by: Matthias Schiffer > --- > drivers/gpu/drm/panel/panel-simple.c | 60 ++++++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index b6ecd1552132..1673113e5a5a 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1315,6 +1315,60 @@ static const struct panel_desc cdtech_s043wq26h_ct7 = { > .bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > }; > > +/* S070PWS19HP-FC21 2017/04/22 */ > +static const struct drm_display_mode cdtech_s070pws19hp_fc21_mode = { > + .clock = 51200, > + .hdisplay = 1024, > + .hsync_start = 1024 + 160, > + .hsync_end = 1024 + 160 + 20, > + .htotal = 1024 + 160 + 20 + 140, > + .vdisplay = 600, > + .vsync_start = 600 + 12, > + .vsync_end = 600 + 12 + 3, > + .vtotal = 600 + 12 + 3 + 20, > + .vrefresh = 60, .vrefresh is no longer present, please drop. > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, > +}; > + > +static const struct panel_desc cdtech_s070pws19hp_fc21 = { > + .modes = &cdtech_s070pws19hp_fc21_mode, > + .num_modes = 1, > + .bpc = 6, > + .size = { > + .width = 154, > + .height = 86, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE, > +}; Please add .connector_type - it is mandatory. > + > +/* S070SWV29HG-DC44 2017/09/21 */ > +static const struct drm_display_mode cdtech_s070swv29hg_dc44_mode = { > + .clock = 33300, > + .hdisplay = 800, > + .hsync_start = 800 + 210, > + .hsync_end = 800 + 210 + 2, > + .htotal = 800 + 210 + 2 + 44, > + .vdisplay = 480, > + .vsync_start = 480 + 22, > + .vsync_end = 480 + 22 + 2, > + .vtotal = 480 + 22 + 2 + 21, > + .vrefresh = 60, .vrefresh is no longer present, please drop. > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, > +}; > + > +static const struct panel_desc cdtech_s070swv29hg_dc44 = { > + .modes = &cdtech_s070swv29hg_dc44_mode, > + .num_modes = 1, > + .bpc = 6, > + .size = { > + .width = 154, > + .height = 86, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE, Please add .connector_type - it is mandatory. > +}; > + > static const struct drm_display_mode cdtech_s070wv95_ct16_mode = { > .clock = 35000, > .hdisplay = 800, > @@ -3723,6 +3777,12 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "cdtech,s043wq26h-ct7", > .data = &cdtech_s043wq26h_ct7, > + }, { > + .compatible = "cdtech,s070pws19hp-fc21", > + .data = &cdtech_s070pws19hp_fc21, > + }, { > + .compatible = "cdtech,s070swv29hg-dc44", > + .data = &cdtech_s070swv29hg_dc44, > }, { > .compatible = "cdtech,s070wv95-ct16", > .data = &cdtech_s070wv95_ct16, > -- > 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel