From: Philip Li <philip.li@intel.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: kbuild-all@lists.01.org, kernel test robot <lkp@intel.com>,
Russell King <linux@armlinux.org.uk>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Sean Paul <sean@poorly.run>,
LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/4] drm: pl111: Update documentation
Date: Wed, 17 Jun 2020 08:33:28 +0800 [thread overview]
Message-ID: <20200617003328.GB26983@intel.com> (raw)
In-Reply-To: <CACvgo536CxAynhx3zcamS2-e=a7j++X7X66N4zG_L_HrjLk77A@mail.gmail.com>
On Tue, Jun 16, 2020 at 05:12:51PM +0100, Emil Velikov wrote:
> Hi all,
>
> Inspired by Linus and my personal confusion with the report, allow me
> to put some suggestions. Followed by an illustrative example.
thanks for all the suggestions, we will take them into consideration
to gradually improve the report.
>
> On Wed, 10 Jun 2020 at 08:38, kernel test robot <lkp@intel.com> wrote:
> >
> > Hi Linus,
> >
> > I love your patch! Perhaps something to improve:
> >
> > [auto build test WARNING on drm-exynos/exynos-drm-next]
> > [also build test WARNING on drm-intel/for-linux-next tegra-drm/drm/tegra/for-next linus/master v5.7 next-20200609]
> One thing which was always inclear me - is the warning identical in
> all the branches listed.
yes, they contain same warning, we will clarify this.
>
> > [cannot apply to drm-tip/drm-tip drm/drm-next]
> > [if your patch is applied to the wrong git tree, please drop us a note to help
> > improve the system. BTW, we also suggest to use '--base' option to specify the
> > base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> >
> Reference to the manual tends to be better than an old SO thread.
got it, we will refer to your later example to enhance here.
>
> > url: https://github.com/0day-ci/linux/commits/Linus-Walleij/drm-pl111-Credit-where-credit-is-due/20200610-041025
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
> > reproduce: make htmldocs
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>, old ones prefixed by <<):
> >
> Please do not list old warnings/errors. They only distract and dilute
> what/where the problem is.
early on, there's a request to view the old warning of modpost related
issue in case it is a false positive due to modpost output format changing.
we will think of this to limit to modpost only.
>
>
> > vim +1 drivers/gpu/drm/pl111/pl111_drv.c
> >
> > e559355a9da60a Thomas Gleixner 2019-06-01 @1 // SPDX-License-Identifier: GPL-2.0-only
> > bed41005e6174d Tom Cooksey 2017-04-12 2 /*
> > bed41005e6174d Tom Cooksey 2017-04-12 3 * (C) COPYRIGHT 2012-2013 ARM Limited. All rights reserved.
> > bed41005e6174d Tom Cooksey 2017-04-12 4 *
> > bed41005e6174d Tom Cooksey 2017-04-12 5 * Parts of this file were based on sources as follows:
> > bed41005e6174d Tom Cooksey 2017-04-12 6 *
> > bed41005e6174d Tom Cooksey 2017-04-12 7 * Copyright (c) 2006-2008 Intel Corporation
> > bed41005e6174d Tom Cooksey 2017-04-12 8 * Copyright (c) 2007 Dave Airlie <airlied@linux.ie>
> > bed41005e6174d Tom Cooksey 2017-04-12 9 * Copyright (C) 2011 Texas Instruments
> > bed41005e6174d Tom Cooksey 2017-04-12 10 */
> > bed41005e6174d Tom Cooksey 2017-04-12 11
> >
> > :::::: The code at line 1 was first introduced by commit
> > :::::: e559355a9da60a2388893d9e9da66c79fd604b9a treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 443
> >
> > :::::: TO: Thomas Gleixner <tglx@linutronix.de>
> > :::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> All of this seems useful when debugging the kernel test robot itself.
> Which in this case is misleading as hell.
thanks, we will check above 4 lines with ::::: to adjust if needed.
>
>
> Here is something which is much shorter, with clearer structure and
> reads much easier.
this is very helpful and can provide a different perspective for how
the report is. We will learn from it to imporve the report.
>
> ---
> Hi Linus,
>
> This is an automated message from your friendly test robot.
> We've noticed some issues with your patch although being a robot,
> kindly double-check the results.
>
> Branches:
> [if the warning/errors are the same group them, otherwise split them
> in separate sections]
>
> - drm-exynos/exynos-drm-next [1]: WARNING
> - drm-intel/for-linux-next [2]: WARNING
> - .... : WARNING
> drivers/gpu/drm/pl111/pl111_drv.c:1: warning: 'ARM PrimeCell PL111
> CLCD Driver' not found
> - tegra-drm/drm/tegra/for-next [3]: WARNING
> some other warning
> - drm-tip/drm-tip [4] drm/drm-next [5]: cannot apply series
>
> Note: when submitting patches, please use `--base` as documented in
> https://git-scm.com/docs/git-format-patch.
>
>
> To reproduce:
> - wget https://url/to/build/toolchain // when applicable
> - wget https://url/to/config // when applicable
> - make htmldocs // use explicit make command instead of magic shell
> script, as seen in the cross build reports
>
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> Thank you
> The LKP team
>
> [1] URI to the drm-exynos/exynos-drm-next repo
> [2] URI to the drm-intel/for-linux-next repo
> [3] URI to the ...
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-06-17 0:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 20:04 [PATCH 1/4] drm: pl111: Credit where credit is due Linus Walleij
2020-06-09 20:04 ` [PATCH 2/4] video: fbdev: amba-clcd: Retire elder CLCD driver Linus Walleij
2020-09-15 1:10 ` Peter Collingbourne
2020-09-21 21:32 ` Linus Walleij
2020-09-22 4:10 ` Peter Collingbourne
2020-09-22 19:43 ` Peter Collingbourne
2020-06-09 20:04 ` [PATCH 3/4] drm: pl111: Absorb the external register header Linus Walleij
2020-06-09 20:04 ` [PATCH 4/4] drm: pl111: Update documentation Linus Walleij
2020-06-09 20:10 ` Eric Anholt
2020-06-09 20:17 ` Linus Walleij
2020-06-09 20:53 ` Eric Anholt
2020-06-10 7:37 ` kernel test robot
2020-06-12 11:04 ` Linus Walleij
2020-06-12 11:14 ` Sam Ravnborg
2020-06-12 12:40 ` [kbuild-all] " Philip Li
2020-06-22 9:28 ` Rong Chen
2020-06-16 16:12 ` Emil Velikov
2020-06-17 0:33 ` Philip Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617003328.GB26983@intel.com \
--to=philip.li@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).