From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB1FC433E0 for ; Wed, 17 Jun 2020 07:26:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C605208B8 for ; Wed, 17 Jun 2020 07:26:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C605208B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivo.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0CFA26E2F2; Wed, 17 Jun 2020 07:26:03 +0000 (UTC) Received: from m17617.mail.qiye.163.com (m17617.mail.qiye.163.com [59.111.176.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5BCE46E0FA for ; Wed, 17 Jun 2020 02:38:52 +0000 (UTC) Received: from njvxl5505.vivo.xyz (unknown [157.0.31.125]) by m17617.mail.qiye.163.com (Hmail) with ESMTPA id 65297261496; Wed, 17 Jun 2020 10:38:47 +0800 (CST) From: Bernard Zhao To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpu/drm: remove drm_modeset_lock protection for drm_error Date: Wed, 17 Jun 2020 10:38:40 +0800 Message-Id: <20200617023840.11637-1-bernard@vivo.com> X-Mailer: git-send-email 2.17.1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZGhhDHkhOSU0fSBlMVkpOQklITUpOSUxOQ0NVEwETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKS09ISFVKS0tZBg++ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MyI6Tgw4CzgyMw4sM00VSxcM FxhPCUlVSlVKTkJJSE1KTklDS0pIVTMWGhIXVRkeCRUaCR87DRINFFUYFBZFWVdZEgtZQVlKTkxV S1VISlVKSU5ZV1kIAVlBSUtCSjcG X-HM-Tid: 0a72c024a8f19375kuws65297261496 X-Mailman-Approved-At: Wed, 17 Jun 2020 07:26:03 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: opensource.kernel@vivo.com, Bernard Zhao MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In function drm_atomic_helper_shutdown, maybe there is no need to protect DRM_ERROR log in DRM_MODESET_LOCK_ALL_BEGIN & DRM_MODESET_LOCK_ALL_END. This change is to make code run a bit fast. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/drm_atomic_helper.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 85d163f16801..8902fd6316fc 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -3100,12 +3100,10 @@ void drm_atomic_helper_shutdown(struct drm_device *dev) int ret; DRM_MODESET_LOCK_ALL_BEGIN(dev, ctx, 0, ret); - ret = drm_atomic_helper_disable_all(dev, &ctx); + DRM_MODESET_LOCK_ALL_END(ctx, ret); if (ret) DRM_ERROR("Disabling all crtc's during unload failed with %i\n", ret); - - DRM_MODESET_LOCK_ALL_END(ctx, ret); } EXPORT_SYMBOL(drm_atomic_helper_shutdown); -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel