From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55AFCC433E0 for ; Tue, 23 Jun 2020 16:57:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D6972076E for ; Tue, 23 Jun 2020 16:57:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D6972076E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8EC0D6EA0C; Tue, 23 Jun 2020 16:57:12 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 62D186EA0C for ; Tue, 23 Jun 2020 16:57:10 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 3F19F80475; Tue, 23 Jun 2020 18:57:08 +0200 (CEST) Date: Tue, 23 Jun 2020 18:57:06 +0200 From: Sam Ravnborg To: Thomas Zimmermann Subject: Re: [PATCH 02/14] drm/ast: Pass struct ast_private instance to cursor init/fini functions Message-ID: <20200623165706.GB781557@ravnborg.org> References: <20200623081901.10667-1-tzimmermann@suse.de> <20200623081901.10667-3-tzimmermann@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200623081901.10667-3-tzimmermann@suse.de> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=G88y7es5 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=VE4umfYFkgB_yB78vNgA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emil.l.velikov@gmail.com, dri-devel@lists.freedesktop.org, kraxel@redhat.com, airlied@redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Thomas. On Tue, Jun 23, 2020 at 10:18:49AM +0200, Thomas Zimmermann wrote: > Removes some typecasting. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/ast/ast_cursor.c | 7 +++---- > drivers/gpu/drm/ast/ast_drv.h | 4 ++-- > drivers/gpu/drm/ast/ast_mode.c | 6 ++++-- > 3 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/ast/ast_cursor.c b/drivers/gpu/drm/ast/ast_cursor.c > index 53bb6eebc7cd..1d4f51a7fe22 100644 > --- a/drivers/gpu/drm/ast/ast_cursor.c > +++ b/drivers/gpu/drm/ast/ast_cursor.c > @@ -34,9 +34,9 @@ > /* > * Allocate cursor BOs and pins them at the end of VRAM. > */ > -int ast_cursor_init(struct drm_device *dev) > +int ast_cursor_init(struct ast_private *ast) > { > - struct ast_private *ast = to_ast_private(dev); > + struct drm_device *dev = ast->dev; > size_t size, i; > struct drm_gem_vram_object *gbo; > int ret; > @@ -72,9 +72,8 @@ int ast_cursor_init(struct drm_device *dev) > return ret; > } > > -void ast_cursor_fini(struct drm_device *dev) > +void ast_cursor_fini(struct ast_private *ast) > { > - struct ast_private *ast = to_ast_private(dev); > size_t i; > struct drm_gem_vram_object *gbo; > > diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h > index 245ed2e2d775..f7b120f862a8 100644 > --- a/drivers/gpu/drm/ast/ast_drv.h > +++ b/drivers/gpu/drm/ast/ast_drv.h > @@ -316,8 +316,8 @@ void ast_init_3rdtx(struct drm_device *dev); > void ast_release_firmware(struct drm_device *dev); > > /* ast_cursor.c */ > -int ast_cursor_init(struct drm_device *dev); > -void ast_cursor_fini(struct drm_device *dev); > +int ast_cursor_init(struct ast_private *ast); > +void ast_cursor_fini(struct ast_private *ast); > int ast_cursor_update(void *dst, void *src, unsigned int width, > unsigned int height); > void ast_cursor_set_base(struct ast_private *ast, u64 address); > diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c > index c8399699d773..243715e9c237 100644 > --- a/drivers/gpu/drm/ast/ast_mode.c > +++ b/drivers/gpu/drm/ast/ast_mode.c > @@ -1149,7 +1149,7 @@ int ast_mode_init(struct drm_device *dev) > drm_plane_helper_add(&ast->cursor_plane, > &ast_cursor_plane_helper_funcs); > > - ast_cursor_init(dev); > + ast_cursor_init(ast); > ast_crtc_init(dev); > ast_encoder_init(dev); > ast_connector_init(dev); > @@ -1159,7 +1159,9 @@ int ast_mode_init(struct drm_device *dev) > > void ast_mode_fini(struct drm_device *dev) > { > - ast_cursor_fini(dev); > + struct ast_private *ast = dev->dev_private; Better to use to_ast_private(dev), to avoid the deprecated dev_private. With this fixed: Acked-by: Sam Ravnborg > + > + ast_cursor_fini(ast); > } > > static int get_clock(void *i2c_priv) > -- > 2.27.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel