From: kernel test robot <lkp@intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
airlied@redhat.com, daniel@ffwll.ch, noralf@tronnes.org,
kraxel@redhat.com, emil.l.velikov@gmail.com, sam@ravnborg.org,
yc_chen@aspeedtech.com
Cc: kbuild-all@lists.01.org, dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH 09/14] drm/ast: Keep cursor HW BOs mapped
Date: Wed, 24 Jun 2020 15:58:16 +0800 [thread overview]
Message-ID: <20200624075816.GC27515@xsang-OptiPlex-9020> (raw)
In-Reply-To: <20200623081901.10667-10-tzimmermann@suse.de>
[-- Attachment #1: Type: text/plain, Size: 4219 bytes --]
Hi Thomas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on next-20200623]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.8-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-ast-Managed-modesetting/20200623-162238
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
:::::: branch date: 19 hours ago
:::::: commit date: 19 hours ago
config: x86_64-randconfig-s021-20200623 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/ast/ast_cursor.c:250:26: sparse: sparse: duplicate [noderef]
>> drivers/gpu/drm/ast/ast_cursor.c:250:26: sparse: sparse: multiple address space given: __iomem & __iomem
# https://github.com/0day-ci/linux/commit/f438d6b57853cfafd5057aef14de32086b93e43d
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout f438d6b57853cfafd5057aef14de32086b93e43d
vim +250 drivers/gpu/drm/ast/ast_cursor.c
233fef619e5ac2 Thomas Zimmermann 2020-06-23 245
f438d6b57853cf Thomas Zimmermann 2020-06-23 246 void ast_cursor_show(struct ast_private *ast, int x, int y,
233fef619e5ac2 Thomas Zimmermann 2020-06-23 247 unsigned int offset_x, unsigned int offset_y)
30686a542ba2b5 Thomas Zimmermann 2020-06-23 248 {
233fef619e5ac2 Thomas Zimmermann 2020-06-23 249 u8 x_offset, y_offset;
f438d6b57853cf Thomas Zimmermann 2020-06-23 @250 u8 __iomem *dst, __iomem *sig;
30686a542ba2b5 Thomas Zimmermann 2020-06-23 251 u8 jreg;
30686a542ba2b5 Thomas Zimmermann 2020-06-23 252
f438d6b57853cf Thomas Zimmermann 2020-06-23 253 dst = ast->cursor.vaddr[ast->cursor.next_index];
30686a542ba2b5 Thomas Zimmermann 2020-06-23 254
30686a542ba2b5 Thomas Zimmermann 2020-06-23 255 sig = dst + AST_HWC_SIZE;
30686a542ba2b5 Thomas Zimmermann 2020-06-23 256 writel(x, sig + AST_HWC_SIGNATURE_X);
30686a542ba2b5 Thomas Zimmermann 2020-06-23 257 writel(y, sig + AST_HWC_SIGNATURE_Y);
30686a542ba2b5 Thomas Zimmermann 2020-06-23 258
30686a542ba2b5 Thomas Zimmermann 2020-06-23 259 if (x < 0) {
233fef619e5ac2 Thomas Zimmermann 2020-06-23 260 x_offset = (-x) + offset_x;
30686a542ba2b5 Thomas Zimmermann 2020-06-23 261 x = 0;
233fef619e5ac2 Thomas Zimmermann 2020-06-23 262 } else {
233fef619e5ac2 Thomas Zimmermann 2020-06-23 263 x_offset = offset_x;
30686a542ba2b5 Thomas Zimmermann 2020-06-23 264 }
30686a542ba2b5 Thomas Zimmermann 2020-06-23 265 if (y < 0) {
233fef619e5ac2 Thomas Zimmermann 2020-06-23 266 y_offset = (-y) + offset_y;
30686a542ba2b5 Thomas Zimmermann 2020-06-23 267 y = 0;
233fef619e5ac2 Thomas Zimmermann 2020-06-23 268 } else {
233fef619e5ac2 Thomas Zimmermann 2020-06-23 269 y_offset = offset_y;
30686a542ba2b5 Thomas Zimmermann 2020-06-23 270 }
233fef619e5ac2 Thomas Zimmermann 2020-06-23 271
233fef619e5ac2 Thomas Zimmermann 2020-06-23 272 ast_cursor_set_location(ast, x, y, x_offset, y_offset);
30686a542ba2b5 Thomas Zimmermann 2020-06-23 273
30686a542ba2b5 Thomas Zimmermann 2020-06-23 274 /* dummy write to fire HWC */
30686a542ba2b5 Thomas Zimmermann 2020-06-23 275 jreg = 0x02 |
30686a542ba2b5 Thomas Zimmermann 2020-06-23 276 0x01; /* enable ARGB4444 cursor */
30686a542ba2b5 Thomas Zimmermann 2020-06-23 277 ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xcb, 0xfc, jreg);
30686a542ba2b5 Thomas Zimmermann 2020-06-23 278 }
10536b22de4fbf Thomas Zimmermann 2020-06-23 279
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31062 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-24 7:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 8:18 [PATCH 00/14] drm/ast: Managed modesetting Thomas Zimmermann
2020-06-23 8:18 ` [PATCH 01/14] drm/ast: Move cursor functions to ast_cursor.c Thomas Zimmermann
2020-06-23 16:55 ` Sam Ravnborg
2020-06-24 6:24 ` Thomas Zimmermann
2020-07-02 11:41 ` Thomas Zimmermann
2020-06-23 8:18 ` [PATCH 02/14] drm/ast: Pass struct ast_private instance to cursor init/fini functions Thomas Zimmermann
2020-06-23 16:57 ` Sam Ravnborg
2020-06-23 8:18 ` [PATCH 03/14] drm/ast: Move cursor fb pinning and mapping into helper Thomas Zimmermann
2020-06-23 8:18 ` [PATCH 04/14] drm/ast: Update cursor image and checksum from same function Thomas Zimmermann
2020-06-23 8:18 ` [PATCH 05/14] drm/ast: Move cursor pageflip into helper Thomas Zimmermann
2020-06-23 8:18 ` [PATCH 06/14] drm/ast: Replace ast_cursor_move() with ast_cursor_show() Thomas Zimmermann
2020-06-23 8:18 ` [PATCH 07/14] drm/ast: Don't enable HW cursors twice during atomic update Thomas Zimmermann
2020-06-23 8:18 ` [PATCH 08/14] drm/ast: Add helper to hide cursor Thomas Zimmermann
2020-06-23 8:18 ` [PATCH 09/14] drm/ast: Keep cursor HW BOs mapped Thomas Zimmermann
2020-06-24 7:58 ` kernel test robot [this message]
2020-06-23 8:18 ` [PATCH 10/14] drm/ast: Managed cursor release Thomas Zimmermann
2020-06-23 8:18 ` [PATCH 11/14] drm/ast: Init cursors before creating modesetting structures Thomas Zimmermann
2020-06-23 8:18 ` [PATCH 12/14] drm/ast: Replace struct ast_crtc with struct drm_crtc Thomas Zimmermann
2020-06-23 8:19 ` [PATCH 13/14] drm/ast: Use managed mode-config init Thomas Zimmermann
2020-06-23 8:19 ` [PATCH 14/14] drm/ast: Initialize mode setting in ast_mode_config_init() Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624075816.GC27515@xsang-OptiPlex-9020 \
--to=lkp@intel.com \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kraxel@redhat.com \
--cc=noralf@tronnes.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
--cc=yc_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).