From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8F12C433DF for ; Wed, 24 Jun 2020 13:27:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CF1820836 for ; Wed, 24 Jun 2020 13:27:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="DfCE+6p7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CF1820836 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E0C26EB4B; Wed, 24 Jun 2020 13:27:18 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8521A6EB49 for ; Wed, 24 Jun 2020 13:27:16 +0000 (UTC) Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7BE620738; Wed, 24 Jun 2020 13:27:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593005236; bh=Uvzn5GGmX3qulKFklqhuFpDaBfwgpNZzFNj7oeuicfM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DfCE+6p7BklpNaLNzQGhFErdJ9GEeuS7AoSebSPlnZJF5jsAgVtdGk7vUEwnjQGgM Fn2nQQELoj20anBdPArhIYnmlCcO2McCZEr2SrlB22cC8+EVhVWDkjq3ApDnPNuzAW 6nsZgily1LPUOeIOBI2Li9olPjFfkoKLlrTYAVm0= Date: Wed, 24 Jun 2020 14:27:14 +0100 From: Mark Brown To: Andrzej Hajda Subject: Re: [RESEND PATCH v5 1/5] driver core: add probe_err log helper Message-ID: <20200624132714.GD5472@sirena.org.uk> References: <20200624114127.3016-1-a.hajda@samsung.com> <20200624114127.3016-2-a.hajda@samsung.com> MIME-Version: 1.0 In-Reply-To: <20200624114127.3016-2-a.hajda@samsung.com> X-Cookie: So this is it. We're going to die. User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , "Rafael J. Wysocki" , Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, "open list:DRM DRIVERS" , Russell King - ARM Linux , Neil Armstrong , Jonas Karlman , andy.shevchenko@gmail.com, Laurent Pinchart , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: multipart/mixed; boundary="===============1181669495==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============1181669495== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EY/WZ/HvNxOox07X" Content-Disposition: inline --EY/WZ/HvNxOox07X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 24, 2020 at 01:41:23PM +0200, Andrzej Hajda wrote: > During probe every time driver gets resource it should usually check for error > printk some message if it is not -EPROBE_DEFER and return the error. This As I said down the thread that's not a great pattern since it means that probe deferral errors never get displayed and users have a hard time figuring out why their driver isn't instantiating. --EY/WZ/HvNxOox07X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7zVLEACgkQJNaLcl1U h9ATPwgAhY22sy/BHlt091VyG8FAdVlhbYN6mk0lzhvHH7Vi9lhuFnpv4CoWIPp9 H3U6sE0bCKLDG8crEhrVfxSMYy8XdDafn37Ua0NYY/gKj3xKfLvZ6SgYAxKN9ljb Fsr2TgqJzAlbV3h5wI9HX8GOzK3YU6qD0lv8QzWu4UU0zkgXD1ty2jIwAa/zv4F0 BvCMvOshZd7pXBg0unqxP0vm3dbOUbC3dup88YjidkmYYYQl8IHbPlrwtDlhVrk3 Eq3t9t69041O+cB6Rg6QIvKAumr/d5BmCqbajAXowB67NKvxxqzOhCIntTqKEiVw U7DHVCCkPY49rXIH1tKz1ahQhgdu5w== =XUqJ -----END PGP SIGNATURE----- --EY/WZ/HvNxOox07X-- --===============1181669495== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1181669495==--