From: Lee Jones <lee.jones@linaro.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight
Date: Thu, 25 Jun 2020 09:03:37 +0100 [thread overview]
Message-ID: <20200625080337.GN954398@dell> (raw)
In-Reply-To: <20200624162446.GA1815586@ravnborg.org>
On Wed, 24 Jun 2020, Sam Ravnborg wrote:
> Hi Lee.
>
> On Wed, Jun 24, 2020 at 04:43:21PM +0100, Lee Jones wrote:
> > On Wed, 24 Jun 2020, Sam Ravnborg wrote:
> >
> > > Hi Lee.
> > >
> > > On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote:
> > > > Attempting to clean-up W=1 kernel builds, which are currently
> > > > overwhelmingly riddled with niggly little warnings.
> > > >
> > > > Lee Jones (8):
> > > > backlight: lms501kf03: Remove unused const variables
> > > > backlight: lcd: Add missing kerneldoc entry for 'struct device parent'
> > >
> > >
> > > > backlight: ili922x: Add missing kerneldoc descriptions for
> > > > CHECK_FREQ_REG() args
> > > > backlight: ili922x: Remove invalid use of kerneldoc syntax
> > > > backlight: ili922x: Add missing kerneldoc description for
> > > > ili922x_reg_dump()'s arg
> > > I wonder why these warnings show up as nothing pulls in this .c file.
> > > Anyway I would suggest to drop using kerneldoc syntax for single drivers
> > > like this - and the benefit here is low.
> > > Now they are typed, otherwise this ahd been fine in a single patch.
> >
> > What do you mean by 'nothing pulls it in'?
> There are no .rst files that includes any:
> .. kernel-doc:: drivers/video/backlight/ili922x.c
>
> so I do not see how the kernel-doc comments will be used by any
> of the generated kernel-docs.
Looks like a common problem (if it is actually a problem):
$ ./scripts/find-unused-docs.sh . | wc -l
1476
The role of this patch-set is not to eradicate unused kerneldoc
headers, but to ensure they are formatted correctly. W=1 builds
currently complain of ill formatted kerneldocs, which is currently
littering the build-log and masking some more important issues (which
I'm also trying to fix en route).
> > > > backlight: backlight: Supply description for function args in existing
> > > > Kerneldocs
> > > > backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0
> > > > backlight: qcom-wled: Remove unused configs for LED3 and LED4
> > >
> > > The other fixes looks good.
> > > They are all:
> > > Acked-by: Sam Ravnborg <sam@ravnborg.org>
> >
> > Thanks (although this should be Reviewed-by).
> >
> > > > drivers/video/backlight/backlight.c | 2 ++
> > > > drivers/video/backlight/ili922x.c | 8 ++++++--
> > > > drivers/video/backlight/lcd.c | 1 +
> > > > drivers/video/backlight/lm3630a_bl.c | 4 ++--
> > > > drivers/video/backlight/lms501kf03.c | 8 --------
> > > > drivers/video/backlight/qcom-wled.c | 8 --------
> > > > 6 files changed, 11 insertions(+), 20 deletions(-)
> > > >
> >
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-25 8:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 14:57 [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Lee Jones
2020-06-24 14:57 ` [PATCH 1/8] backlight: lms501kf03: Remove unused const variables Lee Jones
2020-06-25 9:24 ` Daniel Thompson
2020-06-24 14:57 ` [PATCH 2/8] backlight: lcd: Add missing kerneldoc entry for 'struct device parent' Lee Jones
2020-06-25 9:28 ` Daniel Thompson
2020-06-24 14:57 ` [PATCH 3/8] backlight: ili922x: Add missing kerneldoc descriptions for CHECK_FREQ_REG() args Lee Jones
2020-06-25 9:40 ` Daniel Thompson
2020-06-25 10:33 ` Lee Jones
2020-06-26 9:54 ` Daniel Thompson
2020-06-26 15:33 ` Lee Jones
2020-07-06 7:12 ` Lee Jones
2020-06-24 14:57 ` [PATCH 4/8] backlight: ili922x: Remove invalid use of kerneldoc syntax Lee Jones
2020-06-25 9:41 ` Daniel Thompson
2020-06-24 14:57 ` [PATCH 5/8] backlight: ili922x: Add missing kerneldoc description for ili922x_reg_dump()'s arg Lee Jones
2020-06-25 9:43 ` Daniel Thompson
2020-07-06 7:13 ` Lee Jones
2020-06-24 14:57 ` [PATCH 6/8] backlight: backlight: Supply description for function args in existing Kerneldocs Lee Jones
2020-06-25 9:43 ` Daniel Thompson
2020-06-24 14:57 ` [PATCH 7/8] backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0 Lee Jones
2020-06-25 9:45 ` Daniel Thompson
2020-06-24 14:57 ` [PATCH 8/8] backlight: qcom-wled: Remove unused configs for LED3 and LED4 Lee Jones
2020-06-25 9:46 ` Daniel Thompson
2020-06-24 15:32 ` [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Sam Ravnborg
2020-06-24 15:43 ` Lee Jones
2020-06-24 16:24 ` Sam Ravnborg
2020-06-25 8:03 ` Lee Jones [this message]
2020-06-25 18:57 ` Sam Ravnborg
2020-07-06 7:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625080337.GN954398@dell \
--to=lee.jones@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).