From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56E21C433E0 for ; Sun, 28 Jun 2020 08:15:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 200DD20771 for ; Sun, 28 Jun 2020 08:15:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="srFzktyq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 200DD20771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 856236E1F2; Sun, 28 Jun 2020 08:15:25 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A56A6E1F2 for ; Sun, 28 Jun 2020 08:15:23 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D4B5D4FB; Sun, 28 Jun 2020 10:15:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1593332122; bh=sh0RggDsKmrfTB0YKVOydS4uXtS2gKdlcDk2gSToPlw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=srFzktyqSN465QKXohi4o0TJpW3NM5J6Pos52Rw0NlWRBqeyVzG80OMlR7Qa3LYJj RZuYtGgD3Pw2ThHt4/S17qEUF6xmFvKGQr6aK0hFwhQ3mQeGoCnzACKkZX0dApLuhy zbP6IVlaERHsXojBn23bGihSJOFqm0r0svluCpm0= Date: Sun, 28 Jun 2020 11:15:19 +0300 From: Laurent Pinchart To: Liu Ying Subject: Re: [PATCH 1/2] drm/bridge: dw-hdmi: Don't cleanup i2c adapter and ddc ptr in __dw_hdmi_probe() bailout path Message-ID: <20200628081519.GE6954@pendragon.ideasonboard.com> References: <1592298292-17634-1-git-send-email-victor.liu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1592298292-17634-1-git-send-email-victor.liu@nxp.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: joabreu@synopsys.com, jernej.skrabec@siol.net, darekm@google.com, jonas@kwiboo.se, airlied@linux.ie, narmstrong@baylibre.com, architt@codeaurora.org, dri-devel@lists.freedesktop.org, a.hajda@samsung.com, boris.brezillon@collabora.com, linux-imx@nxp.com, cychiang@chromium.org, jbrunet@baylibre.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Liu, Thank you for the patch. On Tue, Jun 16, 2020 at 05:04:51PM +0800, Liu Ying wrote: > It's unnecessary to cleanup the i2c adapter and the ddc pointer in > the bailout path of __dw_hdmi_probe(), since the adapter is not > added and the ddc pointer is not set. Indeed. The code doesn't hurt, but is unnecessary. Reviewed-by: Laurent Pinchart > Fixes: a23d6265f033 (drm: bridge: dw-hdmi: Extract PHY interrupt setup to a function) > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec > Cc: David Airlie > Cc: Daniel Vetter > Cc: Boris Brezillon > Cc: Jerome Brunet > Cc: Cheng-Yi Chiang > Cc: Dariusz Marcinkiewicz > Cc: Archit Taneja > Cc: Jose Abreu > Cc: dri-devel@lists.freedesktop.org > Cc: NXP Linux Team > Signed-off-by: Liu Ying > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 30681398c..da84a91 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -3358,11 +3358,6 @@ __dw_hdmi_probe(struct platform_device *pdev, > return hdmi; > > err_iahb: > - if (hdmi->i2c) { > - i2c_del_adapter(&hdmi->i2c->adap); > - hdmi->ddc = NULL; > - } > - > clk_disable_unprepare(hdmi->iahb_clk); > if (hdmi->cec_clk) > clk_disable_unprepare(hdmi->cec_clk); -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel