dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: John Clements <john.clements@amd.com>
Cc: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
	kbuild-all@lists.01.org, dri-devel@lists.freedesktop.org
Subject: [radeon-alex:amd-staging-drm-next 9971/9999] drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:2280:5: warning: no previous prototype for 'parse_ta_bin_descriptor'
Date: Wed, 8 Jul 2020 08:25:05 +0800	[thread overview]
Message-ID: <202007080801.GDGm0BQ4%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 5687 bytes --]

tree:   git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
head:   6b7ad8618edbe6aecf1122e654d08a8237471800
commit: be165aab3d558e3b8573d0e2699c42af5b0f62c8 [9971/9999] drm/amdgpu: updated ta ucode loading
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout be165aab3d558e3b8573d0e2699c42af5b0f62c8
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:2280:5: warning: no previous prototype for 'parse_ta_bin_descriptor' [-Wmissing-prototypes]
    2280 | int parse_ta_bin_descriptor(struct psp_context *psp,
         |     ^~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:29:
   drivers/gpu/drm/amd/amdgpu/amdgpu.h:192:19: warning: 'debug_evictions' defined but not used [-Wunused-const-variable=]
     192 | static const bool debug_evictions; /* = false */
         |                   ^~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/amdgpu.h:191:18: warning: 'sched_policy' defined but not used [-Wunused-const-variable=]
     191 | static const int sched_policy = KFD_SCHED_POLICY_HWS;
         |                  ^~~~~~~~~~~~
   In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_types.h:33,
                    from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:30,
                    from drivers/gpu/drm/amd/amdgpu/../include/dm_pp_interface.h:26,
                    from drivers/gpu/drm/amd/amdgpu/amdgpu.h:65,
                    from drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:29:
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:76:32: warning: 'dc_fixpt_ln2_div_2' defined but not used [-Wunused-const-variable=]
      76 | static const struct fixed31_32 dc_fixpt_ln2_div_2 = { 1488522236LL };
         |                                ^~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:75:32: warning: 'dc_fixpt_ln2' defined but not used [-Wunused-const-variable=]
      75 | static const struct fixed31_32 dc_fixpt_ln2 = { 2977044471LL };
         |                                ^~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:74:32: warning: 'dc_fixpt_e' defined but not used [-Wunused-const-variable=]
      74 | static const struct fixed31_32 dc_fixpt_e = { 11674931555LL };
         |                                ^~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:73:32: warning: 'dc_fixpt_two_pi' defined but not used [-Wunused-const-variable=]
      73 | static const struct fixed31_32 dc_fixpt_two_pi = { 26986075409LL };
         |                                ^~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:72:32: warning: 'dc_fixpt_pi' defined but not used [-Wunused-const-variable=]
      72 | static const struct fixed31_32 dc_fixpt_pi = { 13493037705LL };
         |                                ^~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:67:32: warning: 'dc_fixpt_zero' defined but not used [-Wunused-const-variable=]
      67 | static const struct fixed31_32 dc_fixpt_zero = { 0 };
         |                                ^~~~~~~~~~~~~

vim +/parse_ta_bin_descriptor +2280 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

  2279	
> 2280	int parse_ta_bin_descriptor(struct psp_context *psp,
  2281				    const struct ta_fw_bin_desc *desc,
  2282				    const struct ta_firmware_header_v2_0 *ta_hdr)
  2283	{
  2284		uint8_t *ucode_start_addr  = NULL;
  2285	
  2286		if (!psp || !desc || !ta_hdr)
  2287			return -EINVAL;
  2288	
  2289		ucode_start_addr  = (uint8_t *)ta_hdr + le32_to_cpu(desc->offset_bytes);
  2290	
  2291		switch (desc->fw_type) {
  2292		case TA_FW_TYPE_PSP_ASD:
  2293			psp->asd_fw_version 	   = le32_to_cpu(desc->fw_version);
  2294			psp->asd_feature_version   = le32_to_cpu(desc->fw_version);
  2295			psp->asd_ucode_size 	   = le32_to_cpu(desc->size_bytes);
  2296			psp->asd_start_addr 	   = ucode_start_addr;
  2297			break;
  2298		case TA_FW_TYPE_PSP_XGMI:
  2299			psp->ta_xgmi_ucode_version = le32_to_cpu(desc->fw_version);
  2300			psp->ta_xgmi_ucode_size    = le32_to_cpu(desc->size_bytes);
  2301			psp->ta_xgmi_start_addr    = ucode_start_addr;
  2302			break;
  2303		case TA_FW_TYPE_PSP_RAS:
  2304			psp->ta_ras_ucode_version  = le32_to_cpu(desc->fw_version);
  2305			psp->ta_ras_ucode_size     = le32_to_cpu(desc->size_bytes);
  2306			psp->ta_ras_start_addr     = ucode_start_addr;
  2307			break;
  2308		case TA_FW_TYPE_PSP_HDCP:
  2309			psp->ta_hdcp_ucode_version = le32_to_cpu(desc->fw_version);
  2310			psp->ta_hdcp_ucode_size    = le32_to_cpu(desc->size_bytes);
  2311			psp->ta_hdcp_start_addr    = ucode_start_addr;
  2312			break;
  2313		case TA_FW_TYPE_PSP_DTM:
  2314			psp->ta_dtm_ucode_version  = le32_to_cpu(desc->fw_version);
  2315			psp->ta_dtm_ucode_size     = le32_to_cpu(desc->size_bytes);
  2316			psp->ta_dtm_start_addr     = ucode_start_addr;
  2317			break;
  2318		default:
  2319			dev_warn(psp->adev->dev, "Unsupported TA type: %d\n", desc->fw_type);
  2320			break;
  2321		}
  2322	
  2323		return 0;
  2324	}
  2325	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60944 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

                 reply	other threads:[~2020-07-08  0:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202007080801.GDGm0BQ4%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Bhawanpreet.Lakha@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=john.clements@amd.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).