From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE9C7C433E0 for ; Wed, 8 Jul 2020 17:20:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB28720672 for ; Wed, 8 Jul 2020 17:20:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB28720672 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5CD686E8FD; Wed, 8 Jul 2020 17:20:43 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 663FB6E8FD for ; Wed, 8 Jul 2020 17:20:42 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 7A99980528; Wed, 8 Jul 2020 19:20:40 +0200 (CEST) Date: Wed, 8 Jul 2020 19:20:39 +0200 From: Sam Ravnborg To: Thomas Zimmermann Subject: Re: [PATCH 3/6] drm/ast: Use managed VRAM-helper initialization Message-ID: <20200708172039.GB121132@ravnborg.org> References: <20200708074912.25422-1-tzimmermann@suse.de> <20200708074912.25422-4-tzimmermann@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200708074912.25422-4-tzimmermann@suse.de> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=WSmEbT3tZrykCLaYO20A:9 a=CjuIK1q_8ugA:10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emil.l.velikov@gmail.com, dri-devel@lists.freedesktop.org, airlied@redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jul 08, 2020 at 09:49:09AM +0200, Thomas Zimmermann wrote: > As a first step to managed MM code in ast, switch over VRAM MM helpers. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/ast/ast_mm.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/ast/ast_mm.c b/drivers/gpu/drm/ast/ast_mm.c > index 9c3788a4c1c5..c0bbcfed9c43 100644 > --- a/drivers/gpu/drm/ast/ast_mm.c > +++ b/drivers/gpu/drm/ast/ast_mm.c > @@ -39,9 +39,8 @@ int ast_mm_init(struct ast_private *ast) > int ret; > struct drm_device *dev = ast->dev; > > - vmm = drm_vram_helper_alloc_mm( > - dev, pci_resource_start(dev->pdev, 0), > - ast->vram_size); > + vmm = drmm_vram_helper_alloc_mm(dev, pci_resource_start(dev->pdev, 0), > + ast->vram_size); > if (IS_ERR(vmm)) { > ret = PTR_ERR(vmm); > drm_err(dev, "Error initializing VRAM MM; %d\n", ret); This would be a little simpler if drmm_vram_helper_alloc_mm() return an int error code as suggested in previous patch. Sam > @@ -60,8 +59,6 @@ void ast_mm_fini(struct ast_private *ast) > { > struct drm_device *dev = ast->dev; > > - drm_vram_helper_release_mm(dev); > - > arch_phys_wc_del(ast->fb_mtrr); > arch_io_free_memtype_wc(pci_resource_start(dev->pdev, 0), > pci_resource_len(dev->pdev, 0)); > -- > 2.27.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel