From: Andrzej Hajda <a.hajda@samsung.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Jonas Karlman <jonas@kwiboo.se>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-kernel@vger.kernel.org,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Neil Armstrong <narmstrong@baylibre.com>,
Andrzej Hajda <a.hajda@samsung.com>,
andy.shevchenko@gmail.com, Mark Brown <broonie@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH v9 0/4] driver core: add probe error check helper
Date: Mon, 13 Jul 2020 16:43:20 +0200 [thread overview]
Message-ID: <20200713144324.23654-1-a.hajda@samsung.com> (raw)
In-Reply-To: CGME20200713144331eucas1p25911c4ffa9315f632d8f6dd833588981@eucas1p2.samsung.com
Hi All,
Thanks for comments.
Changes since v8:
- fixed typo in function name,
- removed cocci script (added by mistake)
Changes since v7:
- improved commit message
- added R-Bs
Changes since v6:
- removed leftovers from old naming scheme in commit descritions,
- added R-Bs.
Changes since v5:
- removed patch adding macro, dev_err_probe(dev, PTR_ERR(ptr), ...) should be used instead,
- added dev_dbg logging in case of -EPROBE_DEFER,
- renamed functions and vars according to comments,
- extended docs,
- cosmetics.
Original message (with small adjustments):
Recently I took some time to re-check error handling in drivers probe code,
and I have noticed that number of incorrect resource acquisition error handling
increased and there are no other propositions which can cure the situation.
So I have decided to resend my old proposition of probe_err helper which should
simplify resource acquisition error handling, it also extend it with adding defer
probe reason to devices_deferred debugfs property, which should improve debugging
experience for developers/testers.
I have also added two patches showing usage and benefits of the helper.
My dirty/ad-hoc cocci scripts shows that this helper can be used in at least 2700 places
saving about 3500 lines of code.
Regards
Andrzej
Andrzej Hajda (4):
driver core: add device probe log helper
driver core: add deferring probe reason to devices_deferred property
drm/bridge/sii8620: fix resource acquisition error handling
drm/bridge: lvds-codec: simplify error handling
drivers/base/base.h | 3 ++
drivers/base/core.c | 46 ++++++++++++++++++++++++++++
drivers/base/dd.c | 23 +++++++++++++-
drivers/gpu/drm/bridge/lvds-codec.c | 10 ++----
drivers/gpu/drm/bridge/sil-sii8620.c | 21 ++++++-------
include/linux/device.h | 3 ++
6 files changed, 86 insertions(+), 20 deletions(-)
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next parent reply other threads:[~2020-07-13 14:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200713144331eucas1p25911c4ffa9315f632d8f6dd833588981@eucas1p2.samsung.com>
2020-07-13 14:43 ` Andrzej Hajda [this message]
[not found] ` <CGME20200713144331eucas1p24107a30783dacc92887b80cf082be9fb@eucas1p2.samsung.com>
2020-07-13 14:43 ` [PATCH v9 1/4] driver core: add device probe log helper Andrzej Hajda
2020-07-13 14:58 ` Andy Shevchenko
[not found] ` <CGME20200713144332eucas1p2f46275f84ec0cca6e23dcf040234005a@eucas1p2.samsung.com>
2020-07-13 14:43 ` [PATCH v9 2/4] driver core: add deferring probe reason to devices_deferred property Andrzej Hajda
[not found] ` <CGME20200713144333eucas1p127c600faa8a7416d89f0d84681c73ab9@eucas1p1.samsung.com>
2020-07-13 14:43 ` [PATCH v9 3/4] drm/bridge/sii8620: fix resource acquisition error handling Andrzej Hajda
[not found] ` <CGME20200713144333eucas1p1f393b280cda5eead4e7ca0a005c8a4db@eucas1p1.samsung.com>
2020-07-13 14:43 ` [PATCH v9 4/4] drm/bridge: lvds-codec: simplify " Andrzej Hajda
2020-07-28 15:05 ` [PATCH v9 0/4] driver core: add probe error check helper Andrzej Hajda
2020-07-30 7:08 ` Greg Kroah-Hartman
2020-07-30 16:18 ` Dmitry Torokhov
2020-07-30 16:48 ` Mark Brown
2020-07-30 17:46 ` Dmitry Torokhov
2020-07-30 18:16 ` Mark Brown
2020-07-30 18:45 ` Dmitry Torokhov
2020-07-30 19:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713144324.23654-1-a.hajda@samsung.com \
--to=a.hajda@samsung.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=narmstrong@baylibre.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).