From: Maxime Ripard <maxime@cerno.tech>
To: Chen-Yu Tsai <wens@kernel.org>
Cc: devicetree@vger.kernel.org,
Siarhei Siamashka <siarhei.siamashka@gmail.com>,
David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org, Sam Ravnborg <sam@ravnborg.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] dt-bindings: display: panel-dpi: Add bits-per-color property
Date: Thu, 16 Jul 2020 10:00:43 +0200 [thread overview]
Message-ID: <20200716080043.6duzgo2ikeqr5lnw@gilmour.lan> (raw)
In-Reply-To: <20200714071305.18492-2-wens@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 1423 bytes --]
On Tue, Jul 14, 2020 at 03:13:01PM +0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@csie.org>
>
> Some LCD panels do not support 24-bit true color, or 8bits per channel
> RGB. Many low end ones only support up to 6 bits per channel natively.
>
> Add a device tree property to describe the native bit depth of the
> panel. This is separate from the bus width or format of the connection
> to the display output.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> .../devicetree/bindings/display/panel/panel-dpi.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
> index 0cd74c8dab42..8eb013fb1969 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
> @@ -26,6 +26,9 @@ properties:
> height-mm: true
> label: true
> panel-timing: true
> + bits-per-color:
> + description:
> + Shall contain an integer describing the number of bits per color.
You should specify its type (u32), range (1-8 I guess?) and default
value (which seems to be 8).
Also, it's not unusual to have a different number of bits per color,
like for 16 bits panels where we usually use RGB565. I guess we could
make that an array?
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-17 7:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 7:13 [PATCH 0/5] ARM: sunxi: Add support for MSI Primo73 tablet Chen-Yu Tsai
2020-07-14 7:13 ` [PATCH 1/5] dt-bindings: display: panel-dpi: Add bits-per-color property Chen-Yu Tsai
2020-07-16 8:00 ` Maxime Ripard [this message]
2020-07-16 8:05 ` Chen-Yu Tsai
2020-07-21 2:10 ` Rob Herring
2020-07-21 9:23 ` Maxime Ripard
2020-07-21 9:40 ` Chen-Yu Tsai
2020-07-21 13:58 ` Rob Herring
2020-07-14 7:13 ` [PATCH 2/5] drm/panel: simple: Set bpc from bits-per-color DT property for panel-dpi Chen-Yu Tsai
2020-07-14 7:13 ` [PATCH 3/5] dt-bindings: arm: sunxi: Add compatible for MSI Primo73 tablet Chen-Yu Tsai
2020-07-21 2:10 ` Rob Herring
2020-07-14 7:13 ` [PATCH 4/5] ARM: dts: sun7i: Add LCD0 RGB888 pins Chen-Yu Tsai
2020-07-14 7:13 ` [PATCH 5/5] ARM: dts: sun7i: Add MSI Primo73 tablet Chen-Yu Tsai
2020-07-16 8:04 ` Maxime Ripard
2020-07-16 8:09 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716080043.6duzgo2ikeqr5lnw@gilmour.lan \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=siarhei.siamashka@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).