From: "Guido Günther" <agx@sigxcpu.org>
To: Ondrej Jirman <megous@megous.com>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Robert Chiras <robert.chiras@nxp.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml
Date: Sat, 18 Jul 2020 18:52:16 +0200 [thread overview]
Message-ID: <20200718165215.GA26122@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <20200703114717.2140832-2-megous@megous.com>
Hi,
On Fri, Jul 03, 2020 at 01:47:16PM +0200, Ondrej Jirman wrote:
> The example is now validated against rocktech,jh057n00900 schema
> that was ported to yaml, and didn't validate with:
>
> - '#address-cells', '#size-cells', 'port@0' do not match any of
> the regexes: 'pinctrl-[0-9]+'
> - 'vcc-supply' is a required property
> - 'iovcc-supply' is a required property
> - 'reset-gpios' is a required property
>
> Fix it.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
> .../devicetree/bindings/display/bridge/nwl-dsi.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> index 8aff2d68fc33..2c4c34e3bc29 100644
> --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> @@ -165,6 +165,7 @@ examples:
> - |
>
> #include <dt-bindings/clock/imx8mq-clock.h>
> + #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/reset/imx8mq-reset.h>
>
> @@ -191,12 +192,12 @@ examples:
> phy-names = "dphy";
>
> panel@0 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> compatible = "rocktech,jh057n00900";
> reg = <0>;
> - port@0 {
> - reg = <0>;
> + vcc-supply = <®_2v8_p>;
> + iovcc-supply = <®_1v8_p>;
> + reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
> + port {
> panel_in: endpoint {
> remote-endpoint = <&mipi_dsi_out>;
> };
Reviewed-by: Guido Günther <agx@sigxcpu.org>
-- Guido
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-18 16:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 11:47 [PATCH 0/2] Fix warnings in display/bridge/nwl-dsi.yaml DT example Ondrej Jirman
2020-07-03 11:47 ` [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml Ondrej Jirman
2020-07-15 21:07 ` Rob Herring
2020-07-18 16:52 ` Guido Günther [this message]
2020-07-03 11:47 ` [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech, jh057n00900 Ondrej Jirman
2020-07-15 21:08 ` Rob Herring
2020-07-18 16:53 ` [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech,jh057n00900 Guido Günther
2020-07-21 15:35 ` [PATCH 0/2] Fix warnings in display/bridge/nwl-dsi.yaml DT example Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200718165215.GA26122@bogon.m.sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=megous@megous.com \
--cc=robert.chiras@nxp.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).