From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CAFFC433E3 for ; Mon, 20 Jul 2020 08:48:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D255E2176B for ; Mon, 20 Jul 2020 08:48:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GPZr4Rzz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D255E2176B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4012289DBF; Mon, 20 Jul 2020 08:48:32 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 00A9689DBF for ; Mon, 20 Jul 2020 08:48:30 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id w3so24296717wmi.4 for ; Mon, 20 Jul 2020 01:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3Mvv6V7aL0bS8bLhb+v9J48PYxr/jDUQbWZDKJ3of4k=; b=GPZr4RzzAiGFrXA4Lc2u8SHFw4nz+8LttAOAp071b1HN8JGHbq8hJeNnFyFnZfQNpI wfvmIupf6FmdZMHcWDZ0RGgfmR6/UkXw1Ry9fxlPWa55mXeOllJIylslp/fcTX1P5tpX X4PGv9AY4r+UTZ4ZUwjPhWtlHUj2YMSTGaYw/KHK8TwLdyFW4hiMT8Iz731WhgUcs+Rb yoVZvTLCdpKiKVYTxaGVMCUqMrf8WZjC1zVmAwKexn5OhhWEN+kFygPDdy0g1OcaX5tg Tdc2WARpJx4H5rlw2EUN8LdK4kBj/RkauWc0R3XCvaYw6Oo12LBLFN0aPNKxOJUEsnJ7 RQGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3Mvv6V7aL0bS8bLhb+v9J48PYxr/jDUQbWZDKJ3of4k=; b=FKAqgzni5huF7fC1h1ZU7bb2q/5njwI9gUi5U46u5bLgaKuU/PhsoEdFj3Y/7QnGMa cL8q9MU+3GwG7Nrga2Zp5XKtuT+9lAf+xKOreyG40tnnCi7hulw+QjqhsbJqdk2SaZMA VO2nP3mO5oG/7FATj92T0vToCqJysT48N+Tcp6WLommeEbSp/oYofLUcZwkNBzqGo6GU c44ORC4eqslrqlujASV5KJQbCtJqpwNz+Jw9ce9+XNS1lR3NXSWCeC+bxa9jZFBY6FpO MOZ0QxnGAWo4Xv4QCVVXG37dh8MWR0WqxkxDaAOm9sd2L40tNG3k2BlUSIXX3okMiWA4 S+xQ== X-Gm-Message-State: AOAM530amHdiwCLtFuNYSdXc/550aJ1a2/2wkRlcXnrQFZO5ZNd3JfgU AuRNcbyfhlGJ7n3+kjoRxxloDw== X-Google-Smtp-Source: ABdhPJzE0VX+v4xxb0yfbr3uIHhTnBrDiWh9q2HaxcqnvtD/UybPjPxZBEj8tuo6izQM73ENIq/qcA== X-Received: by 2002:a1c:a74c:: with SMTP id q73mr19955891wme.96.1595234909650; Mon, 20 Jul 2020 01:48:29 -0700 (PDT) Received: from holly.lan (82-132-214-103.dab.02.net. [82.132.214.103]) by smtp.gmail.com with ESMTPSA id l15sm30561453wro.33.2020.07.20.01.48.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 01:48:28 -0700 (PDT) Date: Mon, 20 Jul 2020 09:48:22 +0100 From: Daniel Thompson To: Sam Ravnborg Subject: Re: [PATCH v5 14/19] backlight: cr_bllcd: introduce gpio-backlight semantics Message-ID: <20200720084822.wt5guzetkrgbgdcc@holly.lan> References: <20200719080743.8560-1-sam@ravnborg.org> <20200719080743.8560-15-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200719080743.8560-15-sam@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Bjorn Andersson , Peter Ujfalusi , Thierry Reding , Lee Jones , Jonathan Corbet , Tomi Valkeinen , Uwe Kleine-Konig , linux-pwm@vger.kernel.org, Michael Hennerich , Bartlomiej Zolnierkiewicz , linux-arm-msm@vger.kernel.org, Support Opensource , Jingoo Han , Emil Velikov , Andy Gross , Thomas Zimmermann , patches@opensource.cirrus.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Jul 19, 2020 at 10:07:38AM +0200, Sam Ravnborg wrote: > cr_bllcd can turn backlight ON or OFF. > Fix semantitics so they equals what we know from gpio-backlight. > brightness == 0 => backlight off > brightness == 1 => backlight on > > Use the backlight_get_brightness() helper to simplify the code. > > v2: > - reworked to introduce gpio-backlight semantics (Daniel) Wasn't this added for v5? However, I spotted this change amoung the other patches so no worries... > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han Reviewed-by: Daniel Thompson Daniel. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel