From: Manasi Navare <manasi.d.navare@intel.com>
To: Khaled Almahallawy <khaled.almahallawy@intel.com>
Cc: intel-gfx@lists.freedesktop.org, animesh.manna@intel.com,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/dp: Add PHY_TEST_PATTERN CP2520 Pattern 2 and 3
Date: Mon, 20 Jul 2020 17:07:35 -0700 [thread overview]
Message-ID: <20200721000734.GA14395@intel.com> (raw)
In-Reply-To: <20200720234126.11853-1-khaled.almahallawy@intel.com>
On Mon, Jul 20, 2020 at 04:41:25PM -0700, Khaled Almahallawy wrote:
> Add the missing CP2520 pattern 2 and 3 phy compliance patterns
>
> Signed-off-by: Khaled Almahallawy <khaled.almahallawy@intel.com>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 2 +-
> include/drm/drm_dp_helper.h | 4 +++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index a3c82e726057..d0fb78c6aca6 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1583,7 +1583,7 @@ int drm_dp_get_phy_test_pattern(struct drm_dp_aux *aux,
> return err;
>
> break;
> - case DP_PHY_TEST_PATTERN_CP2520:
> + case DP_PHY_TEST_PATTERN_CP2520_PAT1:
> err = drm_dp_dpcd_read(aux, DP_TEST_HBR2_SCRAMBLER_RESET,
> &data->hbr2_reset,
> sizeof(data->hbr2_reset));
Where do we read PAT2 and PAT3, I see you defined those newly and patch 2/2 has them
in teh switch case but the drm_dp_get_phy_test_pattern function doesnt read them?
Manasi
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index e47dc22ebf50..65dd6cd71f1e 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -708,7 +708,9 @@
> # define DP_PHY_TEST_PATTERN_ERROR_COUNT 0x2
> # define DP_PHY_TEST_PATTERN_PRBS7 0x3
> # define DP_PHY_TEST_PATTERN_80BIT_CUSTOM 0x4
> -# define DP_PHY_TEST_PATTERN_CP2520 0x5
> +# define DP_PHY_TEST_PATTERN_CP2520_PAT1 0x5
> +# define DP_PHY_TEST_PATTERN_CP2520_PAT2 0x6
> +# define DP_PHY_TEST_PATTERN_CP2520_PAT3 0x7
>
> #define DP_TEST_HBR2_SCRAMBLER_RESET 0x24A
> #define DP_TEST_80BIT_CUSTOM_PATTERN_7_0 0x250
> --
> 2.17.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-21 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 23:41 [PATCH 1/2] drm/dp: Add PHY_TEST_PATTERN CP2520 Pattern 2 and 3 Khaled Almahallawy
2020-07-20 23:41 ` [PATCH 2/2] drm/i915/dp: TPS4 PHY test pattern compliance support Khaled Almahallawy
2020-07-21 0:11 ` Manasi Navare
2020-07-21 0:20 ` Almahallawy, Khaled
2020-07-21 0:07 ` Manasi Navare [this message]
2020-07-21 0:40 ` [PATCH 1/2] drm/dp: Add PHY_TEST_PATTERN CP2520 Pattern 2 and 3 Almahallawy, Khaled
2020-07-21 18:56 ` Manasi Navare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721000734.GA14395@intel.com \
--to=manasi.d.navare@intel.com \
--cc=animesh.manna@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=khaled.almahallawy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).