From: Rob Herring <robh@kernel.org>
To: Sumit Semwal <sumit.semwal@linaro.org>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel
Date: Mon, 20 Jul 2020 21:33:28 -0600 [thread overview]
Message-ID: <20200721033328.GA3492972@bogus> (raw)
In-Reply-To: <20200716153858.526-2-sumit.semwal@linaro.org>
On Thu, Jul 16, 2020 at 09:08:57PM +0530, Sumit Semwal wrote:
> The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246
> and 6.18 inches size. It is found in some of the Poco F1 phones.
>
> Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
> ---
> .../display/panel/tianma,nt36672a.yaml | 110 ++++++++++++++++++
> 1 file changed, 110 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml
> new file mode 100644
> index 000000000000..3c583ca926ee
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml
> @@ -0,0 +1,110 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/tianma,nt36672a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Tianma model NT36672A DSI Panel display driver
> +
> +maintainers:
> + - Sumit Semwal <sumit.semwal@linaro.org>
> +
> +description: |
> + The nt36672a panel from Tianma is a FHD+ LCD display panel with a resolution
> + of 1080x2246. It is a video mode DSI panel.
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: tianma,nt36672a
> +
> + reg:
> + description: DSI virtual channel of the peripheral
> +
> + reset-gpios:
> + description: phandle of gpio for reset line - This should be 8mA, gpio
> + can be configured using mux, pinctrl, pinctrl-names (active high)
> +
> + vddio-supply:
> + description: phandle of the regulator that provides the supply voltage
> + Power IC supply
> +
> + vddpos-supply:
> + description: phandle of the positive boost supply regulator
> +
> + vddneg-supply:
> + description: phandle of the negative boost supply regulator
> +
> + pinctrl-names:
> + description: Pinctrl for panel active and suspend
> +
> + pinctrl-0:
> + description: Active pinctrls
> +
> + pinctrl-1:
> + description: Suspend pinctrls
I think the pinctrl should go in the DSI controller node, not the
display unless it is settings for 'reset-gpios'.
> +
> + ports:
> + type: object
> + properties:
> + port@0:
> + type: object
> + description: DSI input port driven by master DSI
> + properties:
> + reg:
> + const: 0
> +
> + required:
> + - reg
For a single port, you can do just 'port' (without ports node).
> +
> +required:
> + - compatible
> + - reg
> + - vddi0-supply
> + - vddpos-supply
> + - vddneg-supply
> + - reset-gpios
> + - pinctrl-names
> + - pinctrl-0
> + - pinctrl-1
> + - ports
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |+
> + #include <dt-bindings/gpio/gpio.h>
> + dsi0 {
dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + panel@0 {
> + compatible = "tianma,nt36672a";
> + reg = <0>;
> + vddi0-supply = <&vreg_l14a_1p88>;
> + vddpos-supply = <&lab>;
> + vddneg-supply = <&ibb>;
> +
> + reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
> +
> + pinctrl-names = "panel_active", "panel_suspend";
> + pinctrl-0 = <&sde_dsi_active>;
> + pinctrl-1 = <&sde_dsi_suspend>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + tianma_nt36672a_in_0: endpoint {
> + remote-endpoint = <&dsi0_out>;
> + };
> + };
> + };
> + };
> + };
> +
> +...
> --
> 2.27.0
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-21 3:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 15:38 [PATCH 0/2] Add support for Tianma nt36672a video mode panel Sumit Semwal
2020-07-16 15:38 ` [PATCH 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel Sumit Semwal
2020-07-21 3:33 ` Rob Herring [this message]
2020-07-21 12:16 ` Sumit Semwal
2020-07-16 15:38 ` [PATCH 2/2] drm: panel: Add tianma nt36672a panel driver Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721033328.GA3492972@bogus \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=sam@ravnborg.org \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).