From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 092D2C433E0 for ; Thu, 30 Jul 2020 06:52:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7CF420656 for ; Thu, 30 Jul 2020 06:52:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7CF420656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 094FD6E860; Thu, 30 Jul 2020 06:52:05 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 765BA6E860; Thu, 30 Jul 2020 06:52:03 +0000 (UTC) IronPort-SDR: SOQhpEhqE08K8gBvoGYCYZ3FG1er4800WWG4tXZkGlj1DKPApW5QsZ6GpXxXGGEgzK/o0eJ6rW iBAY9rmTH9Cw== X-IronPort-AV: E=McAfee;i="6000,8403,9697"; a="152776387" X-IronPort-AV: E=Sophos;i="5.75,413,1589266800"; d="scan'208";a="152776387" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2020 23:52:02 -0700 IronPort-SDR: 2zghKGF/AZVMS8LEGACb/O+AyJrUiWq0fMuhlSGd/5xMVnJHle45MBG1NAhn8uN6s79I/jCM+S 7nCe/DF3bR1g== X-IronPort-AV: E=Sophos;i="5.75,413,1589266800"; d="scan'208";a="330650977" Received: from unknown (HELO intel.com) ([10.223.74.178]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2020 23:51:58 -0700 Date: Thu, 30 Jul 2020 12:09:53 +0530 From: Anshuman Gupta To: Sean Paul Subject: Re: [Intel-gfx] [PATCH] drm/i915: Avoid modeset when content protection changes Message-ID: <20200730063650.GA25561@intel.com> References: <20200714160627.1269-1-sean@poorly.run> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200714160627.1269-1-sean@poorly.run> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , "intel-gfx@lists.freedesktop.org" , Sean Paul , "dri-devel@lists.freedesktop.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020-07-14 at 21:36:27 +0530, Sean Paul wrote: > From: Sean Paul > > Instead of doing a full modeset to enable/disable content protection, > simply go through the update_pipe flow which was introduced in the > related patch below. This avoids flashing the screen every time the user > starts viewing protected content. > > Related: 634852d1f468 ("drm/i915: HDCP state handling in ddi_update_pipe") > Cc: Ramalingam C > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: intel-gfx@lists.freedesktop.org > Signed-off-by: Sean Paul > --- > drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c > index 89a4d294822d..839ce1715253 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdcp.c > +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c > @@ -2191,7 +2191,7 @@ void intel_hdcp_atomic_check(struct drm_connector *connector, > return; > } > > - crtc_state->mode_changed = true; > + to_intel_crtc_state(crtc_state)->update_pipe = true; IMHO intel_crtc_check_fastset() make sure that every crtc_state->mode_changed will not turn up to a modeset. It seems it is already being taken care. Thanks, Anshuman Gupta. > } > > /* Handles the CP_IRQ raised from the DP HDCP sink */ > -- > Sean Paul, Software Engineer, Google / Chromium OS > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel