From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2EE6C433E0 for ; Sat, 1 Aug 2020 19:20:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49C1C206D4 for ; Sat, 1 Aug 2020 19:20:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="X/yADJH6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49C1C206D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 372346EC03; Sat, 1 Aug 2020 19:20:01 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A87F6EC03 for ; Sat, 1 Aug 2020 19:20:00 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id x5so11094498wmi.2 for ; Sat, 01 Aug 2020 12:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=DwMdwJNuGqH14xSny5IewSTmQ+L5ClGvkT7BqQpshcI=; b=X/yADJH6W+WcpFPMt8nhBPO5k50T82DtANbGRgYBxap/xl/05WQ670GoNPT1RLkTqa bfHsHFkdAOW5LRxV0IbIlh4jaME6xFz2cVzq0Ip53nRJNJ2FZLe8rIA+cBCSnDM2jDCE IP0h59fWtCvxbDH4fBfZNyDcCghBX4BdHtDfo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=DwMdwJNuGqH14xSny5IewSTmQ+L5ClGvkT7BqQpshcI=; b=mbhI8P/g6IL4IRPqfd7DR/g+9wd+4YY5/j6q3VX+xk4P+9qYVxGO30uixA6i6sDatu +eMwuu1wjKefzx70wvPYtLJREgPM5AW8jIaFNao54CKPnZtsvcla64kJkmdbT4nvTeNo nyuFxoV48g9BFRYnP5cxd3iRf1JRD2HWQFKvfhYtXuKL2phyQrlIrD2AUkbD3pNT9gKE crLtv5FjpVpFEIHLEqEQ1csFgE0zFVgTw8WTD/ThRwx029nFe5+ThPO5w9KseXnG7SSA RjRJcK7YBburRUNU66sNF5o0B5ls7loaAUjbSHJ2NV44VCYAE9MXImPxfj9DP+xwz1Nn KYfg== X-Gm-Message-State: AOAM533p73KimE241ChaylmTFeVeLLxk1/h4MjAOwYIGthZiQWxEivEb Jfk+zyzFjQip933NeTMWvoVCBg== X-Google-Smtp-Source: ABdhPJyhxRzXh0oseHu84RlWufogYVVVy7gM4c5UxeL8tyk8UN+QerG6L/YkiLk2wcp9dCwQ0AfOsA== X-Received: by 2002:a1c:bc54:: with SMTP id m81mr8916052wmf.60.1596309598862; Sat, 01 Aug 2020 12:19:58 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j145sm3775140wmj.12.2020.08.01.12.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2020 12:19:58 -0700 (PDT) Date: Sat, 1 Aug 2020 21:19:56 +0200 From: daniel@ffwll.ch To: Subject: Re: [PATCH] drm/syncobj: Tune down unordered timeline DRM_ERROR Message-ID: <20200801191956.GF6419@phenom.ffwll.local> References: <20200801092625.1107609-1-daniel.vetter@ffwll.ch> <6c320fd4-81d4-1a96-e83e-ecbdedfbd7f8@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6c320fd4-81d4-1a96-e83e-ecbdedfbd7f8@intel.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Chris Wilson , Christian =?iso-8859-1?Q?K=F6nig?= , DRI Development , Daniel Vetter Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Aug 01, 2020 at 05:39:50PM +0300, Lionel Landwerlin wrote: > On 01/08/2020 12:26, Daniel Vetter wrote: > > Userspace can provoke this, we generally don't allow userspace to spam > > dmesg. Tune it down to debug. Unfortunately we don't have easy access > > to the drm_device here (not at all without changing a few things), so > > leave it as old style dmesg output for now. > > = > > References: https://patchwork.freedesktop.org/series/80146/ > > Signed-off-by: Daniel Vetter > > Cc: Chris Wilson > > Cc: Lionel Landwerlin > > Cc: "Christian K=F6nig" > > --- > > drivers/gpu/drm/drm_syncobj.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > = > > diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncob= j.c > > index 3bf73971daf3..6e74e6745eca 100644 > > --- a/drivers/gpu/drm/drm_syncobj.c > > +++ b/drivers/gpu/drm/drm_syncobj.c > > @@ -297,7 +297,7 @@ void drm_syncobj_add_point(struct drm_syncobj *sync= obj, > > prev =3D drm_syncobj_fence_get(syncobj); > > /* You are adding an unorder point to timeline, which could cause pa= yload returned from query_ioctl is 0! */ > > if (prev && prev->seqno >=3D point) > > - DRM_ERROR("You are adding an unorder point to timeline!\n"); > > + DRM_DEBUG("You are adding an unorder point to timeline!\n"); > > dma_fence_chain_init(chain, prev, fence, point); > > rcu_assign_pointer(syncobj->fence, &chain->base); > = > Thanks, > = > Acked-by: Lionel Landwerlin Thanks for taking a look, applied it now. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel