From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2502C433E3 for ; Sun, 2 Aug 2020 14:26:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3CF920759 for ; Sun, 2 Aug 2020 14:26:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="HSa73/X/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3CF920759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1751189D8A; Sun, 2 Aug 2020 14:26:09 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 098A389D8A for ; Sun, 2 Aug 2020 14:26:08 +0000 (UTC) Received: from earth.universe (dyndsl-037-138-184-041.ewe-ip-backbone.de [37.138.184.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A368F208C7; Sun, 2 Aug 2020 14:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596378367; bh=O1iXKRu7K0G1r3XxmedkO3b/Xi/37eJcuiLIvxIzx9c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HSa73/X/c5sxVfPtWcpkPTfmVMkyn423TdLypzcyX2+Gh2c0VI0S0ZWuqKNJG+JhU rclBSt15x0guFVu9Rul9OVdieiNglIjneuJLfjcyPezLKQDdzNl5qVNyQQ1o0XsdDl lv+bDfUxxyjX83ZFdJg9htGLerxLD54kTR2DueOc= Received: by earth.universe (Postfix, from userid 1000) id 8E1F63C0B87; Sun, 2 Aug 2020 16:26:05 +0200 (CEST) Date: Sun, 2 Aug 2020 16:26:05 +0200 From: Sebastian Reichel To: Sam Ravnborg Subject: Re: [PATCH v1 21/22] drm/omap: display: Backlight update Message-ID: <20200802142605.ih6hwhnjxnqhaflt@earth.universe> References: <20200802110636.1018743-1-sam@ravnborg.org> <20200802110636.1018743-22-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200802110636.1018743-22-sam@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , Jingoo Han , dri-devel@lists.freedesktop.org, Zheng Bin , Tomi Valkeinen , Laurent Pinchart , Daniel Vetter , Lee Jones Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Sun, Aug 02, 2020 at 01:06:35PM +0200, Sam Ravnborg wrote: > - Introduce backlight_{enable/disable) > - Use get/set methods for backlight_properties > - Drop redundant get_brightness() implementation > The default implementation return the current brightness value > - Use macro for backlight initialization > > Signed-off-by: Sam Ravnborg > Cc: Tomi Valkeinen > Cc: Sebastian Reichel > Cc: Laurent Pinchart > Cc: Zheng Bin > Cc: Sam Ravnborg > --- > .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 35 ++++--------------- > 1 file changed, 6 insertions(+), 29 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > index 3484b5d4a91c..433e240896b3 100644 > --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > @@ -110,15 +110,10 @@ static void dsicm_bl_power(struct panel_drv_data *ddata, bool enable) > else > return; > > - if (enable) { > - backlight->props.fb_blank = FB_BLANK_UNBLANK; > - backlight->props.state = ~(BL_CORE_FBBLANK | BL_CORE_SUSPENDED); > - backlight->props.power = FB_BLANK_UNBLANK; > - } else { > - backlight->props.fb_blank = FB_BLANK_NORMAL; > - backlight->props.power = FB_BLANK_POWERDOWN; > - backlight->props.state |= BL_CORE_FBBLANK | BL_CORE_SUSPENDED; > - } > + if (enable) > + backlight_enable(backlight); > + else > + backlight_disable(backlight); > > backlight_update_status(backlight); backlight_update_status() is already called by backlight_enable/disable. -- Sebastian _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel