From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 319D4C433DF for ; Sun, 2 Aug 2020 14:32:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DDD020759 for ; Sun, 2 Aug 2020 14:32:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DDD020759 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A01A6E05A; Sun, 2 Aug 2020 14:32:15 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 69AA56E05A for ; Sun, 2 Aug 2020 14:32:13 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 80CAF80511; Sun, 2 Aug 2020 16:32:08 +0200 (CEST) Date: Sun, 2 Aug 2020 16:32:07 +0200 From: Sam Ravnborg To: Sebastian Reichel Subject: Re: [PATCH v1 21/22] drm/omap: display: Backlight update Message-ID: <20200802143207.GA1175585@ravnborg.org> References: <20200802110636.1018743-1-sam@ravnborg.org> <20200802110636.1018743-22-sam@ravnborg.org> <20200802142605.ih6hwhnjxnqhaflt@earth.universe> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200802142605.ih6hwhnjxnqhaflt@earth.universe> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=sozttTNsAAAA:8 a=QX4gbG5DAAAA:8 a=P1BnusSwAAAA:8 a=i0EeH86SAAAA:8 a=Mi-SBBojSEErp3IxY9cA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=aeg5Gbbo78KNqacMgKqU:22 a=AbAUZ8qAyYyZVLSsDulk:22 a=D0XLA9XvdZm18NrgonBM:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , Jingoo Han , dri-devel@lists.freedesktop.org, Zheng Bin , Tomi Valkeinen , Laurent Pinchart , Daniel Vetter , Lee Jones Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sebastian. On Sun, Aug 02, 2020 at 04:26:05PM +0200, Sebastian Reichel wrote: > Hi, > > On Sun, Aug 02, 2020 at 01:06:35PM +0200, Sam Ravnborg wrote: > > - Introduce backlight_{enable/disable) > > - Use get/set methods for backlight_properties > > - Drop redundant get_brightness() implementation > > The default implementation return the current brightness value > > - Use macro for backlight initialization > > > > Signed-off-by: Sam Ravnborg > > Cc: Tomi Valkeinen > > Cc: Sebastian Reichel > > Cc: Laurent Pinchart > > Cc: Zheng Bin > > Cc: Sam Ravnborg > > --- > > .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 35 ++++--------------- > > 1 file changed, 6 insertions(+), 29 deletions(-) > > > > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > > index 3484b5d4a91c..433e240896b3 100644 > > --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > > +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > > @@ -110,15 +110,10 @@ static void dsicm_bl_power(struct panel_drv_data *ddata, bool enable) > > else > > return; > > > > - if (enable) { > > - backlight->props.fb_blank = FB_BLANK_UNBLANK; > > - backlight->props.state = ~(BL_CORE_FBBLANK | BL_CORE_SUSPENDED); > > - backlight->props.power = FB_BLANK_UNBLANK; > > - } else { > > - backlight->props.fb_blank = FB_BLANK_NORMAL; > > - backlight->props.power = FB_BLANK_POWERDOWN; > > - backlight->props.state |= BL_CORE_FBBLANK | BL_CORE_SUSPENDED; > > - } > > + if (enable) > > + backlight_enable(backlight); > > + else > > + backlight_disable(backlight); > > > > backlight_update_status(backlight); > > backlight_update_status() is already called by backlight_enable/disable. Right, thanks. Dropped in v2. Let me know if you already have a similar patch and if I shall drop this. It would be nice to have the panel parts of omapdrm migrated in this cycle. I recall you have 50+ patches pending. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel