From: Frank Wunderlich <linux@fw-web.de> To: linux-mediatek@lists.infradead.org Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>, Jitao Shi <jitao.shi@mediatek.com>, Frank Wunderlich <frank-w@public-files.de>, David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Matthias Brugger <matthias.bgg@gmail.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 5/6] drm/mediatek: dpi/dsi: change the getting possible_crtc way Date: Tue, 4 Aug 2020 18:55:54 +0200 Message-ID: <20200804165555.75159-7-linux@fw-web.de> (raw) In-Reply-To: <20200804165555.75159-1-linux@fw-web.de> From: Jitao Shi <jitao.shi@mediatek.com> For current mediatek dsi encoder, its possible crtc is fixed in crtc 0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In some SoC the possible crtc is not fixed in this case, so call mtk_drm_find_possible_crtc_by_comp() to find out the correct possible crtc. Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> Signed-off-by: Frank Wunderlich <frank-w@public-files.de> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> --- drivers/gpu/drm/mediatek/mtk_dpi.c | 3 ++- drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index d4f0fb7ad312..e43977015843 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -608,7 +608,8 @@ static int mtk_dpi_bind(struct device *dev, struct device *master, void *data) drm_encoder_helper_add(&dpi->encoder, &mtk_dpi_encoder_helper_funcs); /* Currently DPI0 is fixed to be driven by OVL1 */ - dpi->encoder.possible_crtcs = BIT(1); + dpi->encoder.possible_crtcs = + mtk_drm_find_possible_crtc_by_comp(drm_dev, dpi->ddp_comp); ret = drm_bridge_attach(&dpi->encoder, dpi->bridge, NULL, 0); if (ret) { diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 270bf22c98fe..c31d9c12d4a9 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -892,7 +892,8 @@ static int mtk_dsi_create_conn_enc(struct drm_device *drm, struct mtk_dsi *dsi) * Currently display data paths are statically assigned to a crtc each. * crtc 0 is OVL0 -> COLOR0 -> AAL -> OD -> RDMA0 -> UFOE -> DSI0 */ - dsi->encoder.possible_crtcs = 1; + dsi->encoder.possible_crtcs = + mtk_drm_find_possible_crtc_by_comp(drm, dsi->ddp_comp); /* If there's a bridge, attach to it and let it create the connector */ if (dsi->bridge) { -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply index Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-04 16:55 [PATCH v4 0/6] make hdmi work on bananapi-r2 Frank Wunderlich 2020-08-04 16:55 ` [PATCH v4 1/6] dt-bindings: mediatek: add mt7623 display-nodes Frank Wunderlich 2020-08-04 17:18 ` Aw: " Frank Wunderlich 2020-08-04 17:22 ` Rob Herring 2020-08-04 23:27 ` Chun-Kuang Hu 2020-08-04 16:55 ` [PATCH v4] net: ethernet: mtk_eth_soc: fix MTU warnings Frank Wunderlich 2020-08-04 17:20 ` Aw: " Frank Wunderlich 2020-08-04 16:55 ` [PATCH v4 2/6] drm/mediatek: add ddp routing for mt7623 Frank Wunderlich 2020-08-04 23:01 ` Chun-Kuang Hu 2020-08-04 16:55 ` [PATCH v4 3/6] drm/mediatek: disable tmds on mt2701 Frank Wunderlich 2020-08-04 16:55 ` [PATCH v4 4/6] drm/mediatek: Add get_possible_crtc API for dpi, dsi Frank Wunderlich 2020-08-04 16:55 ` Frank Wunderlich [this message] 2020-08-04 16:55 ` [PATCH v4 6/6] arm: dts: mt7623: add display subsystem related device nodes Frank Wunderlich 2020-08-04 17:24 ` David Woodhouse 2020-08-04 17:40 ` Aw: " Frank Wunderlich 2020-08-04 18:02 ` David Woodhouse 2020-08-05 7:27 ` Aw: " Frank Wunderlich 2020-08-05 8:36 ` David Woodhouse 2020-08-05 8:49 ` Aw: " Frank Wunderlich 2020-08-05 11:27 ` David Woodhouse 2020-08-05 11:30 ` [PATCH 1/3] arm: dts: remove stray /dts-v1/ from mt7623a.dtsi David Woodhouse 2020-08-05 11:30 ` [PATCH 2/3] arm: dts: mt7623: move MT7623N GPU to separate mt7623n.dtsi file David Woodhouse 2020-08-05 13:01 ` Aw: " Frank Wunderlich 2020-08-05 11:30 ` [PATCH 3/3] arm: dts: mt7623: add support for UniElec U7623 eMMC David Woodhouse
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200804165555.75159-7-linux@fw-web.de \ --to=linux@fw-web.de \ --cc=airlied@linux.ie \ --cc=chunkuang.hu@kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=frank-w@public-files.de \ --cc=jitao.shi@mediatek.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
dri-devel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dri-devel/0 dri-devel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dri-devel dri-devel/ https://lore.kernel.org/dri-devel \ dri-devel@lists.freedesktop.org public-inbox-index dri-devel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.freedesktop.lists.dri-devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git