From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1012CC433E0 for ; Tue, 4 Aug 2020 17:04:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E22E7207FC for ; Tue, 4 Aug 2020 17:04:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="lg5GIsim" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E22E7207FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D6596E25B; Tue, 4 Aug 2020 17:04:16 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 262146E25B for ; Tue, 4 Aug 2020 17:04:15 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id f1so37554887wro.2 for ; Tue, 04 Aug 2020 10:04:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SJmkw0nSLw4m3B98dhc6CnT8NG6TGxfacruv3nV7TWU=; b=lg5GIsimCkxV7EjRYy8NYITfC9QhMBu3RqWboYBTGvhFuEImNVBwDL+dV4HsekGAuU auGMXxfRHXJBILOHQHfN8LY6Mrr8PJlm4CVMfyxFVMSSGANeI0uKnLOEPxOAnAKHhsgu bnIvvx6n6m2aWIaVLQyhagT+fJ2D858sHuyr0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SJmkw0nSLw4m3B98dhc6CnT8NG6TGxfacruv3nV7TWU=; b=merhOY/Xbx0F9T/h03h86VmjAtGh6azF9KDCGofpmNepZYs4ODdI1Z0mCpBEqxwBCS saA/2NF5qb/7IzuRpV1UWVQ+bLfwLedcG0doMFIG2Sr3nzgK8rZFELTR1+nIXiIkp2dx G55WpZ95WbgunGkEfEGMjOiEKkOEr4ZbqqCS6lGgih5JuSgPOmj476FpvR/97GhBiZgL 9aawrFpAdlDo+HvHcqFrq3oqlq7KtH9RsL44AQC8Rwj9xDkzpZaiuaq5VeSB5J+VR9w7 vGFgxLZGRRUGRyzrHBWUiZ2TZxvQUaSgIVer5KHuPE5MaLfjyYgo9msJ/XeJsabYQIIA rP7g== X-Gm-Message-State: AOAM532CIihpeysuiYBK0+Si2rRZIkv7igKfKV93eamnnGpyh5i1mYBe vVAJmbZybqPC5aee0Zkrs6OJcg== X-Google-Smtp-Source: ABdhPJw1rUyWxj/rQ7s0pO1/ZBzj/DtAE619tC7a39yGBjBSweJ42T83q5rRWfVBHySS3qfqj7D1pA== X-Received: by 2002:adf:fd04:: with SMTP id e4mr19803357wrr.353.1596560653827; Tue, 04 Aug 2020 10:04:13 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id k204sm5489228wma.21.2020.08.04.10.04.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 10:04:13 -0700 (PDT) Date: Tue, 4 Aug 2020 19:04:11 +0200 From: daniel@ffwll.ch To: Subject: Re: [PATCH v1 10/22] drm/panel: raydium-rm67191: Backlight update Message-ID: <20200804170411.GO6419@phenom.ffwll.local> References: <20200802110636.1018743-1-sam@ravnborg.org> <20200802110636.1018743-11-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200802110636.1018743-11-sam@ravnborg.org> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , Jingoo Han , dri-devel@lists.freedesktop.org, Thierry Reding , Daniel Vetter , Robert Chiras , Lee Jones Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Aug 02, 2020 at 01:06:24PM +0200, Sam Ravnborg wrote: > - Replace direct access to backlight_properties with > backlight_get_brightness(). > - Use macro for initialization > > Signed-off-by: Sam Ravnborg > Cc: Robert Chiras > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-raydium-rm67191.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-raydium-rm67191.c b/drivers/gpu/drm/panel/panel-raydium-rm67191.c > index 313637d53d28..5553db385dd5 100644 > --- a/drivers/gpu/drm/panel/panel-raydium-rm67191.c > +++ b/drivers/gpu/drm/panel/panel-raydium-rm67191.c > @@ -479,7 +479,7 @@ static int rad_bl_get_brightness(struct backlight_device *bl) > if (ret < 0) > return ret; > > - bl->props.brightness = brightness; > + backlight_set_brightness(bl, brightness); This sounds like a bad idea, again because this overrides the software brightness value potentially when the backlight is off. Althought that's checked a bit higher up, so not too terrible. I'm also feeling like a helper for standard mipi dsi panel backlight would be great, it's pretty much all the same code. -Daniel > > return brightness & 0xff; > } > @@ -495,7 +495,7 @@ static int rad_bl_update_status(struct backlight_device *bl) > > dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; > > - ret = mipi_dsi_dcs_set_display_brightness(dsi, bl->props.brightness); > + ret = mipi_dsi_dcs_set_display_brightness(dsi, backlight_get_brightness(bl)); > if (ret < 0) > return ret; > > @@ -539,10 +539,10 @@ static int rad_init_regulators(struct rad_panel *rad) > > static int rad_panel_probe(struct mipi_dsi_device *dsi) > { > + DECLARE_BACKLIGHT_INIT_RAW(bl_props, 255, 255); > struct device *dev = &dsi->dev; > struct device_node *np = dev->of_node; > struct rad_panel *panel; > - struct backlight_properties bl_props; > int ret; > u32 video_mode; > > @@ -588,11 +588,6 @@ static int rad_panel_probe(struct mipi_dsi_device *dsi) > if (IS_ERR(panel->reset)) > return PTR_ERR(panel->reset); > > - memset(&bl_props, 0, sizeof(bl_props)); > - bl_props.type = BACKLIGHT_RAW; > - bl_props.brightness = 255; > - bl_props.max_brightness = 255; > - > panel->backlight = devm_backlight_device_register(dev, dev_name(dev), > dev, dsi, &rad_bl_ops, > &bl_props); > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel