From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5DC4C433E6 for ; Wed, 2 Sep 2020 00:10:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8558C2068E for ; Wed, 2 Sep 2020 00:10:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="r4b7x/EO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8558C2068E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 74E2B6E0E6; Wed, 2 Sep 2020 00:10:46 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id C352E6E0E6 for ; Wed, 2 Sep 2020 00:10:44 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 07C1DAF2; Wed, 2 Sep 2020 02:10:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1599005431; bh=T0Od6j/YUk8kL37bcHcehkenphDRsmOWADvKVd8tMCE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r4b7x/EOeZJlFBCgShmlvVyXdvsmYhRKg3LxXT23zS3bJC1WbCey8eOdoI66hpDHC xRXC6Q4wIatINWLCRpQYDiJZmUuEPRj9hxArv5rI28k4UHIxQyWYpa22Ds4Ls2fKAP GyQtUk21cZoUO0s0xJ5kYmxHxrFyD0xLAiTDwWUg= Date: Wed, 2 Sep 2020 03:10:09 +0300 From: Laurent Pinchart To: Maxime Ripard Subject: Re: [PATCH v2 1/4] drm/of: Change the prototype of drm_of_lvds_get_dual_link_pixel_order Message-ID: <20200902001009.GC14351@pendragon.ideasonboard.com> References: <6169dd15782627c8415583881fa94ba39c4f5221.1596101672.git-series.maxime@cerno.tech> <20200831202852.GU16155@pendragon.ideasonboard.com> <20200901132340.tahqsx3sknl47ile@gilmour.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200901132340.tahqsx3sknl47ile@gilmour.lan> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Rob Herring , Thomas Zimmermann , Daniel Vetter , Frank Rowand , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime, On Tue, Sep 01, 2020 at 03:23:40PM +0200, Maxime Ripard wrote: > On Mon, Aug 31, 2020 at 11:28:52PM +0300, Laurent Pinchart wrote: > > On Thu, Jul 30, 2020 at 11:35:01AM +0200, Maxime Ripard wrote: > > > The drm_of_lvds_get_dual_link_pixel_order() function took so far the > > > device_node of the two ports used together to make up a dual-link LVDS > > > output. > > > > > > This assumes that a binding would use an entire port for the LVDS output. > > > However, some bindings have used endpoints instead and thus we need to > > > operate at the endpoint level. Change slightly the arguments to allow that. > > > > Is this still needed ? Unless I'm mistaken, the Allwinner platform now > > uses two TCON instances for the two links, so there are two ports. > > Yes, and no. > > The two TCONs indeed have each a port of their own, so we do have two > ports indeed. However, what we don't have is a port entirely dedicated > to the LVDS output. > > Our binding uses a single port for all its output (RGB, LVDS or TV/HDMI > controllers) with different endpoints. Good point. Then let's keep this patch :-) We can't fix existing bindings, but for the future, let's model separate display outputs as ports, not endpoints. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel