From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 201CAC433E2 for ; Wed, 9 Sep 2020 14:45:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAB2D20758 for ; Wed, 9 Sep 2020 14:45:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N+MbeIjr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAB2D20758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1464F6E2E6; Wed, 9 Sep 2020 14:45:44 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 70FCA6E2E6 for ; Wed, 9 Sep 2020 14:45:42 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id a65so2533145wme.5 for ; Wed, 09 Sep 2020 07:45:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5VKePPT3rsU28wXCAu1Xs2KBd1A5X4Nlem8vFp45sFs=; b=N+MbeIjrkaWZSL1rnQBBMQ3t8EgtJ5pPqrCari+s74htlzysCeT43xiaa6jOYcy32h 4CDd9PSLQ49+GE9aRevle7XYa++OWOquZVftThJ4b3J3mk7MOdGIvX/YVJ4/atzSziBT QHOhNZJHMYRC2WOAByxQXcbJ/TxQLqB4Sr3+9q2HGHmYaySmzrk2sQUUz+Kpl7Ek4wAU cKekwJ1cvRmuB3pCyekrgNUPB9OXHj9eOSQD19+VXVp1lZB1x9oVUJJXVhHAbiYN+eAf kA4jU0llu01THgYWYLbkq9qRnuFNG/4WMZXx0YeYtEuuVct/E2BvPHB6tDgTCXe1CJoG BVVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5VKePPT3rsU28wXCAu1Xs2KBd1A5X4Nlem8vFp45sFs=; b=GWitIEErsqAisXHdAkmEBe2dBNl1IFuPWJszlgaeZbDnsilKa9y8r7A+x6ecY2yux1 aiZM0gNFUzz7Jd828Z0c1Cq1/LgV433kpQ1DbA8GohirmG++KluQWkVT770rDXrbSLfR 1gagqQ3DpgzsaKfRoh0yOkZOGixK4yHF+ogj5lc9rBgc/pW7D9ptazvHNSO7E7w0kGGp B5dgPIayV3+poWkkE/QnHO8uvL86rHZhYsJPCjfxyJ/9US+a6p3ixOkHxb8LtzeIUog5 C91IW8ehJzkmXA5VRz5nJOLBXS0UVCnesrGZfYCB98MC2WZPkNlu1dNbjErGF60yZCS7 dCTw== X-Gm-Message-State: AOAM533VOVjreOQPhf8dEVu8jY6IdAQmmpTMnZ2mNMAq6oDn5pA6ZHh9 ULO3LSM53d2/7BL3I0xcm/eClg== X-Google-Smtp-Source: ABdhPJxqI/pYnfEs6qSjztlLK9/QHes6XgHB85V3brQWGlC3Taa9IcIFuEaRLZOMRfZ2rAfTnQSxVA== X-Received: by 2002:a1c:1904:: with SMTP id 4mr3865768wmz.119.1599662741033; Wed, 09 Sep 2020 07:45:41 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id v2sm4773397wrm.16.2020.09.09.07.45.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 07:45:39 -0700 (PDT) Date: Wed, 9 Sep 2020 15:45:37 +0100 From: Daniel Thompson To: Alexandru Stan , linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Jingoo Han , Douglas Anderson , Rob Herring , linux-kernel@vger.kernel.org, Thierry Reding , dri-devel@lists.freedesktop.org, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Enric Balletbo i Serra , Lee Jones , Matthias Kaehlcke Subject: Re: [PATCH 2/3] backlight: pwm_bl: Artificially add 0% during interpolation Message-ID: <20200909144537.daq2exfihhxm6bai@holly.lan> References: <20200721042522.2403410-1-amstan@chromium.org> <20200720212502.2.Iab4d2192e4cf50226e0a58d58df7d90ef92713ce@changeid> <20200904113822.xoyt4w5x7vwvh7cr@holly.lan> <20200907075018.GM2352366@phenom.ffwll.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200907075018.GM2352366@phenom.ffwll.local> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Sep 07, 2020 at 09:50:18AM +0200, Daniel Vetter wrote: > On Fri, Sep 04, 2020 at 12:38:22PM +0100, Daniel Thompson wrote: > > On Mon, Jul 20, 2020 at 09:25:21PM -0700, Alexandru Stan wrote: > > > Some displays need the low end of the curve cropped in order to make > > > them happy. In that case we still want to have the 0% point, even though > > > anything between 0% and 5%(example) would be skipped. > > > > For backlights it is not defined that 0 means off and, to be honest, 0 > > means off is actually rather weird for anything except transflexive > > or front lit reflective displays[1]. There is a problem on several > > systems that when the backlight slider is reduced to zero you can't > > see the screen properly to turn it back up. This patch looks like it > > would make that problem worse by hurting systems with will written > > device trees. > > > > There is some nasty legacy here: some backlight displays that are off > > at zero and that sucks because userspace doesn't know whether zero is > > off or lowest possible setting. > > > > Nevertheless perhaps a better way to handle this case is for 0 to map to > > 5% power and for the userspace to turn the backlight on/off as final > > step in an animated backlight fade out (and one again for a fade in). > > Afaik chromeos encodes "0 means off" somewhere in there stack. We've > gotten similar patches for the i915 backlight driver when we started > obeying the panel's lower limit in our pwm backlight driver thing that's > sometimes used instead of acpi. Out of interest... were they accepted? I did took a quick look at intel_panel.c and didn't see anything that appeared to be special casing zero but I thought I might double check. Daniel. > There's also the problem that with fancy panels with protocol (dsi, edp, > ...) shutting of the backlight completely out of the proper power sequence > hangs the panel (for some panels at least), so providing a backlight off > that doesn't go through the drm modeset sequence isn't always possible. > > It's a bit a mess indeed :-/ > -Daniel > > > > > > > Daniel. > > > > > > > > Signed-off-by: Alexandru Stan > > > --- > > > > > > drivers/video/backlight/pwm_bl.c | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > > > index 5193a72305a2..b24711ddf504 100644 > > > --- a/drivers/video/backlight/pwm_bl.c > > > +++ b/drivers/video/backlight/pwm_bl.c > > > @@ -349,6 +349,14 @@ static int pwm_backlight_parse_dt(struct device *dev, > > > /* Fill in the last point, since no line starts here. */ > > > table[x2] = y2; > > > > > > + /* > > > + * If we don't start at 0 yet we're increasing, assume > > > + * the dts wanted to crop the low end of the range, so > > > + * insert a 0 to provide a display off mode. > > > + */ > > > + if (table[0] > 0 && table[0] < table[num_levels - 1]) > > > + table[0] = 0; > > > + > > > /* > > > * As we use interpolation lets remove current > > > * brightness levels table and replace for the > > > -- > > > 2.27.0 > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel