From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED943C433E2 for ; Fri, 11 Sep 2020 08:56:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F554221EB for ; Fri, 11 Sep 2020 08:56:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="LEqR+2sj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F554221EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C4B3F6E044; Fri, 11 Sep 2020 08:56:48 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id C39386E044 for ; Fri, 11 Sep 2020 08:56:46 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id q9so3685602wmj.2 for ; Fri, 11 Sep 2020 01:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JmRAtgrvidCvnjYSz9nvpyFiEjMSCYV5QqMAFfFdYS4=; b=LEqR+2sjB+GpPRht4zshPvb+pnAJuY169uY7Q6BwVU7+AkCANaJjO2HjEJC3+maL8M 54b0zCHfAFs/kqjqSOu3s8f8PA9ntzc3TT43u7iCpvsZR1W4euedc3ZZcq1crJkx35t+ c9jRtsqoc836WFBRuocdO4GEIFkXgfSrpvi/c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JmRAtgrvidCvnjYSz9nvpyFiEjMSCYV5QqMAFfFdYS4=; b=rScdxUzQG3diPnoNMjEySdzODaGXDNGo9tZUJAhGWnVuUK0I4VGls4/aRRZcvvqRjl fPm5WScWaGyyNwU13RqBPTtMB41mg2oXLa4WBB1xvIfiUx14xnbZOSSXRm/kx2jEdp/v cygGoiZmPuKXZRgEPZfQra2jWAPVyBN5tPrNm/F7HvmLbfPbs/ZD855wmqQEtvKL3McX kqSM2/P4z/bpRdIHosomqss6Z2Zm3kaWk5JOdN/pdIDUnFmF9Zpknq4IngcDlt0VvhQ7 ifRgu3hzjFBguLBu13Eu5lT0RnYtppgk/gJbHuzGtBQ3QBAqBmTCzcpBbTMUgSxEmXaz TOag== X-Gm-Message-State: AOAM531WT7QBQ5WRLSn3CDWBN1Q7CP8tSvIkHHY9r2GkpuZvhwrAE8hj 5ViL1juCeOAUsCLUUhrVxovgCQ== X-Google-Smtp-Source: ABdhPJwx562VHwJbLQkKIWCTdsbamNlU7QvrTuA5wbicSXb6Gxi65wNDF+NAZ2VPXhLWRoej7pr/Zg== X-Received: by 2002:a7b:c5c6:: with SMTP id n6mr1123884wmk.120.1599814605358; Fri, 11 Sep 2020 01:56:45 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id b18sm3357160wrn.21.2020.09.11.01.56.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 01:56:44 -0700 (PDT) Date: Fri, 11 Sep 2020 10:56:42 +0200 From: Daniel Vetter To: Sam Ravnborg Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display Message-ID: <20200911085642.GR438822@phenom.ffwll.local> References: <1598904172-30865-1-git-send-email-anitha.chrisanthus@intel.com> <1598904172-30865-3-git-send-email-anitha.chrisanthus@intel.com> <20200910083042.GH438822@phenom.ffwll.local> <20200910183343.GC893045@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200910183343.GC893045@ravnborg.org> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anitha Chrisanthus , daniel.vetter@intel.com, edmund.j.dea@intel.com, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Sep 10, 2020 at 08:33:43PM +0200, Sam Ravnborg wrote: > Hi Daniel. > > > > + } > > > + > > > + /* Initialize MIPI DSI */ > > > + ret = kmb_dsi_init(drm, adv_bridge); > > > > Split up isn't correct here, this won't compile since the dsi code isn't > > in this patch yet. So you need to have this ordered the other way round. > > I have explicit asked for a simple file split as done here > and told Anitha this was fine. > > As the kbuild/kconfig bits are the last patch then no build breakage. > The file based split was IMO fine to ease review. > > If this is not OK then blame me :-) Ah I missed that, sounds ok for me too then :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel