From: Sam Ravnborg <sam@ravnborg.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [RFC PATCH v1 3/3] dt-binding: display: Require two rests on mantix panel
Date: Thu, 24 Sep 2020 21:38:07 +0200 [thread overview]
Message-ID: <20200924193807.GA1223313@ravnborg.org> (raw)
In-Reply-To: <71a9108f3472ba9af4bead01b1b770d1e73eb08e.1600707235.git.agx@sigxcpu.org>
Hi Guido.
On Mon, Sep 21, 2020 at 06:55:52PM +0200, Guido Günther wrote:
> We need to reset both for the panel to show an image.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> .../bindings/display/panel/mantix,mlaf057we51-x.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
> index 937323cc9aaa..ba5a18fac9f9 100644
> --- a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
> @@ -35,7 +35,9 @@ properties:
> vddi-supply:
> description: 1.8V I/O voltage supply
>
> - reset-gpios: true
> + reset-gpios:
> + minItems: 2
> + maxItems: 2
reset-gpios is, as you already wrote, defined in panel-common.yaml.
Do not try to change it here.
It would be much better, I think, to introduce a mantix,reset-gpios
property.
This would avoid that we had two different reset-gpios definitions.
Sam
>
> backlight: true
>
> @@ -62,7 +64,8 @@ examples:
> avdd-supply = <®_avdd>;
> avee-supply = <®_avee>;
> vddi-supply = <®_1v8_p>;
> - reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>;
> + reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>,
> + <&gpio1 24 GPIO_ACTIVE_LOW>;
> backlight = <&backlight>;
> };
> };
> --
> 2.26.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-24 19:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 16:55 [RFC PATCH v1 0/3] drm/panel: mantix panel reset fixes Guido Günther
2020-09-21 16:55 ` [RFC PATCH v1 1/3] drm/panel: mantix: Don't dereference NULL mode Guido Günther
2020-09-21 16:55 ` [RFC PATCH v1 2/3] drm/panel: mantix: Fix panel reset Guido Günther
2020-09-21 16:55 ` [RFC PATCH v1 3/3] dt-binding: display: Require two rests on mantix panel Guido Günther
2020-09-21 17:05 ` Fabio Estevam
2020-09-22 11:38 ` Guido Günther
2020-09-24 19:38 ` Sam Ravnborg [this message]
2020-09-28 6:50 ` Thierry Reding
2020-09-28 15:02 ` Guido Günther
2020-09-29 17:46 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924193807.GA1223313@ravnborg.org \
--to=sam@ravnborg.org \
--cc=agx@sigxcpu.org \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).