dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: "Marek Vasut" <marex@denx.de>,
	devicetree@vger.kernel.org, "Guido Günther" <agx@sigxcpu.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/7] dt-bindings: display: mxsfb: Add and fix compatible strings
Date: Wed,  7 Oct 2020 04:24:33 +0300	[thread overview]
Message-ID: <20201007012438.27970-3-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20201007012438.27970-1-laurent.pinchart@ideasonboard.com>

Additional compatible strings have been added in DT source for the
i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings.
Most of the upstream DT sources use the fsl,imx28-lcdif compatible
string, which mostly predates the realization that the LCDIF in the
i.MX6 and newer SoCs have extra features compared to the i.MX28.

Update the bindings to add the missing compatible strings, with the
correct fallback values. This fails to validate some of the upstream DT
sources. Instead of adding the incorrect compatible fallback to the
binding, the sources should be updated separately.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
---
Changes since v1:

- Fix indentation under enum
---
 .../devicetree/bindings/display/fsl,lcdif.yaml | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index 063bb8c58114..404bd516b7f5 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -15,11 +15,19 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - fsl,imx23-lcdif
-      - fsl,imx28-lcdif
-      - fsl,imx6sx-lcdif
-      - fsl,imx8mq-lcdif
+    oneOf:
+      - enum:
+          - fsl,imx23-lcdif
+          - fsl,imx28-lcdif
+          - fsl,imx6sx-lcdif
+      - items:
+        - enum:
+            - fsl,imx6sl-lcdif
+            - fsl,imx6sll-lcdif
+            - fsl,imx6ul-lcdif
+            - fsl,imx7d-lcdif
+            - fsl,imx8mq-lcdif
+        - const: fsl,imx6sx-lcdif
 
   reg:
     maxItems: 1
-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-10-07  1:25 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07  1:24 [PATCH v2 0/7] drm: mxsfb: Allow overriding bus width Laurent Pinchart
2020-10-07  1:24 ` [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML Laurent Pinchart
2020-10-07  8:32   ` Marek Vasut
2020-10-07  8:43     ` Lucas Stach
2020-10-07  8:55       ` Marek Vasut
2020-10-07 13:33         ` Laurent Pinchart
2020-10-07 14:20           ` Marek Vasut
2020-10-07 16:00   ` Rob Herring
2020-10-07 16:02     ` Rob Herring
2020-10-09 23:52     ` Laurent Pinchart
2021-01-15  7:59   ` Martin Kepplinger
2021-01-15 22:25     ` Laurent Pinchart
2021-01-16  6:41       ` Martin Kepplinger
2020-10-07  1:24 ` Laurent Pinchart [this message]
2020-10-07  8:35   ` [PATCH v2 2/7] dt-bindings: display: mxsfb: Add and fix compatible strings Marek Vasut
2020-10-07 16:01   ` Rob Herring
2020-10-07  1:24 ` [PATCH v2 3/7] dt-bindings: display: mxsfb: Add a bus-width endpoint property Laurent Pinchart
2020-10-07  8:40   ` Marek Vasut
2020-10-09 23:58     ` Laurent Pinchart
2020-10-10  8:47       ` Marek Vasut
2020-10-13  2:06         ` Laurent Pinchart
2020-10-13 11:03           ` Marek Vasut
2020-10-07 16:03   ` Rob Herring
2020-10-07  1:24 ` [PATCH v2 4/7] ARM: dts: imx: Fix LCDIF compatible strings Laurent Pinchart
2020-10-07  1:24 ` [PATCH v2 5/7] arm64: dts: imx8mq: " Laurent Pinchart
2020-10-07  1:24 ` [PATCH v2 6/7] ARM: dts: imx: Remove unneeded LCDIF disp_axi clock Laurent Pinchart
2020-10-07  1:24 ` [PATCH v2 7/7] drm: mxsfb: Add support for the bus-width DT property Laurent Pinchart
2020-10-10  0:01 ` [PATCH v2 8/7] dt-bindings: display: mxsfb: Add compatible for i.MX8MM Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201007012438.27970-3-laurent.pinchart@ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=agx@sigxcpu.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marex@denx.de \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v2 2/7] dt-bindings: display: mxsfb: Add and fix compatible strings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).