From: "Guido Günther" <agx@sigxcpu.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: David Airlie <airlied@linux.ie>,
devicetree@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 0/3] drm/panel: mantix panel reset fixes
Date: Fri, 23 Oct 2020 10:15:41 +0200 [thread overview]
Message-ID: <20201023081541.GA209500@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <20201022045929.GA2775675@ravnborg.org>
Hi Sam,
On Thu, Oct 22, 2020 at 06:59:29AM +0200, Sam Ravnborg wrote:
> Hi Guido.
>
> On Tue, Oct 20, 2020 at 01:57:11PM +0200, Guido Günther wrote:
> > Hi Daniel, Sam,
> > On Mon, Oct 19, 2020 at 05:44:37PM +0200, Daniel Vetter wrote:
> > > On Sat, Oct 17, 2020 at 12:47:36PM +0200, Sam Ravnborg wrote:
> > > > Hi Guido.
> > > >
> > > > On Sat, Oct 17, 2020 at 11:13:07AM +0200, Guido Günther wrote:
> > > > > Hi Sam,
> > > > > On Fri, Oct 16, 2020 at 04:29:16PM +0200, Sam Ravnborg wrote:
> > > > > > Hi Guido.
> > > > > > On Tue, Oct 13, 2020 at 12:32:45PM +0200, Guido Günther wrote:
> > > > > [..snip..]
> > > > > > >
> > > > > > > Changes from v1:
> > > > > > > - As per review comments by Fabio Estevam
> > > > > > > https://lore.kernel.org/dri-devel/CAOMZO5B5ECcConvKej=RcaF8wvOxgq7nUzKJ-ad0aSAOzUqtbQ@mail.gmail.com/
> > > > > > > - Fix typo in commit messages
> > > > > > > - As per review comments by Rob Herring
> > > > > > > https://lore.kernel.org/dri-devel/20200929174624.GA832332@bogus/
> > > > > > > - Don't use an array of reset lines
> > > > > > >
> > > > > > > Guido Günther (3):
> > > > > > > drm/panel: mantix: Don't dereference NULL mode
> > > > > > > drm/panel: mantix: Fix panel reset
> > > > > > > dt-binding: display: Require two resets on mantix panel
> > > > > >
> > > > > > All applied to drm-misc-next and pushed out.
> > > > > > And then I remembered you had commit right - sigh.
> > > > >
> > > > > Thanks! Is there any special care needed to get that into 5.10? The
> > > > > driver landed there in 72967d5616d3f0c714f8eb6c4e258179a9031c45.
> > > >
> > > > As the patches was applied to drm-misc-next the easiet path would
> > > > be to cherry-pick them and apply to drm-misc-fixes.
> > > > dim has cherry-pick support - try to use it rahter than doing it by
> > > > hand.
> > >
> > > drm-misc-next-fixes while we're between freeze and merge window end:
> > >
> > > https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.html#where-do-i-apply-my-patch
> >
> > Great. Thanks for the pointer, that works. Now i get:
> >
> > $ ../maintainer-tools/dim push --dry-run
> > dim: 3532f0117258 ("dt-binding: display: Require two resets on mantix panel"): mandatory review missing.
> > dim: c90f95ad6d05 ("drm/panel: mantix: Fix panel reset"): mandatory review missing.
> > dim: 8b557f793e69 ("drm/panel: mantix: Don't dereference NULL mode"): mandatory review missing.
> > dim: ERROR: issues in commits detected, aborting
> >
> > and in fact there's only Signed-off-by's on it:
> >
> > Fixes: 72967d5616d3 ("drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel")
> > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Link: https://patchwork.freedesktop.org/patch/msgid/ba71a8ab010d263a8058dd4f711e3bcd95877bf2.1602584953.git.agx@sigxcpu.org
> >
> > Sam, I assume your Signed-off-by's should have been Reviewed-by ?
> > O.k. to fix that up in the commit message before pushing to
> > drm-misc-next?
> Fine to add my r-b.
>
> For patches I push I always read the patch - but seldom claim that I
> review them. It seems a bit implicit I think - but maybe this is just
> bad practice on my side.
I don't know but for fixes i seems fine for dim to complain if they show
up without a r-b.
>
> Then I also avoid the endless discussion with myself it what I did
> warrant an a-b or r-b.
Pushed out now, thanks a lot for the help!
Cheers,
-- Guido
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-23 8:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 10:32 [PATCH v2 0/3] drm/panel: mantix panel reset fixes Guido Günther
2020-10-13 10:32 ` [PATCH v2 1/3] drm/panel: mantix: Don't dereference NULL mode Guido Günther
2020-10-13 10:32 ` [PATCH v2 2/3] drm/panel: mantix: Fix panel reset Guido Günther
2020-10-13 10:32 ` [PATCH v2 3/3] dt-binding: display: Require two resets on mantix panel Guido Günther
2020-10-16 14:29 ` [PATCH v2 0/3] drm/panel: mantix panel reset fixes Sam Ravnborg
2020-10-17 9:13 ` Guido Günther
2020-10-17 10:47 ` Sam Ravnborg
2020-10-18 13:01 ` Guido Günther
2020-10-18 13:38 ` Sam Ravnborg
2020-10-19 14:39 ` Guido Günther
2020-10-19 15:44 ` Daniel Vetter
2020-10-20 11:57 ` Guido Günther
2020-10-22 4:59 ` Sam Ravnborg
2020-10-23 8:15 ` Guido Günther [this message]
2020-10-22 13:13 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023081541.GA209500@bogon.m.sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).