From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DF5FC4363A for ; Mon, 26 Oct 2020 19:42:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAC5721655 for ; Mon, 26 Oct 2020 19:42:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zv4bVSyc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAC5721655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B9A86E0E5; Mon, 26 Oct 2020 19:42:01 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 506666E0E5 for ; Mon, 26 Oct 2020 19:42:00 +0000 (UTC) Received: from localhost.localdomain (unknown [192.30.34.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D49820878; Mon, 26 Oct 2020 19:41:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603741320; bh=mIfaVETSabg91MwqbVtm2b4ynodCXFlMtwDnztI5meU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zv4bVSycCE8I2wHh1gwb5oj3EdCQ0US/CCzuSG9f52ClGLEW8+82mpR63xjohRAnm 45GEtSA/kKAJW8n3bvLoISe7XUN4l2wy7rtqwo36g69yM6UJekGHH8K3VnckFIWxgA ig/wrXSqTSpEEqDbH/qwMlK74EglUUjR8u5+ArEE= From: Arnd Bergmann To: Patrik Jakobsson , David Airlie , Daniel Vetter , Stefan Christ Subject: [PATCH 4/4] drm/gma500: avoid Woverride-init warning Date: Mon, 26 Oct 2020 20:41:04 +0100 Message-Id: <20201026194110.3817470-4-arnd@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201026194110.3817470-1-arnd@kernel.org> References: <20201026194110.3817470-1-arnd@kernel.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Daniel Vetter , linux-kernel@vger.kernel.org, Rikard Falkeborn , Paul Kocialkowski , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Pankaj Bharadiya , Emil Velikov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Arnd Bergmann gcc -Wextra notices that one of the fields in psbfb_roll_ops has two initializers: drivers/gpu/drm/gma500/framebuffer.c:185:20: warning: initialized field overwritten [-Woverride-init] Open-code this instead, leaving out the extraneous initializers for .fb_pan_display. Fixes: 3da6c2f3b730 ("drm/gma500: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/gma500/framebuffer.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index 54d9876b5305..a56a6b53fac6 100644 --- a/drivers/gpu/drm/gma500/framebuffer.c +++ b/drivers/gpu/drm/gma500/framebuffer.c @@ -177,7 +177,14 @@ static const struct fb_ops psbfb_ops = { static const struct fb_ops psbfb_roll_ops = { .owner = THIS_MODULE, - DRM_FB_HELPER_DEFAULT_OPS, + .fb_check_var = drm_fb_helper_check_var, + .fb_set_par = drm_fb_helper_set_par, + .fb_setcmap = drm_fb_helper_setcmap, + .fb_blank = drm_fb_helper_blank, + .fb_debug_enter = drm_fb_helper_debug_enter, + .fb_debug_leave = drm_fb_helper_debug_leave, + .fb_ioctl = drm_fb_helper_ioctl, + .fb_setcolreg = psbfb_setcolreg, .fb_fillrect = drm_fb_helper_cfb_fillrect, .fb_copyarea = drm_fb_helper_cfb_copyarea, -- 2.27.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel