From: mka@chromium.org
To: Akhil P Oommen <akhilpo@codeaurora.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dianders@chromium.org, linux-kernel@vger.kernel.org,
dri-devel@freedesktop.org, freedreno@lists.freedesktop.org
Subject: Re: [v3,2/3] arm64: dts: qcom: sc7180: Add gpu cooling support
Date: Wed, 28 Oct 2020 17:39:31 -0700 [thread overview]
Message-ID: <20201029003931.GA1855806@google.com> (raw)
In-Reply-To: <1603892395-3570-2-git-send-email-akhilpo@codeaurora.org>
Hi Akhil,
On Wed, Oct 28, 2020 at 07:09:53PM +0530, Akhil P Oommen wrote:
> Add cooling-cells property and the cooling maps for the gpu tzones
> to support GPU cooling.
>
> Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 30 +++++++++++++++++++++++-------
> 1 file changed, 23 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index d46b383..a7ea029 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -2,7 +2,7 @@
> /*
> * SC7180 SoC device tree source
> *
> - * Copyright (c) 2019, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2019-20, The Linux Foundation. All rights reserved.
> */
>
> #include <dt-bindings/clock/qcom,dispcc-sc7180.h>
> @@ -1886,6 +1886,8 @@
> operating-points-v2 = <&gpu_opp_table>;
> qcom,gmu = <&gmu>;
>
> + #cooling-cells = <2>;
> +
> interconnects = <&gem_noc MASTER_GFX3D &mc_virt SLAVE_EBI1>;
> interconnect-names = "gfx-mem";
>
> @@ -3825,16 +3827,16 @@
> };
>
> gpuss0-thermal {
> - polling-delay-passive = <0>;
> + polling-delay-passive = <100>;
> polling-delay = <0>;
>
> thermal-sensors = <&tsens0 13>;
>
> trips {
> gpuss0_alert0: trip-point0 {
> - temperature = <90000>;
> + temperature = <95000>;
> hysteresis = <2000>;
> - type = "hot";
> + type = "passive";
> };
>
> gpuss0_crit: gpuss0_crit {
> @@ -3843,19 +3845,26 @@
> type = "critical";
> };
> };
> +
> + cooling-maps {
> + map0 {
> + trip = <&gpuss0_alert0>;
> + cooling-device = <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> };
>
> gpuss1-thermal {
> - polling-delay-passive = <0>;
> + polling-delay-passive = <100>;
> polling-delay = <0>;
>
> thermal-sensors = <&tsens0 14>;
>
> trips {
> gpuss1_alert0: trip-point0 {
> - temperature = <90000>;
> + temperature = <95000>;
> hysteresis = <2000>;
> - type = "hot";
> + type = "passive";
> };
>
> gpuss1_crit: gpuss1_crit {
> @@ -3864,6 +3873,13 @@
> type = "critical";
> };
> };
> +
> + cooling-maps {
> + map0 {
> + trip = <&gpuss0_alert0>;
Copy & paste error, this should be 'gpuss1_alert0'.
> + cooling-device = <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> };
>
> aoss1-thermal {
Other than the C&P error:
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-29 0:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 13:39 [PATCH v3 1/3] drm/msm: Add support for GPU cooling Akhil P Oommen
2020-10-28 13:39 ` [PATCH v3 2/3] arm64: dts: qcom: sc7180: Add gpu cooling support Akhil P Oommen
2020-10-29 0:39 ` mka [this message]
2020-10-29 7:58 ` [v3,2/3] " Akhil P Oommen
2020-10-28 13:39 ` [PATCH v3 3/3] dt-bindings: drm/msm/gpu: Add cooling device support Akhil P Oommen
2020-10-29 0:49 ` [v3,3/3] " mka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029003931.GA1855806@google.com \
--to=mka@chromium.org \
--cc=akhilpo@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).