Hi, On Mon, Nov 02, 2020 at 09:09:44AM +0100, Thomas Zimmermann wrote: > I read through the patch and it looks correct to me. The naming is a bit > off at times. For example, ast_state should now probably be called > ast_crtc_state. But that's not a blocker IMHO. Yeah, a few places have odd names, but to be fair I didn't change them :) The ast_crtc_state struct you're mentioning used to be called ast_state before the patch as well. Maxime