From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E9E0C4741F for ; Mon, 9 Nov 2020 08:52:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02978206ED for ; Mon, 9 Nov 2020 08:52:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LstmlGWF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02978206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD92289664; Mon, 9 Nov 2020 08:52:31 +0000 (UTC) Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 02D19893EF for ; Mon, 9 Nov 2020 05:35:49 +0000 (UTC) Received: by mail-pg1-x543.google.com with SMTP id i7so6162871pgh.6 for ; Sun, 08 Nov 2020 21:35:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IJUnC1qet5XGxBxbk2JzSrwVUK3/0sjfx2cNNTG8d4M=; b=LstmlGWFsa5jYxw8Vkksf7r52gSPeNdq2rFCsHGIk3c7l0AwqeEGR2gU2Hu2jp53nQ Y9/SJc2XbWbXfLNrk3m8dwkMzOadrr18+gXJf6HMX70IUW4vYncHLxcCR110tbXhs55a EQhxbUj76xTKdvrpBlPVjubbEjZl+Y5zbMCqwugKbJnzkoNSIiP+wDGvpyOw7QL37cSI 4aW76kahFRWDdxouicRCqdqVzxB3wv8Aa83PxGUToWRNF9HLbIG9/Gni9TZvQv8NC382 ydqorAlKhtADyq79PaRSMdNHK43d74XsaHTphlRarNe6XqB7vDtVzeq4Rj/iiWEks7Q4 L/ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IJUnC1qet5XGxBxbk2JzSrwVUK3/0sjfx2cNNTG8d4M=; b=L4S50fWkmGhhYBr/cX6iem2aKs4jKjvpTKrN4Fz0bMjNVGq3dQ1kyFsLKGDxDHQgZQ +W+zIdzdrbBWpQWqLlgK608UXwW2scrma1L0N0ClUXVLTTFDuTz+s1lp3y1+Ie4csSL7 sVnCJHo6/wBIfvgXLL3Ho5rRhXyxEbDGnvfG7Jtb5zoyw86ZpPtuTa9X+gzN/XSXHTKa q/p6aXOpI72uTuyQqyqAZW5D054xe3lGG4LcSBhF+VtTqA9a326Ta9C9locHOccz/Oos oi9baHZTKyh5Chk3ciHyDUeYziiKDkBq6TI7/zuczZkO4Q0jLdgvibf415jZ4WruZbR5 2EOg== X-Gm-Message-State: AOAM533zNmAJO529LgDLsjlIIajTNQGCBlSLjrcJuRtf3F5N2Xub+G7z fGJPEHuhXhnNaR/V/xQfjvU+lg== X-Google-Smtp-Source: ABdhPJyFGt53uc1RwZIWqNmOTufjNhL6TQqNB7dxd3bb+lEFg1bJQu36bKwaT5Mj2KBhPEtooXzYdQ== X-Received: by 2002:a65:4144:: with SMTP id x4mr11299072pgp.432.1604900149527; Sun, 08 Nov 2020 21:35:49 -0800 (PST) Received: from localhost ([122.172.12.172]) by smtp.gmail.com with ESMTPSA id e10sm10531236pfl.162.2020.11.08.21.35.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Nov 2020 21:35:48 -0800 (PST) Date: Mon, 9 Nov 2020 11:05:46 +0530 From: Viresh Kumar To: Dmitry Osipenko Subject: Re: [PATCH v1 17/30] mmc: sdhci-tegra: Support OPP and core voltage scaling Message-ID: <20201109053546.xupmmsx5qccn46tr@vireshk-i7> References: <20201104234427.26477-18-digetx@gmail.com> <6fa54ce6-d5ae-d04f-7c77-b62c148d92b7@gmail.com> <20201106061513.uyys7njcqcdlah67@vireshk-i7> <20201109050010.g47zojh6wafvwqva@vireshk-i7> <20201109051014.oa6bt4g3ctm2hnuy@vireshk-i7> <4476fed9-a356-b7f1-32ee-935343e23038@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4476fed9-a356-b7f1-32ee-935343e23038@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 X-Mailman-Approved-At: Mon, 09 Nov 2020 08:52:30 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Chen , Ulf Hansson , linux-pwm@vger.kernel.org, Frank Lee , dri-devel , Adrian Hunter , Thierry Reding , Lee Jones , Marek Szyprowski , driver-dev , linux-samsung-soc , Nicolas Chauvet , Krzysztof Kozlowski , Jonathan Hunter , Alan Stern , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-media@vger.kernel.org, DTML , Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-usb@vger.kernel.org, "open list:SECURE DIGITAL HO..." , Liam Girdwood , Linux Kernel Mailing List , Mark Brown , Peter Geis Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 09-11-20, 08:19, Dmitry Osipenko wrote: > Thanks, I made it in a different way by simply adding helpers to the > pm_opp.h which use devm_add_action_or_reset(). This doesn't require to > add new kernel symbols. I will prefer to add it in core.c itself, and yes devm_add_action_or_reset() looks better. But I am still not sure for which helpers do we need the devm_*() variants, as this is only useful for non-CPU devices. But if we have users that we can add right now, why not. > static inline int devm_pm_opp_of_add_table(struct device *dev) > { > int err; > > err = dev_pm_opp_of_add_table(dev); > if (err) > return err; > > err = devm_add_action_or_reset(dev, (void*)dev_pm_opp_remove_table, > dev); > if (err) > return err; > > return 0; > } -- viresh _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel