From: James Qian Wang <james.qian.wang@arm.com>
To: Liviu.Dudau@arm.com, daniel@ffwll.ch, carsten.haitzler@foss.arm.com
Cc: nd@arm.com,
"James Qian Wang \(Arm Technology China\)"
<james.qian.wang@arm.com>,
dri-devel@lists.freedesktop.org
Subject: [PATCH] drm/komeda: Correct the sequence of hw_done() and flip_done()
Date: Thu, 19 Nov 2020 09:39:48 +0800 [thread overview]
Message-ID: <20201119013948.2866343-1-james.qian.wang@arm.com> (raw)
From: "James Qian Wang (Arm Technology China)" <james.qian.wang@arm.com>
Komeda HW has no special, program the update to HW is done first,
then flip happens. So correct the sequence to hw_done() first then
flip_done().
Reported-by: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: James Qian Wang <james.qian.wang@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
index 6b99df696384..034ee08482e0 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
@@ -81,10 +81,10 @@ static void komeda_kms_commit_tail(struct drm_atomic_state *old_state)
drm_atomic_helper_commit_modeset_enables(dev, old_state);
- drm_atomic_helper_wait_for_flip_done(dev, old_state);
-
drm_atomic_helper_commit_hw_done(old_state);
+ drm_atomic_helper_wait_for_flip_done(dev, old_state);
+
drm_atomic_helper_cleanup_planes(dev, old_state);
}
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2020-11-19 1:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 1:39 James Qian Wang [this message]
2020-11-19 15:27 ` [PATCH] drm/komeda: Correct the sequence of hw_done() and flip_done() Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119013948.2866343-1-james.qian.wang@arm.com \
--to=james.qian.wang@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=carsten.haitzler@foss.arm.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).