From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C904FC63777 for ; Wed, 25 Nov 2020 08:13:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CFB520857 for ; Wed, 25 Nov 2020 08:13:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="O5+yyy3u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CFB520857 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9BFE16E86B; Wed, 25 Nov 2020 08:13:01 +0000 (UTC) Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3AFA36E223 for ; Tue, 24 Nov 2020 15:55:30 +0000 (UTC) Received: by mail-qk1-x743.google.com with SMTP id i199so7389593qke.5 for ; Tue, 24 Nov 2020 07:55:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oaa+hWx1KaHAmS3DtMmmCm5kDyFbE+baLseZRB4QB5M=; b=O5+yyy3ugn3/JU8d8MzJuhxMQSAXmFG+K4qLwFzZz9R/0yzGmphek8afsqJ5XmaX7K QFgr2UTIeMkWtrEUfgUgKbsoR4KB1EzCADhT2doRjFOEg0XNrQLFT7UfegvU6LtETQdH BNfxI2uepF2ckC2z3Hg3jdCWPASQ46yKLRwg1QiNwPCb0sAmz1+AfFialcU6UizGRLb/ cFkrXVxqj0abamYnuOiwNBjY7IEIegPAbiNZQupZKDH6jzAd8pc/L3Rexp2KSypUx3WN r58Z5/hOA1lt5wCiVxmAus+J+0CeYWzJLI1kYadqPB7BHX4GvlOoLo7sQ3sz3WRenNdb j0ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oaa+hWx1KaHAmS3DtMmmCm5kDyFbE+baLseZRB4QB5M=; b=QU4lXxyAmHi6QH2+OnrrSXGsLeB6dItCu2X3HfGHkgyBtYfu/cPymxLmnUFOBBV4Mp xwyZFdjHE0SLUj+mFkN5Jw5YBTxmuFYEo//Seb6QLo5qtD4Fa3YQ+fGR14ll4x+K6boM we5wSsgbclkiFXxqo/458GQYXFiUYc3J8zcTASgCzew7X2P47t3k0nkwM2+RvjN39mab plD1ziCuxxtnHCjc1aC2O/ZHmmpGY7ERLaVXTo5zz6eKH/Vd8zz9x4k2we850zgPph4L jrG8/Q256nZ04iXNf6NC4hBP4wQay5BEUCXYlrhQplNEF8WlHsuoF2jq83UyG1kSEziL nbRA== X-Gm-Message-State: AOAM530/1dQ+2cKXP/Y/nCqT2IKsaTFvViGI2WWWTBKa/ZNNAT1/cR39 FOm/o8ixUssoQM+4oW6azedCEESiu6fjizti X-Google-Smtp-Source: ABdhPJzKvpnJwdDviRxMRDTdGK9+HHkdY7h1hzFeJT5r8VTnR/8g0865BSrf5PrqIcB8Qlf6akZbcQ== X-Received: by 2002:a05:620a:2106:: with SMTP id l6mr5371085qkl.302.1606233328732; Tue, 24 Nov 2020 07:55:28 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id x24sm12795492qkx.23.2020.11.24.07.55.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 07:55:27 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1khaf8-000pJU-UM; Tue, 24 Nov 2020 11:55:26 -0400 Date: Tue, 24 Nov 2020 11:55:26 -0400 From: Jason Gunthorpe To: DRI Development , LKML , kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, Daniel Vetter , Christoph Hellwig , Kees Cook , Dan Williams , Andrew Morton , John Hubbard , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Jan Kara Subject: Re: [PATCH v6 17/17] RFC: mm: add mmu_notifier argument to follow_pfn Message-ID: <20201124155526.GH5487@ziepe.ca> References: <20201119144146.1045202-1-daniel.vetter@ffwll.ch> <20201119144146.1045202-18-daniel.vetter@ffwll.ch> <20201120183029.GQ244516@ziepe.ca> <20201124142814.GM401619@phenom.ffwll.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201124142814.GM401619@phenom.ffwll.local> X-Mailman-Approved-At: Wed, 25 Nov 2020 08:11:52 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Nov 24, 2020 at 03:28:14PM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2020 at 02:30:29PM -0400, Jason Gunthorpe wrote: > > On Thu, Nov 19, 2020 at 03:41:46PM +0100, Daniel Vetter wrote: > > > @@ -4805,21 +4824,15 @@ EXPORT_SYMBOL(follow_pte_pmd); > > > * Return: zero and the pfn at @pfn on success, -ve otherwise. > > > */ > > > int follow_pfn(struct vm_area_struct *vma, unsigned long address, > > > - unsigned long *pfn) > > > + unsigned long *pfn, struct mmu_notifier *subscription) > > > { > > > - int ret = -EINVAL; > > > - spinlock_t *ptl; > > > - pte_t *ptep; > > > + if (WARN_ON(!subscription->mm)) > > > + return -EINVAL; > > > > > > + if (WARN_ON(subscription->mm != vma->vm_mm)) > > > + return -EINVAL; > > > > These two things are redundant right? vma->vm_mm != NULL? > > Yup, will remove. > > > BTW, why do we even have this for nommu? If the only caller is kvm, > > can you even compile kvm on nommu?? > > Kinda makes sense, but I have no idea how to make sure with compile > testing this is really the case. And I didn't see any hard evidence in > Kconfig or Makefile that mmu notifiers requires CONFIG_MMU. So not sure > what to do here. It looks like only some arches have selectable CONFIG_MMU: arm, m68k, microblaze, riscv, sh If we look at arches that work with HAVE_KVM, I only see: arm64, mips, powerpc, s390, x86 So my conclusion is there is no intersection between !MMU and HAVE_KVM? > Should I just remove the nommu version of follow_pfn and see what happens? > We can't remove it earlier since it's still used by other > subsystems. This is what I was thinking might work Jason _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel