From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C44C4361B for ; Mon, 7 Dec 2020 10:45:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF03723339 for ; Mon, 7 Dec 2020 10:45:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF03723339 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 51FBD89364; Mon, 7 Dec 2020 10:45:08 +0000 (UTC) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 838DA89364 for ; Mon, 7 Dec 2020 10:45:06 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id j10so14416025lja.5 for ; Mon, 07 Dec 2020 02:45:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version; bh=dtYeAIz/Tlm34/zugzB9i++IzBupGAArbI1GeokfBr0=; b=EazD7IaZjKO4rP/671DjJeyG65KGY+YwW5djuaUZw0tvSYuHv/pc5If5WGy8aE5q5X 7OAwYNn6F76y4oFeISWX/0cUecbOO4SRWuHcOqrw2s40DIHUapzyNZf2lJraPI4fFIGD Cb0f833NF+ZMy9esSup/o8RDw1RstmZlWgdd/w4i/FTIe+AckhM3DGlYLVWfnzwLIF9y dhyqaLeFuTQLsOjr5s5mLC4W62obk6XAfr+7QO92D+hAqK8xMa6ZG7ssRP//PQhvSR6t wh9RoiN8A0dBAzBU5a3Z7yTj6F6VFjuF9u/FPk9ZYYvH86T3WqDiIrxPn6B9TOzYH+rJ UjPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version; bh=dtYeAIz/Tlm34/zugzB9i++IzBupGAArbI1GeokfBr0=; b=in0uYDC5CqHxl/PACjX15oiyeWhfK5K1d/RJjbGjg+3u2xYdKoj5MiakQekEJve6ze yAo3lwpEa0dc0NU35ASJnIqDzje8hjPToZShDiRdOkYLpEjbOXs9dROti6D0uLMieJkX G1ZC8SyBWwDoY9hpDTLDkoncTK8L8ksW9uN7Oo1jIqX+UibzOTlYBezsbVkUvEQvhCCB 66EOl0zUE4Fsroj/RCmbwfw+lzcTeYJYs4TuXpEkCdxf2yPBjFqtSO+AQnTuCYINMqVh 6WvM4SEN7D1OB2EGzqEcSVTVluSqisb3AAc9t8kEk8DCWXwxRnthZhFYdRHw22llShxH Q3GQ== X-Gm-Message-State: AOAM531G1UlRK8FTX+2U1c/OJdjtbsVd6s+nYCz66W9Id23ZHTVyYOBF pkKVZr6Cx1QRihjlUIpaH88= X-Google-Smtp-Source: ABdhPJzcoXsRYfafrO1JYk/RLgjTKfaHehYWFLsTA8AL/tbpfoY1M5T5da3WBcWXmpJMhEM78y7Y7Q== X-Received: by 2002:a2e:81cb:: with SMTP id s11mr1646582ljg.377.1607337904962; Mon, 07 Dec 2020 02:45:04 -0800 (PST) Received: from eldfell ([194.136.85.206]) by smtp.gmail.com with ESMTPSA id n13sm1132540ljg.64.2020.12.07.02.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 02:45:04 -0800 (PST) Date: Mon, 7 Dec 2020 12:44:54 +0200 From: Pekka Paalanen To: James Park Subject: Re: [PATCH] drm: Fix drm.h uapi header for Windows Message-ID: <20201207124454.42b87186@eldfell> In-Reply-To: <20201207123514.65e4b868@eldfell> References: <1606816916-3724-1-git-send-email-jpark37@lagfreegames.com> <1606816916-3724-2-git-send-email-jpark37@lagfreegames.com> <2dbbc3dc-4df8-9ca4-4dce-808df0b24950@daenzer.net> <20201204101151.55f487b8@eldfell> <20201207105109.599273be@eldfell> <20201207123514.65e4b868@eldfell> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel , Michel =?UTF-8?B?RMOkbnplcg==?= , James Park Content-Type: multipart/mixed; boundary="===============0152851378==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0152851378== Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/UjzOL3_JVOw/oRdG7UjG5qp"; protocol="application/pgp-signature" --Sig_/UjzOL3_JVOw/oRdG7UjG5qp Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 7 Dec 2020 12:35:14 +0200 Pekka Paalanen wrote: > On Mon, 7 Dec 2020 01:08:58 -0800 > James Park wrote: >=20 > > I'm not completely sure what you're saying, but doesn't drm_base_types.h > > (now drm_basic_types.h) make things robust to header order? The patch i= s in > > another email. You can also see it here: > > https://github.com/jpark37/linux/commit/0cc8ae750bfd9eab7e31c7de6aa84f2= 4682f4f18 =20 >=20 > If that is robust (I don't know if it is, I haven't checked), then why > do you have #ifdef DRM_FOURCC_STANDALONE in it at all? >=20 > Like Simon said: >=20 > On Mon, 07 Dec 2020 10:02:36 +0000 > Simon Ser wrote: >=20 > > In my compositors I'd like to globally define DRM_FOURCC_STANDALONE > > (to make sure I don't miss any #define) but I still may include drm.h > > in the same files as well. =20 >=20 > If any project #defines it globally, then what good does checking for > it do? Why not assume that everyone will always want what > DRM_FOURCC_STANDALONE would bring? Sorry! Now I got it. DRM_FOURCC_STANDALONE is a promise that the user is not relying on drm_foucc.h to pull in drm.h. Nothing else. That's fine. But then, the code in the header should be literally #ifndef DRM_FOURCC_STANDALONE #include "drm.h" #endif without an #else branch. Thanks, pq --Sig_/UjzOL3_JVOw/oRdG7UjG5qp Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJQjwWQChkWOYOIONI1/ltBGqqqcFAl/OB6YACgkQI1/ltBGq qqfRFA//fyzD/qQNmgs/ZVVt/vyXI/hLrjKLQa+QqMKS8VOBPGsfS4M9/b2lofNa ayaBpIOdr8CI+E/bzKTaMg1kugOFgDmKLQTFUSGE8m2JmnCoMjHY6SWSXwoGEABy aeydSGGVu0kDlQwJLe0c0USdss27xEgWfrXir0lWXWTROxzN2XUFeAJ+MSK19G+l 1b2RJ8KlGIwFw2HLDhdqeWDusLh3K5D73nFrz++/2lilnC0YMllSW3BMzfX/S2uV uJ4XfrVBHrrdoGD66DhvQMhgH6zjcATtk+Ne1oq5XNNsr6hjRymaw9kj5co+zghH f4kPM+aGroY/V6+P20Iv6MsZWX9efIE19AUiSJK1QUQeE+5Ix9JcXJFFnBtKmuem +0exS9twLVDrs2rsy978pokdkCqCvcntlgwnEF+8Ajij85GyRyYCq0aEmRzmOxF0 QwlvO1ZKqOl7XYyb0TH3LGvV2oRFqhifrYqLtnHAh5pI8OIzDOpBNN5xM4zP4utO egIppaHxTQjLGMzlGJpQlnpxzy+M4CCRrPrT5x5y9h+qL0M8eeBFEDzWoRZQt9+T 22j/XqE1RdnuGbSi5CIAJM98d2QgF2Xxe+2qMAoGotkQuy5a+jyZblxeEeESQvAw fWXeMBmEgY32FNXQBm6Dzx/DDEr145N16F7nyOQClXbXPvQNrsk= =zqa5 -----END PGP SIGNATURE----- --Sig_/UjzOL3_JVOw/oRdG7UjG5qp-- --===============0152851378== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0152851378==--