From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A4AC433E6 for ; Fri, 22 Jan 2021 08:46:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E950A235F9 for ; Fri, 22 Jan 2021 08:46:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E950A235F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A36256E9BA; Fri, 22 Jan 2021 08:45:57 +0000 (UTC) Received: from xanadu.blop.info (xanadu.blop.info [178.79.145.134]) by gabe.freedesktop.org (Postfix) with ESMTPS id C0A8E6E90F for ; Thu, 21 Jan 2021 16:26:35 +0000 (UTC) Received: from [127.0.0.1] (helo=xanadu.blop.info) by xanadu.blop.info with smtp (Exim 4.89) (envelope-from ) id 1l2cn0-0001Ik-Ej; Thu, 21 Jan 2021 17:26:30 +0100 Received: (nullmailer pid 16901 invoked by uid 1000); Thu, 21 Jan 2021 16:26:22 -0000 Date: Thu, 21 Jan 2021 17:26:22 +0100 From: Lucas Nussbaum To: Maxime Ripard Subject: Re: [PATCH 1/2] drm/vc4: Correct lbm size and calculation Message-ID: <20210121162622.GA16797@xanadu.blop.info> References: <20210121105759.1262699-1-maxime@cerno.tech> <20210121110406.yeb4zoqwwgilyrhq@gilmour> MIME-Version: 1.0 In-Reply-To: <20210121110406.yeb4zoqwwgilyrhq@gilmour> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Fri, 22 Jan 2021 08:45:43 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Dave Stevenson , dri-devel@lists.freedesktop.org, Ryutaroh Matsumoto Content-Type: multipart/mixed; boundary="===============0418424476==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0418424476== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FCuugMFkClbJLl1L" Content-Disposition: inline --FCuugMFkClbJLl1L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Maxime, On 21/01/21 at 12:04 +0100, Maxime Ripard wrote: > Hi Lucas, Ryutaroh, >=20 > On Thu, Jan 21, 2021 at 11:57:58AM +0100, Maxime Ripard wrote: > > From: Dom Cobley > >=20 > > LBM base address is measured in units of pixels per cycle. > > That is 4 for 2711 (hvs5) and 2 for 2708. > >=20 > > We are wasting 75% of lbm by indexing without the scaling. > > But we were also using too high a size for the lbm resulting > > in partial corruption (right hand side) of vertically > > scaled images, usually at 4K or lower resolutions with more layers. > >=20 > > The physical RAM of LBM on 2711 is 8 * 1920 * 16 * 12-bit > > (pixels are stored 12-bits per component regardless of format). > >=20 > > The LBM adress indexes work in units of pixels per clock, > > so for 4 pixels per clock that means we have 32 * 1920 =3D 60K > >=20 > > Fixes: c54619b0bfb3 ("drm/vc4: Add support for the BCM2711 HVS5") > > Signed-off-by: Dom Cobley > > Signed-off-by: Maxime Ripard >=20 > This one should fix your issue >=20 > Feel free to test it and let me know if it's not the case I confirm that the patches fix the issue I was seeing. Thanks! Lucas --FCuugMFkClbJLl1L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE/t7ByzN7z1CfQ8IkORS1MvTfvpkFAmAJqy4ACgkQORS1MvTf vpln6w/6AzLnuDP7TAvRkH+N1Eth1BaqdaZXjMNSmQF+qcAQTbnSXnoLia/q3wVE 6eRxPz1phHG++upClmnGAU4ftCAru6lvSxtpB8kJeniWlZWK8Jq3LdnkA6Z2J/0i FVa50HVDTMNUlz/bN6hQXZzV4lAVIhoTlk6WNq/4XsVUaQnsynSNqaXJhRj97FQv M5McSxwIvn8Ru5b2UqtYsXcAsGG1aH8pNztmpFUUGr1mGaXBmzloQw3RemPlorYB xh9eX6ylq4TyM50L8IBKkn75J1TLRvyZqARWxyCoZX/VuN23ZnqA2PUj1hSrcekP LVaaGF5/ZogJKH/5LqD2CnOg3A/zxtMF4o5QESk9CGoqTdK+STjU87MA5CQgymd6 D4M+7sse2apJ03fsoNFPpxfB79oEdf8LUSzY/fiWk5+PW5fd023kj24DcC1OhCjv lmD1ABNq2MBOiSYRRJOiYY+4/9n9iC8ZavkV1ceCk/aaLsZJCsGRbt89x39L1+Io +A1DhG27yboEcMZ1uw6FnxqL4tF3j1F9YP3UPkrYnC3IAq6jQyJi3uU/4IHPtWBc oY9m/SEWtqV18uRkL9rSr1iGqgxCD9dA//ZS/wvwsslAmneBo5/kEGZWiBTdzT+u rsFSUCziIKhV+OHJVPXftBS9KQqxKu+OB/BzDsHRvwIWNfUFyeE= =gNEM -----END PGP SIGNATURE----- --FCuugMFkClbJLl1L-- --===============0418424476== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0418424476==--