Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD

From: Oliver Graute <oliver.graute@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
	Marco Felsch <m.felsch@pengutronix.de>,
	DRI mailing list <dri-devel@lists.freedesktop.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD
Date: Mon, 25 Jan 2021 22:29:17 +0100	[thread overview]
Message-ID: <20210125212917.GA4177@portage> (raw)
In-Reply-To: <CAOMZO5DKann0ojZrhjyXOqrRq9owtgrrZTGwttD_bU0-KO=aBg@mail.gmail.com>

On 16/01/21, Fabio Estevam wrote:
> On Sat, Jan 16, 2021 at 9:49 AM Oliver Graute <oliver.graute@gmail.com> wrote:
> 
> > > power-supply = <&reg_touch_3v3> is not correct, as the reg_touch_3v3
> > > does not power the LCD.
> >
> > yes, but how is the LCD correctly powered then?
> 
> J4 is powered by VCC_5V and VCC_3V#.
> 
> > [    7.795980] pwm-backlight backlight: supply power not found, using dummy regulator
> > [    7.804436] OF: /backlight: #pwm-cells = 3 found -1
> > [    7.806563] of_pwm_get(): can't parse "pwms" property
> > [    7.812026] pwm-backlight backlight: unable to request PWM
> > [    7.822929] pwm-backlight: probe of backlight failed with error -22
> 
> You need to fix this.
> 
> > [    7.876831] imx-sdma 20ec000.sdma: Direct firmware load for imx/sdma/sdma-imx6q.bin failed with error -2
> > [    7.884231] imx-sdma 20ec000.sdma: Falling back to sysfs fallback for: imx/sdma/sdma-imx6q.bin
> > [    7.916013] printk: console [ttymxc0] enabled
> > [    7.916013] printk: console [ttymxc0] enabled
> > [    7.922351] printk: bootconsole [ec_imx6q0] disabled
> > [    7.922351] printk: bootconsole [ec_imx6q0] disabled
> > [    7.952397] 21e8000.serial: ttymxc1 at MMIO 0x21e8000 (irq = 68, base_baud = 5000000) is a IMX
> > [    7.970794] 21ec000.serial: ttymxc2 at MMIO 0x21ec000 (irq = 69, base_baud = 5000000) is a IMX
> > [    8.033015] ------------[ cut here ]------------
> > [    8.037826] WARNING: CPU: 0 PID: 1 at ../drivers/gpu/drm/panel/panel-simple.c:577 panel_simple_probe+0x5dc/0x6b8
> 
> And this too
> 
> > [    8.846104] imx6ul-pinctrl 20e0000.pinctrl: pin MX6UL_PAD_NAND_CE0_B already requested by regulator-gpio; cannot claim for 1806000.nand-controller
> > [    8.859641] imx6ul-pinctrl 20e0000.pinctrl: pin-107 (1806000.nand-controller) status -22
> > [    8.867851] imx6ul-pinctrl 20e0000.pinctrl: could not request pin 107 (MX6UL_PAD_NAND_CE0_B) from group gpminandgrp  on device 20e0000.pinctrl
> > [    8.880930] gpmi-nand 1806000.nand-controller: Error applying setting, reverse things back
> > [    8.889726] gpmi-nand: probe of 1806000.nand-controller failed with error -22
> 
> And this pin conflict too.

Ok I fixed the pin conflict with regulator-gpio and added a 5V
regulator node in my dts file. Now the display is working fine!

I'll post the dts files soon and check if there is something to
improve for this patch.

Many thanks for your help,

Oliver
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel