From: kernel test robot <lkp@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>, dri-devel@lists.freedesktop.org
Cc: kbuild-all@lists.01.org, David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVER FOR QXL VIRTUAL GPU"
<virtualization@lists.linux-foundation.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH v5 6/6] drm/qxl: simplify qxl_fence_wait
Date: Wed, 3 Feb 2021 23:16:49 +0800 [thread overview]
Message-ID: <202102032359.7b6p3wW8-lkp@intel.com> (raw)
In-Reply-To: <20210203131615.1714021-7-kraxel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 3697 bytes --]
Hi Gerd,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.11-rc6 next-20210125]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Gerd-Hoffmann/drm-qxl-fix-driver-shutdown-issues/20210203-211739
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-a013-20210202 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/0b11c8d52de8c79900ab632aa3527f19c442efc6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Gerd-Hoffmann/drm-qxl-fix-driver-shutdown-issues/20210203-211739
git checkout 0b11c8d52de8c79900ab632aa3527f19c442efc6
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/qxl/qxl_release.c: In function 'qxl_fence_wait':
>> drivers/gpu/drm/qxl/qxl_release.c:61:22: warning: variable 'release' set but not used [-Wunused-but-set-variable]
61 | struct qxl_release *release;
| ^~~~~~~
vim +/release +61 drivers/gpu/drm/qxl/qxl_release.c
2f453ed4038526 Maarten Lankhorst 2014-04-02 56
f54d1867005c33 Chris Wilson 2016-10-25 57 static long qxl_fence_wait(struct dma_fence *fence, bool intr,
f54d1867005c33 Chris Wilson 2016-10-25 58 signed long timeout)
2f453ed4038526 Maarten Lankhorst 2014-04-02 59 {
2f453ed4038526 Maarten Lankhorst 2014-04-02 60 struct qxl_device *qdev;
2f453ed4038526 Maarten Lankhorst 2014-04-02 @61 struct qxl_release *release;
2f453ed4038526 Maarten Lankhorst 2014-04-02 62 unsigned long cur, end = jiffies + timeout;
2f453ed4038526 Maarten Lankhorst 2014-04-02 63
2f453ed4038526 Maarten Lankhorst 2014-04-02 64 qdev = container_of(fence->lock, struct qxl_device, release_lock);
2f453ed4038526 Maarten Lankhorst 2014-04-02 65 release = container_of(fence, struct qxl_release, base);
2f453ed4038526 Maarten Lankhorst 2014-04-02 66
f54d1867005c33 Chris Wilson 2016-10-25 67 if (dma_fence_is_signaled(fence))
2f453ed4038526 Maarten Lankhorst 2014-04-02 68 goto signaled;
2f453ed4038526 Maarten Lankhorst 2014-04-02 69
2f453ed4038526 Maarten Lankhorst 2014-04-02 70 qxl_io_notify_oom(qdev);
0b11c8d52de8c7 Gerd Hoffmann 2021-02-03 71 if (!wait_event_timeout(qdev->release_event,
0b11c8d52de8c7 Gerd Hoffmann 2021-02-03 72 dma_fence_is_signaled(fence),
0b11c8d52de8c7 Gerd Hoffmann 2021-02-03 73 timeout))
2f453ed4038526 Maarten Lankhorst 2014-04-02 74 return 0;
2f453ed4038526 Maarten Lankhorst 2014-04-02 75
2f453ed4038526 Maarten Lankhorst 2014-04-02 76 signaled:
2f453ed4038526 Maarten Lankhorst 2014-04-02 77 cur = jiffies;
2f453ed4038526 Maarten Lankhorst 2014-04-02 78 if (time_after(cur, end))
2f453ed4038526 Maarten Lankhorst 2014-04-02 79 return 0;
2f453ed4038526 Maarten Lankhorst 2014-04-02 80 return end - cur;
2f453ed4038526 Maarten Lankhorst 2014-04-02 81 }
2f453ed4038526 Maarten Lankhorst 2014-04-02 82
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37567 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2021-02-03 15:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 13:16 [PATCH v5 0/6] drm/qxl: fix driver shutdown issues Gerd Hoffmann
2021-02-03 13:16 ` [PATCH v5 1/6] drm/qxl: use drmm_mode_config_init Gerd Hoffmann
2021-02-03 13:16 ` [PATCH v5 2/6] drm/qxl: unpin release objects Gerd Hoffmann
2021-02-03 14:00 ` Thomas Zimmermann
2021-02-03 13:16 ` [PATCH v5 3/6] drm/qxl: release shadow on shutdown Gerd Hoffmann
2021-02-03 14:05 ` Thomas Zimmermann
2021-02-03 13:16 ` [PATCH v5 4/6] drm/qxl: handle shadow in primary destroy Gerd Hoffmann
2021-02-03 14:07 ` Thomas Zimmermann
2021-02-03 13:16 ` [PATCH v5 5/6] drm/qxl: properly free qxl releases Gerd Hoffmann
2021-02-03 14:12 ` Thomas Zimmermann
2021-02-03 13:16 ` [PATCH v5 6/6] drm/qxl: simplify qxl_fence_wait Gerd Hoffmann
2021-02-03 14:14 ` Thomas Zimmermann
2021-02-03 15:16 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102032359.7b6p3wW8-lkp@intel.com \
--to=lkp@intel.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kbuild-all@lists.01.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).