From: Imre Deak <imre.deak@intel.com>
To: dri-devel@lists.freedesktop.org, Lyude Paul <lyude@redhat.com>
Cc: Wayne Lin <Wayne.Lin@amd.com>
Subject: Re: [PATCH 2/4] drm/dp_mst: Don't cache EDIDs for physical ports
Date: Thu, 4 Feb 2021 19:54:47 +0200 [thread overview]
Message-ID: <20210204175447.GA750296@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20210201120145.350258-2-imre.deak@intel.com>
On Mon, Feb 01, 2021 at 02:01:43PM +0200, Imre Deak wrote:
> Caching EDIDs for physical ports prevents updating the EDID if a port
> gets reconnected via a Connection Status Notification message, fix this.
>
> Fixes: db1a07956968 ("drm/dp_mst: Handle SST-only branch device case")
> Cc: Wayne Lin <Wayne.Lin@amd.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Pushed patches 2-4 to drm-misc-next, thanks for the review.
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> index deb7995f42fa..309afe61afdd 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -2302,7 +2302,8 @@ drm_dp_mst_port_add_connector(struct drm_dp_mst_branch *mstb,
> }
>
> if (port->pdt != DP_PEER_DEVICE_NONE &&
> - drm_dp_mst_is_end_device(port->pdt, port->mcs)) {
> + drm_dp_mst_is_end_device(port->pdt, port->mcs) &&
> + port->port_num >= DP_MST_LOGICAL_PORT_0) {
> port->cached_edid = drm_get_edid(port->connector,
> &port->aux.ddc);
> drm_connector_set_tile_property(port->connector);
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-02-04 17:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 12:01 [PATCH 1/4] drm/dp_mst: Don't report ports connected if nothing is attached to them Imre Deak
2021-02-01 12:01 ` [PATCH 2/4] drm/dp_mst: Don't cache EDIDs for physical ports Imre Deak
2021-02-02 3:38 ` Lin, Wayne
2021-02-02 11:22 ` Imre Deak
2021-02-03 2:56 ` Lin, Wayne
2021-02-04 17:54 ` Imre Deak [this message]
2021-02-01 12:01 ` [PATCH 3/4] drm/dp_mst: Remove redundant tile property setting Imre Deak
2021-02-01 12:01 ` [PATCH 4/4] drm/dp_mst: Use DP_MST_LOGICAL_PORT_0 instead of magic number Imre Deak
2021-02-01 22:04 ` [PATCH 1/4] drm/dp_mst: Don't report ports connected if nothing is attached to them Lyude Paul
2021-02-03 21:15 ` [Intel-gfx] " Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204175447.GA750296@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=Wayne.Lin@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lyude@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).