From: Daniel Thompson <daniel.thompson@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] backlight: ktd253: Bring up in a known state
Date: Fri, 5 Feb 2021 17:27:18 +0000 [thread overview]
Message-ID: <20210205172718.dajtb5yc3haatz3z@maple.lan> (raw)
In-Reply-To: <20210126213200.14366-1-linus.walleij@linaro.org>
On Tue, Jan 26, 2021 at 10:32:00PM +0100, Linus Walleij wrote:
> The KTD253 backlight might already be on when the driver
> is probed: then we don't really know what the current
> ratio is and all light intensity settings will be off
> relative to what it was at boot.
>
> To fix this, bring up the backlight OFF then move it to
> the default backlight from there so we know the state.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Hmnnn... horid, since the backlight will flicker during boot,
but I recall that this bit of hardware is pretty horid anyway
so it is not easily avoided.
Therefore, slightly grudgingly,
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-02-05 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 21:32 [PATCH] backlight: ktd253: Bring up in a known state Linus Walleij
2021-02-05 17:27 ` Daniel Thompson [this message]
2021-02-09 10:10 ` Linus Walleij
2021-02-09 14:10 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205172718.dajtb5yc3haatz3z@maple.lan \
--to=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).