From: Maxime Ripard <maxime@cerno.tech>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: "Xinliang Liu" <xinliang.liu@linaro.org>,
dri-devel@lists.freedesktop.org,
"Anitha Chrisanthus" <anitha.chrisanthus@intel.com>,
linux-stm32@st-md-mailman.stormreply.com,
"Jerome Brunet" <jbrunet@baylibre.com>,
linux-samsung-soc@vger.kernel.org,
"Kevin Hilman" <khilman@baylibre.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"VMware Graphics" <linux-graphics-maintainer@vmware.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Roland Scheidegger" <sroland@vmware.com>,
"Sean Paul" <sean@poorly.run>, "Hyun Kwon" <hyun.kwon@xilinx.com>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
linux-kernel@vger.kernel.org,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Alex Deucher" <alexander.deucher@amd.com>,
freedreno@lists.freedesktop.org,
"Gerd Hoffmann" <kraxel@redhat.com>,
"David Airlie" <airlied@linux.ie>,
nouveau@lists.freedesktop.org,
"Edmund Dea" <edmund.j.dea@intel.com>,
virtualization@lists.linux-foundation.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Mihail Atanassov" <mihail.atanassov@arm.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-rockchip@lists.infradead.org,
"James (Qian) Wang" <james.qian.wang@arm.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Dave Airlie" <airlied@redhat.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
linux-arm-msm@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
"Rodrigo Siqueira" <rodrigosiqueiramelo@gmail.com>,
"Sandy Huang" <hjc@rock-chips.com>,
"Yannick Fertre" <yannick.fertre@st.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Haneen Mohammed" <hamohammed.sa@gmail.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Melissa Wen" <melissa.srw@gmail.com>,
linux-tegra@vger.kernel.org,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
amd-gfx@lists.freedesktop.org, "Chen-Yu Tsai" <wens@csie.org>,
"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
"Chen Feng" <puck.chen@hisilicon.com>,
"Alison Wang" <alison.wang@nxp.com>,
spice-devel@lists.freedesktop.org,
"Tomi Valkeinen" <tomba@kernel.org>,
"Philippe Cornu" <philippe.cornu@st.com>,
"Vincent Abriou" <vincent.abriou@st.com>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"Tian Tao" <tiantao6@hisilicon.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Christian König" <christian.koenig@amd.com>,
"Liviu Dudau" <liviu.dudau@arm.com>,
"Paul Cercueil" <paul@crapouillou.net>,
linux-renesas-soc@vger.kernel.org,
"Joonyoung Shim" <jy0922.shim@samsung.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-mediatek@lists.infradead.org,
"Laurentiu Palcu" <laurentiu.palcu@oss.nxp.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
linux-mips@vger.kernel.org, "Jyri Sarha" <jyri.sarha@iki.fi>
Subject: Re: [PATCH v3 02/11] drm: Rename plane atomic_check state names
Date: Fri, 19 Feb 2021 16:12:35 +0100 [thread overview]
Message-ID: <20210219151235.dsv4mujqyrzndhsn@gilmour> (raw)
In-Reply-To: <51bb5aaf-f771-020b-9a48-77d8679de6a2@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 1171 bytes --]
Hi Thomas,
Thanks for your review!
On Fri, Feb 19, 2021 at 03:49:22PM +0100, Thomas Zimmermann wrote:
> > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c
> > index 075508051b5f..1873a155bb26 100644
> > --- a/drivers/gpu/drm/imx/ipuv3-plane.c
> > +++ b/drivers/gpu/drm/imx/ipuv3-plane.c
> > @@ -337,12 +337,12 @@ static const struct drm_plane_funcs ipu_plane_funcs = {
> > };
> > static int ipu_plane_atomic_check(struct drm_plane *plane,
> > - struct drm_plane_state *state)
> > + struct drm_plane_state *new_state)
>
> This function uses a different naming convention then the others?
>
> > {
> > struct drm_plane_state *old_state = plane->state;
So, the function already had a variable named old_state, so I was
actually trying to make the drivers consistent here: having one variable
with old_state and new_plane_state felt weird.
The heuristic is thus to use the convention of the driver if one exists
already, and if there's none pick new_plane_state.
It makes it indeed inconsistent across drivers, but it felt more natural
to be consistent within a single driver.
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-02-19 15:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 12:00 [PATCH v3 01/11] drm/atomic: Pass the full state to planes async atomic check and update Maxime Ripard
2021-02-19 12:00 ` [PATCH v3 02/11] drm: Rename plane atomic_check state names Maxime Ripard
2021-02-19 14:49 ` Thomas Zimmermann
2021-02-19 15:12 ` Maxime Ripard [this message]
2021-02-22 9:01 ` Thomas Zimmermann
2021-02-19 12:00 ` [PATCH v3 03/11] drm/atmel-hlcdc: Rename custom plane state variable Maxime Ripard
2021-02-19 12:00 ` [PATCH v3 04/11] drm/atomic: Pass the full state to planes atomic_check Maxime Ripard
2021-02-22 9:00 ` Thomas Zimmermann
2021-02-19 12:00 ` [PATCH v3 05/11] drm: Use the state pointer directly in " Maxime Ripard
2021-02-22 9:05 ` Thomas Zimmermann
2021-02-19 12:00 ` [PATCH v3 06/11] drm: Use state helper instead of plane state pointer in atomic_check Maxime Ripard
2021-02-22 9:12 ` Thomas Zimmermann
2021-02-23 14:41 ` Maxime Ripard
2021-02-19 12:00 ` [PATCH v3 07/11] drm: Store new plane state in a variable for atomic_update and disable Maxime Ripard
2021-02-19 12:00 ` [PATCH v3 08/11] drm: Rename plane->state variables in atomic update " Maxime Ripard
2021-02-19 12:00 ` [PATCH v3 09/11] drm/atomic: Pass the full state to planes atomic disable and update Maxime Ripard
2021-02-19 12:00 ` [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer Maxime Ripard
2021-03-30 1:52 ` Stephen Boyd
2021-03-30 15:35 ` Maxime Ripard
2021-03-30 18:56 ` Stephen Boyd
2021-04-08 13:20 ` Maxime Ripard
2021-04-30 16:44 ` Rob Clark
2021-05-04 7:40 ` Daniel Vetter
2021-02-19 12:00 ` [PATCH v3 11/11] drm/todo: Remove the drm_atomic_state todo item Maxime Ripard
2021-02-24 11:33 ` [PATCH v3 01/11] drm/atomic: Pass the full state to planes async atomic check and update Thomas Zimmermann
2021-02-25 7:08 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219151235.dsv4mujqyrzndhsn@gilmour \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=alexandre.torgue@st.com \
--cc=alison.wang@nxp.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=anitha.chrisanthus@intel.com \
--cc=benjamin.gaignard@linaro.org \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=edmund.j.dea@intel.com \
--cc=freedreno@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=hjc@rock-chips.com \
--cc=hyun.kwon@xilinx.com \
--cc=james.qian.wang@arm.com \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@siol.net \
--cc=jonathanh@nvidia.com \
--cc=jy0922.shim@samsung.com \
--cc=jyri.sarha@iki.fi \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kraxel@redhat.com \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=laurentiu.palcu@oss.nxp.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liviu.dudau@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=melissa.srw@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=mihail.atanassov@arm.com \
--cc=narmstrong@baylibre.com \
--cc=nouveau@lists.freedesktop.org \
--cc=paul@crapouillou.net \
--cc=philippe.cornu@st.com \
--cc=puck.chen@hisilicon.com \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sean@poorly.run \
--cc=shawnguo@kernel.org \
--cc=spice-devel@lists.freedesktop.org \
--cc=sroland@vmware.com \
--cc=sunpeng.li@amd.com \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@gmail.com \
--cc=tiantao6@hisilicon.com \
--cc=tomba@kernel.org \
--cc=tzimmermann@suse.de \
--cc=vincent.abriou@st.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wens@csie.org \
--cc=xinliang.liu@linaro.org \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).