From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED70DC433C1 for ; Thu, 25 Mar 2021 11:55:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC301619EC for ; Thu, 25 Mar 2021 11:55:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC301619EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BB106ED12; Thu, 25 Mar 2021 11:55:59 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id D36496ED12 for ; Thu, 25 Mar 2021 11:55:57 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id n11-20020a05600c4f8bb029010e5cf86347so4210468wmq.1 for ; Thu, 25 Mar 2021 04:55:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=z1h6GONbhgF2Yys7ho0AM9P0VvfqpLXnfjdbS9zycO8=; b=liEzoQJWZcRCyAUZGNG/ljaZ5tYWORY9q9YoaJmDs63lxfkaGFLfePnbCqlrFfeal/ AjNCVFzB37coNtFS6UCerAo5nlRrUxr3lfBssgQzDxWNhMiIMlq5LBv0/Zb8xn2NW/xK olQSiPMwMtpa2DiTVw6AWnjacSCpeD+zfmTqMXEKLAY2ZaNzTuQMuIyeWVlDVx1CyoLS amdA7ZM+aBaEWhM35DhAfW0StzmC8cB+G5UYfMVW/lyWPrZq1IKGcmRtBwqR8mfFoNTa 8HZ91X8U2xoXj8C3hAf/LMYGtwuXe1mQ0gsl35RPbxma+QXLAxzYIa7ysCeeXeyHwIBQ +tpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z1h6GONbhgF2Yys7ho0AM9P0VvfqpLXnfjdbS9zycO8=; b=khgw1aCe8GltpwqZh/i3rrVoLI7jHuRXmjXCyO2u6t64knbFfUerqkuMVYnTwDiVF1 PAnNTI/+pD+dK34ueL7fbVwnAeIjj/6/k4QLEwFHljyujJhdGQoxTIoGWfjwwVCvWn4g o1CKtis55ckN6kxbKqDuxJbecLMrE/KJ6Ornl1eax1ynpZ9IlW6eRXwkPllcDG4WBc0e ykSNNNv9m6M/2h3tmCjyohxmHnLnChRwnrl9r56HWL93MzBfw+ejzk4mKobDu5AkobYt /ZR+dgJZyhiSkeKR396eBS6VFcbV+Efi5V7qjY5ibukPLlZ3rav7bwHGMqx2aIK2BBPs n5ZA== X-Gm-Message-State: AOAM530d56D2UJ+JQgYASiida4ZHj9XAdPlXQfsoWTZNXLw1E9vIKY1d pjIN+HG9f86UM30O/R4klFw= X-Google-Smtp-Source: ABdhPJzQTKTtceUKIj0vScCdI4m3+AyGii4BnVfodiCidTnvVE4Ta+heOnzSzylierhrqKSfl0o9ZQ== X-Received: by 2002:a7b:cc85:: with SMTP id p5mr7615480wma.148.1616673356553; Thu, 25 Mar 2021 04:55:56 -0700 (PDT) Received: from smtp.gmail.com (a95-92-181-29.cpe.netcabo.pt. [95.92.181.29]) by smtp.gmail.com with ESMTPSA id i16sm8469770wmq.3.2021.03.25.04.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 04:55:56 -0700 (PDT) Date: Thu, 25 Mar 2021 08:55:50 -0300 From: Melissa Wen To: Dmitry Vyukov Subject: Re: [PATCH] drm/vkms: fix misuse of WARN_ON Message-ID: <20210325115550.t4w3eucgcctqoqeb@smtp.gmail.com> References: <20210320132840.1315853-1-dvyukov@google.com> <20210324220008.nqwwwfugyfngbn3x@smtp.gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haneen Mohammed , Rodrigo Siqueira , David Airlie , syzbot+4fc21a003c8332eb0bdd@syzkaller.appspotmail.com, LKML , DRI Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 03/25, Dmitry Vyukov wrote: > On Wed, Mar 24, 2021 at 11:00 PM Melissa Wen wrote: > > > > On 03/20, Dmitry Vyukov wrote: > > > vkms_vblank_simulate() uses WARN_ON for timing-dependent condition > > > (timer overrun). This is a mis-use of WARN_ON, WARN_ON must be used > > > to denote kernel bugs. Use pr_warn() instead. > > > > > > Signed-off-by: Dmitry Vyukov > > > Reported-by: syzbot+4fc21a003c8332eb0bdd@syzkaller.appspotmail.com > > > Cc: Rodrigo Siqueira > > > Cc: Melissa Wen > > > Cc: Haneen Mohammed > > > Cc: Daniel Vetter > > > Cc: David Airlie > > > Cc: dri-devel@lists.freedesktop.org > > > Cc: linux-kernel@vger.kernel.org > > > Change-Id: I7f01c288092bc7e472ec63af198f93ce3d8c49f7 > > > --- > > > drivers/gpu/drm/vkms/vkms_crtc.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c > > > index 0443b7deeaef6..758d8a98d96b3 100644 > > > --- a/drivers/gpu/drm/vkms/vkms_crtc.c > > > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c > > > @@ -18,7 +18,8 @@ static enum hrtimer_restart vkms_vblank_simulate(struct hrtimer *timer) > > > > > > ret_overrun = hrtimer_forward_now(&output->vblank_hrtimer, > > > output->period_ns); > > > - WARN_ON(ret_overrun != 1); > > > + if (ret_overrun != 1) > > > + pr_warn("%s: vblank timer overrun\n", __func__); > > > > Hi Dmitry, > > > > Thanks for your patch. > > > > Looks good to me. > > The Change-Id tag just seems a little noisy to me, but can be > > fixed while applying. > > Yes, please drop Change-Id when applying if possible. Sorry for that. > Thanks for the review, Melissa. Applied to drm-misc-next. Thanks, Melissa > > > Acked-by: Melissa Wen > > > > > > > > spin_lock(&output->lock); > > > ret = drm_crtc_handle_vblank(crtc); > > > > > > base-commit: e94c55b8e0a0bbe9a026250cf31e2fa45957d776 > > > -- > > > 2.31.0.291.g576ba9dcdaf-goog > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel