From: Xin Ji <xji@analogixsemi.com>
To: Sean Paul <sean@poorly.run>
Cc: devel@driverdev.osuosl.org, Nicolas Boichat <drinkcat@google.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Sam Ravnborg <sam@ravnborg.org>, Jonas Karlman <jonas@kwiboo.se>,
David Airlie <airlied@linux.ie>,
Zhen Li <zhenli@analogixsemi.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Neil Armstrong <narmstrong@baylibre.com>,
LKML <linux-kernel@vger.kernel.org>,
Foss <robert.foss@linaro.org>,
Vasily Khoruzhick <anarsoul@gmail.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Torsten Duwe <duwe@lst.de>, Sheng Pan <span@analogixsemi.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bernie Liang <bliang@analogixsemi.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v6 4/5] drm/bridge: anx7625: add HDCP support
Date: Fri, 2 Apr 2021 10:27:08 +0800 [thread overview]
Message-ID: <20210402022708.GA2154388@anxtwsw-Precision-3640-Tower> (raw)
In-Reply-To: <CAMavQKJHakp0ZfHFEy77r8wHY+3uaP-6Ab2ren6vA46njpjx3g@mail.gmail.com>
On Mon, Mar 29, 2021 at 02:02:08PM -0400, Sean Paul wrote:
> On Mon, Mar 29, 2021 at 6:27 AM Xin Ji <xji@analogixsemi.com> wrote:
> >
> > On Thu, Mar 25, 2021 at 02:19:23PM -0400, Sean Paul wrote:
> > > On Fri, Mar 19, 2021 at 2:35 AM Xin Ji <xji@analogixsemi.com> wrote:
> > > >
> > > > Add HDCP feature, enable HDCP function through chip internal key
> > > > and downstream's capability.
> > > >
> > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > ---
>
> /snip
>
> > > > static void anx7625_dp_start(struct anx7625_data *ctx)
> > > > {
> > > > int ret;
> > > > @@ -643,6 +787,9 @@ static void anx7625_dp_start(struct anx7625_data *ctx)
> > > > return;
> > > > }
> > > >
> > > > + /* HDCP config */
> > > > + anx7625_hdcp_setting(ctx);
> > >
> > > You should really use the "Content Protection" property to
> > > enable/disable HDCP instead of force-enabling it at all times.
> > >
> > > Sean
> > Hi Sean, it's hard to implement "Content Protection" property, we have
> > implemented HDCP in firmware, it is not compatible with it. We don't
> > have interface to get Downstream Cert.
> > Thanks,
> > Xin
>
> Hi Xin,
> I'm sorry, I don't understand what you mean when you say you don't
> have an interface to get Downstream Cert.
>
> The Content Protection property is just a means through which
> userspace can turn on and turn off HDCP when it needs. As far as I can
> tell, your patch turns on HDCP when the display is enabled and leaves
> it on until it is disabled. This is undesirable since it forces HDCP
> on the user.
>
> Is it impossible to enable/disable HDCP outside of display
> enable/disable on your hardware?
>
> Thanks,
>
> Sean
Hi Sean, I have commit a test patch on google review site, can you
please help to review it? I'll use Connector's ".atomic_check()"
interface to detect Content Protection property change.
(https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2674580)
Thanks,
Xin
>
> > >
> > > > +
> > > > if (ctx->pdata.is_dpi)
> > > > ret = anx7625_dpi_config(ctx);
> > > > else
>
> /snip
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-02 2:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 6:31 [PATCH v6 0/5] Add MIPI rx DPI support Xin Ji
2021-03-19 6:32 ` [PATCH v6 1/5] dt-bindings:drm/bridge:anx7625:add vendor define flags Xin Ji
2021-03-21 12:00 ` Laurent Pinchart
2021-03-24 7:51 ` Xin Ji
2021-04-01 12:33 ` Robert Foss
2021-04-02 2:29 ` Xin Ji
2021-03-19 6:33 ` [PATCH v6 2/5] drm/bridge: anx7625: fix not correct return value Xin Ji
2021-03-22 9:36 ` Robert Foss
2021-03-19 6:34 ` [PATCH v6 3/5] drm/bridge: anx7625: add MIPI DPI input feature support Xin Ji
2021-04-01 13:53 ` Robert Foss
2021-03-19 6:34 ` [PATCH v6 4/5] drm/bridge: anx7625: add HDCP support Xin Ji
2021-03-25 18:19 ` Sean Paul
2021-03-29 10:27 ` Xin Ji
2021-03-29 18:02 ` Sean Paul
2021-04-02 2:27 ` Xin Ji [this message]
2021-04-02 8:59 ` Laurent Pinchart
2021-04-02 9:15 ` Xin Ji
2021-03-19 6:35 ` [PATCH v6 5/5] drm/bridge: anx7625: add HDMI audio function Xin Ji
2021-04-01 13:58 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210402022708.GA2154388@anxtwsw-Precision-3640-Tower \
--to=xji@analogixsemi.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=anarsoul@gmail.com \
--cc=bliang@analogixsemi.com \
--cc=boris.brezillon@collabora.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@google.com \
--cc=duwe@lst.de \
--cc=hsinyi@chromium.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=span@analogixsemi.com \
--cc=zhenli@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).