Re: [PATCH 07/18] drm/vc4: hdmi: Add full range RGB helper

From: Maxime Ripard <maxime@cerno.tech>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
	Tim Gover <tim.gover@raspberrypi.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>, Jonas Karlman <jonas@kwiboo.se>,
	dri-devel@lists.freedesktop.org,
	Andrzej Hajda <a.hajda@samsung.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Phil Elwell <phil@raspberrypi.com>,
	linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH 07/18] drm/vc4: hdmi: Add full range RGB helper
Date: Wed, 14 Apr 2021 15:48:59 +0200	[thread overview]
Message-ID: <20210414134859.l5v6pfe7rskzijlf@gilmour> (raw)
In-Reply-To: <316878dc-8661-e111-27e1-ac8ab3bfc13c@suse.de>

[-- Attachment #1.1: Type: text/plain, Size: 1439 bytes --]

Hi Thomas,

On Mon, Apr 12, 2021 at 11:44:05AM +0200, Thomas Zimmermann wrote:
> 
> 
> Am 17.03.21 um 16:43 schrieb Maxime Ripard:
> > We're going to need to tell whether we want to run with a full or
> > limited range RGB output in multiple places in the code, so let's create
> > a helper that will return whether we need with full range or not.
> > 
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> 
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> 
> although with a comments
> 
> > ---
> >   drivers/gpu/drm/vc4/vc4_hdmi.c | 12 ++++++++++--
> >   1 file changed, 10 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> > index eee9751009c2..fc545072b173 100644
> > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> > @@ -95,6 +95,15 @@
> >   #define HDMI_14_MAX_TMDS_CLK   (340 * 1000 * 1000)
> > +static bool vc4_hdmi_is_full_range_rgb(struct vc4_hdmi *vc4_hdmi,
> > +				       const struct drm_display_mode *mode)
> > +{
> > +	struct vc4_hdmi_encoder *vc4_encoder = &vc4_hdmi->encoder;
> > +
> > +	return !vc4_encoder->hdmi_monitor ||
> 
> Is this ever being called from non-HDMI code? If not, I'd put an
> drm_WARN_ONCE around this check.

I'm not sure we need to worry about this, it's a static function in the
HDMI controller driver so it can't be called from anywhere else

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel