dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 1/7] drm/st7735r: Avoid spamming logs if probe is deferred
@ 2021-04-21 16:31 Andy Shevchenko
  2021-04-21 16:31 ` [PATCH v1 2/7] drm/st7586: " Andy Shevchenko
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Andy Shevchenko @ 2021-04-21 16:31 UTC (permalink / raw)
  To: Sam Ravnborg, Daniel Vetter, dri-devel, linux-kernel
  Cc: Andy Shevchenko, David Lechner, David Airlie, Kamlesh Gurudasani

The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/tiny/st7735r.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/tiny/st7735r.c b/drivers/gpu/drm/tiny/st7735r.c
index faaba0a033ea..e3cbaa846e2b 100644
--- a/drivers/gpu/drm/tiny/st7735r.c
+++ b/drivers/gpu/drm/tiny/st7735r.c
@@ -207,16 +207,12 @@ static int st7735r_probe(struct spi_device *spi)
 	drm = &dbidev->drm;
 
 	dbi->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
-	if (IS_ERR(dbi->reset)) {
-		DRM_DEV_ERROR(dev, "Failed to get gpio 'reset'\n");
-		return PTR_ERR(dbi->reset);
-	}
+	if (IS_ERR(dbi->reset))
+		return dev_err_probe(dev, PTR_ERR(dbi->reset), "Failed to get GPIO 'reset'\n");
 
 	dc = devm_gpiod_get(dev, "dc", GPIOD_OUT_LOW);
-	if (IS_ERR(dc)) {
-		DRM_DEV_ERROR(dev, "Failed to get gpio 'dc'\n");
-		return PTR_ERR(dc);
-	}
+	if (IS_ERR(dc))
+		return dev_err_probe(dev, PTR_ERR(dc), "Failed to get GPIO 'dc'\n");
 
 	dbidev->backlight = devm_of_find_backlight(dev);
 	if (IS_ERR(dbidev->backlight))
-- 
2.30.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-04-27 11:27 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 16:31 [PATCH v1 1/7] drm/st7735r: Avoid spamming logs if probe is deferred Andy Shevchenko
2021-04-21 16:31 ` [PATCH v1 2/7] drm/st7586: " Andy Shevchenko
2021-04-21 16:31 ` [PATCH v1 3/7] drm/mi0283qt: " Andy Shevchenko
2021-04-21 16:31 ` [PATCH v1 4/7] drm/ili9486: " Andy Shevchenko
2021-04-21 16:31 ` [PATCH v1 5/7] drm/ili9341: " Andy Shevchenko
2021-04-21 16:31 ` [PATCH v1 6/7] drm/ili9225: " Andy Shevchenko
2021-04-21 16:31 ` [PATCH v1 7/7] drm/hx8357d: " Andy Shevchenko
2021-04-27 11:27 ` [PATCH v1 1/7] drm/st7735r: " Noralf Trønnes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).